From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v2 1/2] seq_file: Introduce DEFINE_SHOW_ATTRIBUTE() helper macro
Date: Tue, 28 Nov 2017 14:19:54 +0200 [thread overview]
Message-ID: <1511871594.25007.464.camel@linux.intel.com> (raw)
In-Reply-To: <F129B4E0-91B1-4B7B-AF5D-A5EA29486A6E@holtmann.org>
On Tue, 2017-11-28 at 09:43 +0100, Marcel Holtmann wrote:
> Hi Andy,
>
> > The DEFINE_SHOW_ATTRIBUTE() helper macro would be useful for current
> > users, which are many of them, and for new comers to decrease code
> > duplication.
> can we define this in hci_debugfs.c first and get that patch merged
> into bluetooth-next. And only as a follow up patch try to generalize
> this in seq_file.h. I really don’t like to carry a patch for
> seq_file.h in the bluetooth-next tree.
>
This was in v1 [1].
Feel free to apply it instead. Frankly I don't understand what's wrong
with carrying patch against seq_file.h? Is it "person non grata"?
[1]: https://marc.info/?l=linux-bluetooth&m=151138535801354&w=2
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
Cc: Johan Hedberg
<johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"open list:BLUETOOTH DRIVERS"
<linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Network Development
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: Re: [PATCH v2 1/2] seq_file: Introduce DEFINE_SHOW_ATTRIBUTE() helper macro
Date: Tue, 28 Nov 2017 14:19:54 +0200 [thread overview]
Message-ID: <1511871594.25007.464.camel@linux.intel.com> (raw)
In-Reply-To: <F129B4E0-91B1-4B7B-AF5D-A5EA29486A6E-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
On Tue, 2017-11-28 at 09:43 +0100, Marcel Holtmann wrote:
> Hi Andy,
>
> > The DEFINE_SHOW_ATTRIBUTE() helper macro would be useful for current
> > users, which are many of them, and for new comers to decrease code
> > duplication.
> can we define this in hci_debugfs.c first and get that patch merged
> into bluetooth-next. And only as a follow up patch try to generalize
> this in seq_file.h. I really don’t like to carry a patch for
> seq_file.h in the bluetooth-next tree.
>
This was in v1 [1].
Feel free to apply it instead. Frankly I don't understand what's wrong
with carrying patch against seq_file.h? Is it "person non grata"?
[1]: https://marc.info/?l=linux-bluetooth&m=151138535801354&w=2
--
Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Intel Finland Oy
next prev parent reply other threads:[~2017-11-28 12:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 20:36 [PATCH v2 0/2] seq_file, Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() Andy Shevchenko
2017-11-23 20:36 ` [PATCH v2 1/2] seq_file: Introduce DEFINE_SHOW_ATTRIBUTE() helper macro Andy Shevchenko
2017-11-28 8:43 ` Marcel Holtmann
2017-11-28 12:19 ` Andy Shevchenko [this message]
2017-11-28 12:19 ` Andy Shevchenko
2017-12-13 15:38 ` Andy Shevchenko
2017-11-23 20:36 ` [PATCH v2 2/2] Bluetooth: Re-use DEFINE_SHOW_ATTRIBUTE() macro Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511871594.25007.464.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.