From: Eric Dumazet <eric.dumazet@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] make sock_alloc_file() do sock_release() on failures
Date: Fri, 01 Dec 2017 01:33:56 -0800 [thread overview]
Message-ID: <1512120836.19682.33.camel@gmail.com> (raw)
In-Reply-To: <20171201002325.GL21978@ZenIV.linux.org.uk>
On Fri, 2017-12-01 at 00:23 +0000, Al Viro wrote:
> This changes calling conventions (and simplifies the hell out
> the callers). New rules: once struct socket had been passed
> to sock_alloc_file(), it's been consumed either by struct file
> or by sock_release() done by sock_alloc_file(). Either way
> the caller should not do sock_release() after that point.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
Nice cleanup !
Reviewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2017-12-01 9:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 0:20 [RFC][PATCHES] sock_alloc_file() cleanups and fixes Al Viro
2017-12-01 0:22 ` [PATCH 1/3] socketpair(): allocate descriptors first Al Viro
2017-12-01 9:28 ` Eric Dumazet
2017-12-01 0:22 ` [PATCH 2/3] fix kcm_clone() Al Viro
2017-12-01 9:31 ` Eric Dumazet
2017-12-01 16:56 ` Tom Herbert
2017-12-01 0:23 ` [PATCH 3/3] make sock_alloc_file() do sock_release() on failures Al Viro
2017-12-01 9:33 ` Eric Dumazet [this message]
2017-12-04 15:35 ` [RFC][PATCHES] sock_alloc_file() cleanups and fixes David Miller
2017-12-04 16:41 ` Al Viro
2017-12-05 19:44 ` David Miller
2017-12-05 23:29 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2017-12-05 23:29 [PATCH 3/3] make sock_alloc_file() do sock_release() on failures Al Viro
2017-12-05 23:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512120836.19682.33.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.