From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC][PATCHES] sock_alloc_file() cleanups and fixes
Date: Mon, 4 Dec 2017 16:41:01 +0000 [thread overview]
Message-ID: <20171204164100.GS21978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20171204.103524.186631681746357000.davem@davemloft.net>
On Mon, Dec 04, 2017 at 10:35:24AM -0500, David Miller wrote:
> From: Al Viro <viro@ZenIV.linux.org.uk>
> Date: Fri, 1 Dec 2017 00:20:27 +0000
>
> > 1) massage sys_socketpair() (should be a pure cleanup)
> > 2) fix and clean up kcm_clone() (-stable fodder)
> > 3) switch sock_alloc_file() to new calling conventions.
> >
> > It got some local testing, but it certainly needs more review.
> > Diffstat for the entire thing is
>
> Series looks great to me:
>
> Acked-by: David S. Miller <davem@davemloft.net>
How do you prefer it to be handled? KCM one should go into everything
since 4.6 (with trivial modifications in 4.11 and 4.12 - both had
massaged the place around the call of kcm_clone() a bit, but this fix
overwrites the entire area and that can be dropped into earlier
kernels without any problems). I've put that into vfs.git#net-fixes
and have the other two in vfs.git#for-davem on top of that, with
you merging the latter into net-next.git and the former - into net.git.
Is that OK with you, or would you prefer some other way of handling
that kind of stuff?
next prev parent reply other threads:[~2017-12-04 16:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 0:20 [RFC][PATCHES] sock_alloc_file() cleanups and fixes Al Viro
2017-12-01 0:22 ` [PATCH 1/3] socketpair(): allocate descriptors first Al Viro
2017-12-01 9:28 ` Eric Dumazet
2017-12-01 0:22 ` [PATCH 2/3] fix kcm_clone() Al Viro
2017-12-01 9:31 ` Eric Dumazet
2017-12-01 16:56 ` Tom Herbert
2017-12-01 0:23 ` [PATCH 3/3] make sock_alloc_file() do sock_release() on failures Al Viro
2017-12-01 9:33 ` Eric Dumazet
2017-12-04 15:35 ` [RFC][PATCHES] sock_alloc_file() cleanups and fixes David Miller
2017-12-04 16:41 ` Al Viro [this message]
2017-12-05 19:44 ` David Miller
2017-12-05 23:29 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204164100.GS21978@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.