All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladislav Valtchev <vladislav.valtchev@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, y.karadz@gmail.com
Subject: Re: [PATCH v2 06/10] trace-cmd: Extr. profile-specific code from record_trace
Date: Fri, 01 Dec 2017 13:10:49 +0200	[thread overview]
Message-ID: <1512126649.4897.192.camel@gmail.com> (raw)
In-Reply-To: <20171130120514.5eb4518f@gandalf.local.home>

On Thu, 2017-11-30 at 12:05 -0500, Steven Rostedt wrote:
> I modified the subject to:
> 
>  trace-cmd: Extract profile-specific code from record_trace
> 
> Let's not abbreviate in the subject if we don't need to. It makes it
> harder to read.
> 

I'm totally fine with not abbreviating so much the subject!

I did that because of posts like this:

https://stackoverflow.com/questions/2290016/git-commit-messages-50-72-formatting

and because vim shows in yellow the first 50 characters of the summary, to help
people following that limitation. In order words, I've understood that I shall
try to fit in 50 chars and never exceed 72 chars.

That lead me to desperate attempts to save characters, like in patch 7 where
I tried to abbreviate "move" with "mov", but I couldn't add a dot for obvious
reasons. [Until now, I was used to make the summary fit in 80 characters.]

What is the convention for trace-cmd?
In particular, what's the hard-limit I shall never exceed ?

Vlad

  reply	other threads:[~2017-12-01 11:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 13:19 [PATCH v2 00/10] trace-cmd: Refactoring trace_record() Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 01/10] trace-cmd: Extract parse_record_options() from trace_record() Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 02/10] trace-cmd: Replacing cmd flags w/ a trace_cmd enum Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 03/10] trace-cmd: Extracting record_trace() Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 04/10] trace-cmd: Rename trace_profile() to do_trace_profile() Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 05/10] trace-cmd: Making start,extract,stream,profile separate funcs Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 06/10] trace-cmd: Extr. profile-specific code from record_trace Vladislav Valtchev (VMware)
2017-11-30 17:05   ` Steven Rostedt
2017-12-01 11:10     ` Vladislav Valtchev [this message]
2017-11-30 13:19 ` [PATCH v2 07/10] trace-cmd: Mov init_common_record_context in parse_record_options Vladislav Valtchev (VMware)
2017-11-30 17:07   ` Steven Rostedt
2017-12-01 11:20     ` Vladislav Valtchev
2017-11-30 13:19 ` [PATCH v2 08/10] trace-cmd: Introducing get_trace_cmd_type() Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 09/10] trace-cmd: Extract finalize_record_trace() Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 10/10] trace-cmd: Fork record_trace() for the extract case Vladislav Valtchev (VMware)
2017-11-30 21:37 ` [PATCH v2 00/10] trace-cmd: Refactoring trace_record() Steven Rostedt
2017-12-01 10:46   ` Vladislav Valtchev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512126649.4897.192.camel@gmail.com \
    --to=vladislav.valtchev@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=y.karadz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.