From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] drm/i915: Mark expected switch fall-throughs
Date: Mon, 04 Dec 2017 12:35:05 +0200 [thread overview]
Message-ID: <1512383705.4394.18.camel@linux.intel.com> (raw)
In-Reply-To: <20171127221701.GA15983@embeddedor.com>
On Mon, 2017-11-27 at 16:17 -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
I have to say I'm totally not sold on regexps matching comment
contents. Was something more explicit ever considered? Like:
#define FALLTHROUGH __attribute__((fallthrough));
With the appropriate version checks, of course.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] drm/i915: Mark expected switch fall-throughs
Date: Mon, 04 Dec 2017 12:35:05 +0200 [thread overview]
Message-ID: <1512383705.4394.18.camel@linux.intel.com> (raw)
In-Reply-To: <20171127221701.GA15983@embeddedor.com>
On Mon, 2017-11-27 at 16:17 -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
I have to say I'm totally not sold on regexps matching comment
contents. Was something more explicit ever considered? Like:
#define FALLTHROUGH __attribute__((fallthrough));
With the appropriate version checks, of course.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
next prev parent reply other threads:[~2017-12-04 10:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 22:17 [PATCH] drm/i915: Mark expected switch fall-throughs Gustavo A. R. Silva
2017-12-04 10:35 ` Joonas Lahtinen [this message]
2017-12-04 10:35 ` Joonas Lahtinen
2017-12-04 15:20 ` Gustavo A. R. Silva
2017-12-04 18:11 ` Daniel Vetter
2017-12-04 18:11 ` [Intel-gfx] " Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2018-06-28 22:35 Gustavo A. R. Silva
2018-06-28 22:35 ` Gustavo A. R. Silva
2018-06-29 8:23 ` Jani Nikula
2018-06-29 8:23 ` Jani Nikula
2018-07-05 13:43 ` Jani Nikula
2018-07-05 13:43 ` Jani Nikula
2018-07-05 13:48 ` Gustavo A. R. Silva
2018-07-05 13:48 ` Gustavo A. R. Silva
2019-07-22 18:12 Gustavo A. R. Silva
2019-07-22 18:24 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512383705.4394.18.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=garsilva@embeddedor.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.