From: Joe Perches <joe@perches.com>
To: Alan Stern <stern@rowland.harvard.edu>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "SF Markus Elfring" <elfring@users.sourceforge.net>,
"USB list" <linux-usb@vger.kernel.org>,
"Daniel Drake" <drake@endlessm.com>,
"Dmitry Fleytman" <dmitry@daynix.com>,
"Eugene Korenevsky" <ekorenevsky@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Günter Röck" <linux@roeck-us.net>,
"Johan Hovold" <johan@kernel.org>,
"Mathias Nyman" <mathias.nyman@linux.intel.com>,
"Peter Chen" <peter.chen@nxp.com>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()
Date: Thu, 07 Dec 2017 16:20:52 +0000 [thread overview]
Message-ID: <1512663652.960.41.camel@perches.com> (raw)
In-Reply-To: <97b0eeb8-834e-61ca-01dd-afbbf18697db@users.sourceforge.net>
On Thu, 2017-12-07 at 10:12 -0500, Alan Stern wrote:
> The real problem is that the kernel development community doesn't have
> a fixed policy on how to handle memory allocation errors.
[]
> If there was one agreed-upon policy, then we could definitively point
> to old code and say "That's wrong, and here is how it should be fixed."
> But currently this is not possible, and we end up with repetitive
> discussions like this one that aren't of general use.
Well stated.
My preferred policy would be to remove all the individual
allocation failure messages and only use the generic
warn_alloc()/dump_stack() mechanism.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Alan Stern <stern@rowland.harvard.edu>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "SF Markus Elfring" <elfring@users.sourceforge.net>,
"USB list" <linux-usb@vger.kernel.org>,
"Daniel Drake" <drake@endlessm.com>,
"Dmitry Fleytman" <dmitry@daynix.com>,
"Eugene Korenevsky" <ekorenevsky@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Günter Röck" <linux@roeck-us.net>,
"Johan Hovold" <johan@kernel.org>,
"Mathias Nyman" <mathias.nyman@linux.intel.com>,
"Peter Chen" <peter.chen@nxp.com>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()
Date: Thu, 07 Dec 2017 08:20:52 -0800 [thread overview]
Message-ID: <1512663652.960.41.camel@perches.com> (raw)
On Thu, 2017-12-07 at 10:12 -0500, Alan Stern wrote:
> The real problem is that the kernel development community doesn't have
> a fixed policy on how to handle memory allocation errors.
[]
> If there was one agreed-upon policy, then we could definitively point
> to old code and say "That's wrong, and here is how it should be fixed."
> But currently this is not possible, and we end up with repetitive
> discussions like this one that aren't of general use.
Well stated.
My preferred policy would be to remove all the individual
allocation failure messages and only use the generic
warn_alloc()/dump_stack() mechanism.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Alan Stern <stern@rowland.harvard.edu>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "SF Markus Elfring" <elfring@users.sourceforge.net>,
"USB list" <linux-usb@vger.kernel.org>,
"Daniel Drake" <drake@endlessm.com>,
"Dmitry Fleytman" <dmitry@daynix.com>,
"Eugene Korenevsky" <ekorenevsky@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Günter Röck" <linux@roeck-us.net>,
"Johan Hovold" <johan@kernel.org>,
"Mathias Nyman" <mathias.nyman@linux.intel.com>,
"Peter Chen" <peter.chen@nxp.com>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()
Date: Thu, 07 Dec 2017 08:20:52 -0800 [thread overview]
Message-ID: <1512663652.960.41.camel@perches.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1712071000560.1361-100000@iolanthe.rowland.org>
On Thu, 2017-12-07 at 10:12 -0500, Alan Stern wrote:
> The real problem is that the kernel development community doesn't have
> a fixed policy on how to handle memory allocation errors.
[]
> If there was one agreed-upon policy, then we could definitively point
> to old code and say "That's wrong, and here is how it should be fixed."
> But currently this is not possible, and we end up with repetitive
> discussions like this one that aren't of general use.
Well stated.
My preferred policy would be to remove all the individual
allocation failure messages and only use the generic
warn_alloc()/dump_stack() mechanism.
next prev parent reply other threads:[~2017-12-07 16:20 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 17:51 USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() SF Markus Elfring
2017-12-06 17:51 ` SF Markus Elfring
2017-12-06 17:51 ` SF Markus Elfring
2017-12-06 20:20 ` Geert Uytterhoeven
2017-12-06 20:20 ` Geert Uytterhoeven
2017-12-06 20:20 ` Geert Uytterhoeven
2017-12-06 21:33 ` SF Markus Elfring
2017-12-06 21:33 ` SF Markus Elfring
2017-12-06 21:33 ` SF Markus Elfring
2017-12-06 22:02 ` Alan Stern
2017-12-06 22:02 ` Alan Stern
2017-12-06 22:02 ` Alan Stern
2017-12-07 7:40 ` Geert Uytterhoeven
2017-12-07 7:40 ` Geert Uytterhoeven
2017-12-07 7:40 ` Geert Uytterhoeven
2017-12-07 8:35 ` Dan Carpenter
2017-12-07 8:35 ` Dan Carpenter
2017-12-07 8:35 ` Dan Carpenter
2017-12-07 8:45 ` Geert Uytterhoeven
2017-12-07 8:45 ` Geert Uytterhoeven
2017-12-07 8:45 ` Geert Uytterhoeven
2017-12-07 8:56 ` Greg Kroah-Hartman
2017-12-07 8:56 ` Greg Kroah-Hartman
2017-12-07 8:56 ` Greg Kroah-Hartman
2017-12-07 9:17 ` Oliver Neukum
2017-12-07 9:17 ` Oliver Neukum
2017-12-07 9:17 ` Oliver Neukum
2017-12-07 9:30 ` Dan Carpenter
2017-12-07 9:30 ` Dan Carpenter
2017-12-07 9:30 ` Dan Carpenter
2017-12-07 13:38 ` SF Markus Elfring
2017-12-07 13:38 ` SF Markus Elfring
2017-12-07 13:38 ` SF Markus Elfring
2017-12-07 15:12 ` Alan Stern
2017-12-07 15:12 ` Alan Stern
2017-12-07 15:12 ` Alan Stern
2017-12-07 16:20 ` Joe Perches [this message]
2017-12-07 16:20 ` Joe Perches
2017-12-07 16:20 ` Joe Perches
2017-12-07 20:51 ` Dan Carpenter
2017-12-07 20:51 ` Dan Carpenter
2017-12-07 20:51 ` Dan Carpenter
2017-12-07 21:26 ` Alan Stern
2017-12-07 21:26 ` Alan Stern
2017-12-07 21:26 ` Alan Stern
2017-12-08 7:43 ` Geert Uytterhoeven
2017-12-08 7:43 ` Geert Uytterhoeven
2017-12-08 7:43 ` Geert Uytterhoeven
2017-12-08 11:11 ` Dan Carpenter
2017-12-08 11:11 ` Dan Carpenter
2017-12-08 11:11 ` Dan Carpenter
2017-12-08 17:42 ` Alan Stern
2017-12-08 17:42 ` Alan Stern
2017-12-08 17:42 ` Alan Stern
-- strict thread matches above, loose matches on Subject: below --
2017-12-08 12:00 USB: hub: Checking communication difficulties SF Markus Elfring
2017-12-08 12:00 ` SF Markus Elfring
2017-12-08 12:00 ` USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() SF Markus Elfring
2017-12-06 16:13 [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer( SF Markus Elfring
2017-12-06 16:13 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() SF Markus Elfring
2017-12-06 16:13 ` SF Markus Elfring
2017-12-06 16:45 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Alan Stern
2017-12-06 16:45 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Alan Stern
2017-12-06 16:45 ` Alan Stern
2017-12-06 16:57 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Greg Kroah-Hartman
2017-12-06 16:57 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Greg Kroah-Hartman
2017-12-06 16:57 ` Greg Kroah-Hartman
2017-12-06 17:27 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Geert Uytterhoeven
2017-12-06 17:27 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Geert Uytterhoeven
2017-12-06 17:27 ` Geert Uytterhoeven
2017-12-06 20:05 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Joe Perches
2017-12-06 20:05 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Joe Perches
2017-12-06 20:05 ` Joe Perches
2017-12-06 21:18 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Alan Stern
2017-12-06 21:18 ` [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Alan Stern
2017-12-06 21:18 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512663652.960.41.camel@perches.com \
--to=joe@perches.com \
--cc=dmitry@daynix.com \
--cc=drake@endlessm.com \
--cc=ekorenevsky@gmail.com \
--cc=elfring@users.sourceforge.net \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mathias.nyman@linux.intel.com \
--cc=peter.chen@nxp.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.