From: Eric Dumazet <eric.dumazet@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: syzbot
<bot+ed0838d0fa4c4f2b528e20286e6dc63effc7c14d@syzkaller.appspotmail.com>,
davem <davem@davemloft.net>, kuznet <kuznet@ms2.inr.ac.ru>,
LKML <linux-kernel@vger.kernel.org>,
linux-sctp@vger.kernel.org, network dev <netdev@vger.kernel.org>,
Neil Horman <nhorman@tuxdriver.com>,
syzkaller-bugs@googlegroups.com,
Vlad Yasevich <vyasevich@gmail.com>,
yoshfuji <yoshfuji@linux-ipv6.org>
Subject: Re: kernel BUG at net/core/skbuff.c:LINE! (2)
Date: Sun, 10 Dec 2017 04:51:10 +0000 [thread overview]
Message-ID: <1512881470.25033.38.camel@gmail.com> (raw)
In-Reply-To: <CADvbK_dMfCf82LYZWeWp1EOzStwuTyjP7SzbUwa0vnT5sc38Qw@mail.gmail.com>
On Sun, 2017-12-10 at 12:36 +0800, Xin Long wrote:
> The new patch works to me, just two questions:
> 1. should it use "idev->cnf.mtu6" here for mld ?
No idea why some parts of IPv6 would use a different view of device
mtu. Maybe others can comment.
>
> 2. 'if (int < unsigned int)' is still not nice, though in 'if
> (AVAILABLE(skb) < sizeof())'
> AVAILABLE(skb) seems always to return >= 0 after your patch.
Really if AVAILABLE(skb) was negative, a bug already happened.
WARNING: multiple messages have this Message-ID (diff)
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: syzbot
<bot+ed0838d0fa4c4f2b528e20286e6dc63effc7c14d@syzkaller.appspotmail.com>,
davem <davem@davemloft.net>, kuznet <kuznet@ms2.inr.ac.ru>,
LKML <linux-kernel@vger.kernel.org>,
linux-sctp@vger.kernel.org, network dev <netdev@vger.kernel.org>,
Neil Horman <nhorman@tuxdriver.com>,
syzkaller-bugs@googlegroups.com,
Vlad Yasevich <vyasevich@gmail.com>,
yoshfuji <yoshfuji@linux-ipv6.org>
Subject: Re: kernel BUG at net/core/skbuff.c:LINE! (2)
Date: Sat, 09 Dec 2017 20:51:10 -0800 [thread overview]
Message-ID: <1512881470.25033.38.camel@gmail.com> (raw)
In-Reply-To: <CADvbK_dMfCf82LYZWeWp1EOzStwuTyjP7SzbUwa0vnT5sc38Qw@mail.gmail.com>
On Sun, 2017-12-10 at 12:36 +0800, Xin Long wrote:
> The new patch works to me, just two questions:
> 1. should it use "idev->cnf.mtu6" here for mld ?
No idea why some parts of IPv6 would use a different view of device
mtu. Maybe others can comment.
>
> 2. 'if (int < unsigned int)' is still not nice, though in 'if
> (AVAILABLE(skb) < sizeof())'
> AVAILABLE(skb) seems always to return >= 0 after your patch.
Really if AVAILABLE(skb) was negative, a bug already happened.
next prev parent reply other threads:[~2017-12-10 4:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 14:36 kernel BUG at net/core/skbuff.c:LINE! (2) syzbot
2017-11-05 10:25 ` Xin Long
2017-11-05 10:25 ` Xin Long
2017-12-08 8:16 ` syzbot
2017-12-08 8:45 ` Xin Long
2017-12-08 8:45 ` Xin Long
2017-12-09 11:23 ` Xin Long
2017-12-09 11:23 ` Xin Long
2017-12-09 16:59 ` Eric Dumazet
2017-12-09 16:59 ` Eric Dumazet
2017-12-10 4:36 ` Xin Long
2017-12-10 4:36 ` Xin Long
2017-12-10 4:51 ` Eric Dumazet [this message]
2017-12-10 4:51 ` Eric Dumazet
2017-12-11 15:03 ` [PATCH net] ipv6: mcast: better catch silly mtu values Eric Dumazet
2017-12-12 12:55 ` Xin Long
2017-12-13 18:17 ` David Miller
2017-12-09 19:36 ` kernel BUG at net/core/skbuff.c:LINE! (2) Cong Wang
2017-12-09 19:36 ` Cong Wang
2017-12-10 4:38 ` Xin Long
2017-12-10 4:38 ` Xin Long
2017-12-10 5:12 ` Eric Dumazet
2017-12-10 5:12 ` Eric Dumazet
2018-01-15 20:22 ` syzbot
2018-01-16 8:21 ` Xin Long
2018-01-16 8:21 ` Xin Long
2018-01-19 17:19 ` Guillaume Nault
2018-01-19 17:19 ` Guillaume Nault
2018-01-19 18:02 ` Xin Long
2018-01-19 18:02 ` Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512881470.25033.38.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=bot+ed0838d0fa4c4f2b528e20286e6dc63effc7c14d@syzkaller.appspotmail.com \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=vyasevich@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.