[PATCH] x86/gpu: add CFL to early quirks

[PATCH] x86/gpu: add CFL to early quirks

[Lucas De Marchi]

CFL was missing from intel_early_ids[].

Cc: Ingo Molnar <mingo@kernel.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86@kernel.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---

Like it was done for other platforms, ideally we should get an ack from x86
maintainers and apply this through the drm-intel tree.

 arch/x86/kernel/early-quirks.c | 1 +
 include/drm/i915_pciids.h      | 6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
index 1e82f787c160..c87560e1e3ef 100644
--- a/arch/x86/kernel/early-quirks.c
+++ b/arch/x86/kernel/early-quirks.c
@@ -527,6 +527,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
 	INTEL_SKL_IDS(&gen9_early_ops),
 	INTEL_BXT_IDS(&gen9_early_ops),
 	INTEL_KBL_IDS(&gen9_early_ops),
+	INTEL_CFL_IDS(&gen9_early_ops),
 	INTEL_GLK_IDS(&gen9_early_ops),
 	INTEL_CNL_IDS(&gen9_early_ops),
 };
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index 972a25633525..c65e4489006d 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -392,6 +392,12 @@
 	INTEL_VGA_DEVICE(0x3EA8, info), /* ULT GT3 */ \
 	INTEL_VGA_DEVICE(0x3EA5, info)  /* ULT GT3 */
 
+#define INTEL_CFL_IDS(info) \
+	INTEL_CFL_S_GT1_IDS(info), \
+	INTEL_CFL_S_GT2_IDS(info), \
+	INTEL_CFL_H_GT2_IDS(info), \
+	INTEL_CFL_U_GT3_IDS(info)
+
 /* CNL U 2+2 */
 #define INTEL_CNL_U_GT2_IDS(info) \
 	INTEL_VGA_DEVICE(0x5A52, info), \
-- 
2.14.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: warning for x86/gpu: add CFL to early quirks

[Patchwork]

== Series Details ==

Series: x86/gpu: add CFL to early quirks
URL   : https://patchwork.freedesktop.org/series/35109/
State : warning

== Summary ==

Series 35109v1 x86/gpu: add CFL to early quirks
https://patchwork.freedesktop.org/api/1.0/series/35109/revisions/1/mbox/

Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                pass       -> FAIL       (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                dmesg-warn -> PASS       (fi-kbl-r) fdo#104172
        Subgroup suspend-read-crc-pipe-b:
                pass       -> DMESG-WARN (fi-kbl-r)

fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:441s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:449s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:384s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:517s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:282s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:504s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:514s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:484s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:473s
fi-elk-e7500     total:224  pass:163  dwarn:15  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:178  dwarn:1   dfail:0   fail:1   skip:108 time:264s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:544s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:385s
fi-hsw-4770r     total:288  pass:224  dwarn:0   dfail:0   fail:0   skip:64  time:261s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:400s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:476s
fi-ivb-3770      total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:447s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:489s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:529s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:477s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:529s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:598s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:447s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:543s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:566s
fi-skl-6700k     total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:529s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:499s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:450s
fi-snb-2520m     total:245  pass:211  dwarn:0   dfail:0   fail:0   skip:33 
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:425s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:615s
fi-cnl-y         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:639s
fi-glk-dsi       total:288  pass:257  dwarn:0   dfail:0   fail:1   skip:30  time:492s

3e49efc6d2d781a985e3eca14876df156899ef9b drm-tip: 2017y-12m-08d-18h-21m-46s UTC integration manifest
4031a979fcaa x86/gpu: add CFL to early quirks

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7454/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] x86/gpu: add CFL to early quirks

[Rodrigo Vivi]

On Fri, Dec 08, 2017 at 06:47:52PM +0000, Lucas De Marchi wrote:
> CFL was missing from intel_early_ids[].
> 
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: x86@kernel.org
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
> 
> Like it was done for other platforms, ideally we should get an ack from x86
> maintainers and apply this through the drm-intel tree.
> 
>  arch/x86/kernel/early-quirks.c | 1 +
>  include/drm/i915_pciids.h      | 6 ++++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 1e82f787c160..c87560e1e3ef 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -527,6 +527,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>  	INTEL_SKL_IDS(&gen9_early_ops),
>  	INTEL_BXT_IDS(&gen9_early_ops),
>  	INTEL_KBL_IDS(&gen9_early_ops),
> +	INTEL_CFL_IDS(&gen9_early_ops),
>  	INTEL_GLK_IDS(&gen9_early_ops),
>  	INTEL_CNL_IDS(&gen9_early_ops),
>  };
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 972a25633525..c65e4489006d 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -392,6 +392,12 @@
>  	INTEL_VGA_DEVICE(0x3EA8, info), /* ULT GT3 */ \
>  	INTEL_VGA_DEVICE(0x3EA5, info)  /* ULT GT3 */
>  
> +#define INTEL_CFL_IDS(info) \
> +	INTEL_CFL_S_GT1_IDS(info), \
> +	INTEL_CFL_S_GT2_IDS(info), \
> +	INTEL_CFL_H_GT2_IDS(info), \
> +	INTEL_CFL_U_GT3_IDS(info)
> +
>  /* CNL U 2+2 */
>  #define INTEL_CNL_U_GT2_IDS(info) \
>  	INTEL_VGA_DEVICE(0x5A52, info), \
> -- 
> 2.14.3
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] x86/gpu: add CFL to early quirks

[Joonas Lahtinen]

On Fri, 2017-12-08 at 10:47 -0800, Lucas De Marchi wrote:
> CFL was missing from intel_early_ids[].
> 
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: x86@kernel.org
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

This should come with a Fixes: line to be picked up to -fixes. The IDs
have been added in smaller chunks and reworked after, so backporting
will be required. For this level of fix, my recommendation would be to
actively provide a cleanly applying backports to affected stable
versions.

Counting from the first CFL PCI addition, this should have following
tags (adding them to this mail);

Fixes: b056f8f3d6b9 ("drm/i915/cfl: Add Coffee Lake PCI IDs for S Skus.")
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: David Airlie <airlied@linux.ie>
Cc: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v4.13+

Please improve the commit message to describe why the code is critical
to be there and what is the impact on systems without the code. (Should
be something about RAM being arbitarily overwritten if you keep using
UEFI framebuffer for example, depending on how BIOS has set up the e820
map.)

Regards, Joonas

> ---
> 
> Like it was done for other platforms, ideally we should get an ack from x86
> maintainers and apply this through the drm-intel tree.
> 
>  arch/x86/kernel/early-quirks.c | 1 +
>  include/drm/i915_pciids.h      | 6 ++++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 1e82f787c160..c87560e1e3ef 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -527,6 +527,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>  	INTEL_SKL_IDS(&gen9_early_ops),
>  	INTEL_BXT_IDS(&gen9_early_ops),
>  	INTEL_KBL_IDS(&gen9_early_ops),
> +	INTEL_CFL_IDS(&gen9_early_ops),
>  	INTEL_GLK_IDS(&gen9_early_ops),
>  	INTEL_CNL_IDS(&gen9_early_ops),
>  };
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 972a25633525..c65e4489006d 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -392,6 +392,12 @@
>  	INTEL_VGA_DEVICE(0x3EA8, info), /* ULT GT3 */ \
>  	INTEL_VGA_DEVICE(0x3EA5, info)  /* ULT GT3 */
>  
> +#define INTEL_CFL_IDS(info) \
> +	INTEL_CFL_S_GT1_IDS(info), \
> +	INTEL_CFL_S_GT2_IDS(info), \
> +	INTEL_CFL_H_GT2_IDS(info), \
> +	INTEL_CFL_U_GT3_IDS(info)
> +
>  /* CNL U 2+2 */
>  #define INTEL_CNL_U_GT2_IDS(info) \
>  	INTEL_VGA_DEVICE(0x5A52, info), \
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] x86/gpu: add CFL to early quirks

[Lucas De Marchi]

On Mon, Dec 11, 2017 at 2:26 AM, Joonas Lahtinen
<joonas.lahtinen@linux.intel.com> wrote:
> On Fri, 2017-12-08 at 10:47 -0800, Lucas De Marchi wrote:
>> CFL was missing from intel_early_ids[].
>>
>> Cc: Ingo Molnar <mingo@kernel.org>
>> Cc: H. Peter Anvin <hpa@zytor.com>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: x86@kernel.org
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> This should come with a Fixes: line to be picked up to -fixes. The IDs

I thought this didn't deserve CC to stable since alpha support was
removed for CFL only for 4.15.

> have been added in smaller chunks and reworked after, so backporting
> will be required. For this level of fix, my recommendation would be to
> actively provide a cleanly applying backports to affected stable
> versions.

Are you saying this should be proactive rather than reactive? I don't
see this mentioned on
Documentation/process/stable-kernel-rules.rst... the only thing I see
there regarding patches that don't apply
cleanly is that I may bring more patches through a tag for each version.

If we are indeed going to cc stable I can submit a v2 with added tags.
If a patch that can be cc'ed to stable
needs to be provided we may need to improve our docs, too.

>
> Counting from the first CFL PCI addition, this should have following
> tags (adding them to this mail);
>
> Fixes: b056f8f3d6b9 ("drm/i915/cfl: Add Coffee Lake PCI IDs for S Skus.")
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v4.13+
>
> Please improve the commit message to describe why the code is critical
> to be there and what is the impact on systems without the code. (Should
> be something about RAM being arbitarily overwritten if you keep using
> UEFI framebuffer for example, depending on how BIOS has set up the e820
> map.)

Noted.

thanks
Lucas De Marchi


>
> Regards, Joonas
>
>> ---
>>
>> Like it was done for other platforms, ideally we should get an ack from x86
>> maintainers and apply this through the drm-intel tree.
>>
>>  arch/x86/kernel/early-quirks.c | 1 +
>>  include/drm/i915_pciids.h      | 6 ++++++
>>  2 files changed, 7 insertions(+)
>>
>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
>> index 1e82f787c160..c87560e1e3ef 100644
>> --- a/arch/x86/kernel/early-quirks.c
>> +++ b/arch/x86/kernel/early-quirks.c
>> @@ -527,6 +527,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>>       INTEL_SKL_IDS(&gen9_early_ops),
>>       INTEL_BXT_IDS(&gen9_early_ops),
>>       INTEL_KBL_IDS(&gen9_early_ops),
>> +     INTEL_CFL_IDS(&gen9_early_ops),
>>       INTEL_GLK_IDS(&gen9_early_ops),
>>       INTEL_CNL_IDS(&gen9_early_ops),
>>  };
>> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
>> index 972a25633525..c65e4489006d 100644
>> --- a/include/drm/i915_pciids.h
>> +++ b/include/drm/i915_pciids.h
>> @@ -392,6 +392,12 @@
>>       INTEL_VGA_DEVICE(0x3EA8, info), /* ULT GT3 */ \
>>       INTEL_VGA_DEVICE(0x3EA5, info)  /* ULT GT3 */
>>
>> +#define INTEL_CFL_IDS(info) \
>> +     INTEL_CFL_S_GT1_IDS(info), \
>> +     INTEL_CFL_S_GT2_IDS(info), \
>> +     INTEL_CFL_H_GT2_IDS(info), \
>> +     INTEL_CFL_U_GT3_IDS(info)
>> +
>>  /* CNL U 2+2 */
>>  #define INTEL_CNL_U_GT2_IDS(info) \
>>       INTEL_VGA_DEVICE(0x5A52, info), \
> --
> Joonas Lahtinen
> Open Source Technology Center
> Intel Corporation
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] x86/gpu: add CFL to early quirks

[Joonas Lahtinen]

+ Jani, who'll continue with -fixes

On Mon, 2017-12-11 at 13:50 -0800, Lucas De Marchi wrote:
> On Mon, Dec 11, 2017 at 2:26 AM, Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com> wrote:
> > On Fri, 2017-12-08 at 10:47 -0800, Lucas De Marchi wrote:
> > > CFL was missing from intel_early_ids[].
> > > 
> > > Cc: Ingo Molnar <mingo@kernel.org>
> > > Cc: H. Peter Anvin <hpa@zytor.com>
> > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > Cc: x86@kernel.org
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> > 
> > This should come with a Fixes: line to be picked up to -fixes. The IDs
> 
> I thought this didn't deserve CC to stable since alpha support was
> removed for CFL only for 4.15.

I don't think system memory corruption is really acceptable even for
alpha quality support :P

> > have been added in smaller chunks and reworked after, so backporting
> > will be required. For this level of fix, my recommendation would be to
> > actively provide a cleanly applying backports to affected stable
> > versions.
> 
> Are you saying this should be proactive rather than reactive? I don't
> see this mentioned on
> Documentation/process/stable-kernel-rules.rst... the only thing I see
> there regarding patches that don't apply
> cleanly is that I may bring more patches through a tag for each version.
> 
> If we are indeed going to cc stable I can submit a v2 with added tags.
> If a patch that can be cc'ed to stable
> needs to be provided we may need to improve our docs, too.

That's correct. But once Cc:d stable, we can see from the GIT history
that it'll bounce back because it won't apply. For this specific case
that might cause system memory corruption, I'd make an exception and be
proactive.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] x86/gpu: add CFL to early quirks

[Lucas De Marchi]

On Tue, Dec 12, 2017 at 1:53 AM, Joonas Lahtinen
<joonas.lahtinen@linux.intel.com> wrote:
> + Jani, who'll continue with -fixes
>
> On Mon, 2017-12-11 at 13:50 -0800, Lucas De Marchi wrote:
>> On Mon, Dec 11, 2017 at 2:26 AM, Joonas Lahtinen
>> <joonas.lahtinen@linux.intel.com> wrote:
>> > On Fri, 2017-12-08 at 10:47 -0800, Lucas De Marchi wrote:
>> > > CFL was missing from intel_early_ids[].
>> > >
>> > > Cc: Ingo Molnar <mingo@kernel.org>
>> > > Cc: H. Peter Anvin <hpa@zytor.com>
>> > > Cc: Thomas Gleixner <tglx@linutronix.de>
>> > > Cc: x86@kernel.org
>> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> > > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> >
>> > This should come with a Fixes: line to be picked up to -fixes. The IDs
>>
>> I thought this didn't deserve CC to stable since alpha support was
>> removed for CFL only for 4.15.
>
> I don't think system memory corruption is really acceptable even for
> alpha quality support :P
>
>> > have been added in smaller chunks and reworked after, so backporting
>> > will be required. For this level of fix, my recommendation would be to
>> > actively provide a cleanly applying backports to affected stable
>> > versions.
>>
>> Are you saying this should be proactive rather than reactive? I don't
>> see this mentioned on
>> Documentation/process/stable-kernel-rules.rst... the only thing I see
>> there regarding patches that don't apply
>> cleanly is that I may bring more patches through a tag for each version.
>>
>> If we are indeed going to cc stable I can submit a v2 with added tags.
>> If a patch that can be cc'ed to stable
>> needs to be provided we may need to improve our docs, too.
>
> That's correct. But once Cc:d stable, we can see from the GIT history
> that it'll bounce back because it won't apply. For this specific case
> that might cause system memory corruption, I'd make an exception and be
> proactive.

Another option would be to cherry-pick
0890540e21cf1156b4cf960a4c1c734db4e816f9 and
41693fd5237397d3c61b311af0fda1f6f39297c2 so then all commits apply cleanly.


Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] x86/gpu: add CFL to early quirks

[Jani Nikula]

On Tue, 12 Dec 2017, Lucas De Marchi <lucas.de.marchi@gmail.com> wrote:
> On Tue, Dec 12, 2017 at 1:53 AM, Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com> wrote:
>> + Jani, who'll continue with -fixes
>>
>> On Mon, 2017-12-11 at 13:50 -0800, Lucas De Marchi wrote:
>>> On Mon, Dec 11, 2017 at 2:26 AM, Joonas Lahtinen
>>> <joonas.lahtinen@linux.intel.com> wrote:
>>> > On Fri, 2017-12-08 at 10:47 -0800, Lucas De Marchi wrote:
>>> > > CFL was missing from intel_early_ids[].
>>> > >
>>> > > Cc: Ingo Molnar <mingo@kernel.org>
>>> > > Cc: H. Peter Anvin <hpa@zytor.com>
>>> > > Cc: Thomas Gleixner <tglx@linutronix.de>
>>> > > Cc: x86@kernel.org
>>> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>> > > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>>> >
>>> > This should come with a Fixes: line to be picked up to -fixes. The IDs
>>>
>>> I thought this didn't deserve CC to stable since alpha support was
>>> removed for CFL only for 4.15.
>>
>> I don't think system memory corruption is really acceptable even for
>> alpha quality support :P
>>
>>> > have been added in smaller chunks and reworked after, so backporting
>>> > will be required. For this level of fix, my recommendation would be to
>>> > actively provide a cleanly applying backports to affected stable
>>> > versions.
>>>
>>> Are you saying this should be proactive rather than reactive? I don't
>>> see this mentioned on
>>> Documentation/process/stable-kernel-rules.rst... the only thing I see
>>> there regarding patches that don't apply
>>> cleanly is that I may bring more patches through a tag for each version.
>>>
>>> If we are indeed going to cc stable I can submit a v2 with added tags.
>>> If a patch that can be cc'ed to stable
>>> needs to be provided we may need to improve our docs, too.
>>
>> That's correct. But once Cc:d stable, we can see from the GIT history
>> that it'll bounce back because it won't apply. For this specific case
>> that might cause system memory corruption, I'd make an exception and be
>> proactive.
>
> Another option would be to cherry-pick
> 0890540e21cf1156b4cf960a4c1c734db4e816f9 and
> 41693fd5237397d3c61b311af0fda1f6f39297c2 so then all commits apply cleanly.

There's a cc: stable annotation for dependencies like that, see stable
kernel rules. I think Greg has stated a preference for picking up
dependencies rather than having manually backported patches.

BR,
Jani.



-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] x86/gpu: add CFL to early quirks

[Lucas De Marchi]

On Wed, Dec 13, 2017 at 2:11 AM, Jani Nikula
<jani.nikula@linux.intel.com> wrote:
> On Tue, 12 Dec 2017, Lucas De Marchi <lucas.de.marchi@gmail.com> wrote:
>> On Tue, Dec 12, 2017 at 1:53 AM, Joonas Lahtinen
>> <joonas.lahtinen@linux.intel.com> wrote:
>>> + Jani, who'll continue with -fixes
>>>
>>> On Mon, 2017-12-11 at 13:50 -0800, Lucas De Marchi wrote:
>>>> On Mon, Dec 11, 2017 at 2:26 AM, Joonas Lahtinen
>>>> <joonas.lahtinen@linux.intel.com> wrote:
>>>> > On Fri, 2017-12-08 at 10:47 -0800, Lucas De Marchi wrote:
>>>> > > CFL was missing from intel_early_ids[].
>>>> > >
>>>> > > Cc: Ingo Molnar <mingo@kernel.org>
>>>> > > Cc: H. Peter Anvin <hpa@zytor.com>
>>>> > > Cc: Thomas Gleixner <tglx@linutronix.de>
>>>> > > Cc: x86@kernel.org
>>>> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>>> > > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>>>> >
>>>> > This should come with a Fixes: line to be picked up to -fixes. The IDs
>>>>
>>>> I thought this didn't deserve CC to stable since alpha support was
>>>> removed for CFL only for 4.15.
>>>
>>> I don't think system memory corruption is really acceptable even for
>>> alpha quality support :P
>>>
>>>> > have been added in smaller chunks and reworked after, so backporting
>>>> > will be required. For this level of fix, my recommendation would be to
>>>> > actively provide a cleanly applying backports to affected stable
>>>> > versions.
>>>>
>>>> Are you saying this should be proactive rather than reactive? I don't
>>>> see this mentioned on
>>>> Documentation/process/stable-kernel-rules.rst... the only thing I see
>>>> there regarding patches that don't apply
>>>> cleanly is that I may bring more patches through a tag for each version.
>>>>
>>>> If we are indeed going to cc stable I can submit a v2 with added tags.
>>>> If a patch that can be cc'ed to stable
>>>> needs to be provided we may need to improve our docs, too.
>>>
>>> That's correct. But once Cc:d stable, we can see from the GIT history
>>> that it'll bounce back because it won't apply. For this specific case
>>> that might cause system memory corruption, I'd make an exception and be
>>> proactive.
>>
>> Another option would be to cherry-pick
>> 0890540e21cf1156b4cf960a4c1c734db4e816f9 and
>> 41693fd5237397d3c61b311af0fda1f6f39297c2 so then all commits apply cleanly.
>
> There's a cc: stable annotation for dependencies like that, see stable

Yep, that's why I suggested the alternative. I think bring those
commits to stable will be
better because they will always cause conflicts on future backports.
If we have them applied
it will make future backports to apply cleanly rather than needing to
diverge more from
master.

> kernel rules. I think Greg has stated a preference for picking up
> dependencies rather than having manually backported patches.

Great. I will follow that approach for v2.

thanks
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] x86/gpu: add CFL to early quirks

[Joonas Lahtinen]

On Tue, 2017-12-12 at 16:17 -0800, Lucas De Marchi wrote:
> On Tue, Dec 12, 2017 at 1:53 AM, Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com> wrote:
> > + Jani, who'll continue with -fixes
> > 
> > On Mon, 2017-12-11 at 13:50 -0800, Lucas De Marchi wrote:
> > > On Mon, Dec 11, 2017 at 2:26 AM, Joonas Lahtinen
> > > <joonas.lahtinen@linux.intel.com> wrote:
> > > > On Fri, 2017-12-08 at 10:47 -0800, Lucas De Marchi wrote:
> > > > > CFL was missing from intel_early_ids[].
> > > > > 
> > > > > Cc: Ingo Molnar <mingo@kernel.org>
> > > > > Cc: H. Peter Anvin <hpa@zytor.com>
> > > > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > > > Cc: x86@kernel.org
> > > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> > > > 
> > > > This should come with a Fixes: line to be picked up to -fixes. The IDs
> > > 
> > > I thought this didn't deserve CC to stable since alpha support was
> > > removed for CFL only for 4.15.
> > 
> > I don't think system memory corruption is really acceptable even for
> > alpha quality support :P
> > 
> > > > have been added in smaller chunks and reworked after, so backporting
> > > > will be required. For this level of fix, my recommendation would be to
> > > > actively provide a cleanly applying backports to affected stable
> > > > versions.
> > > 
> > > Are you saying this should be proactive rather than reactive? I don't
> > > see this mentioned on
> > > Documentation/process/stable-kernel-rules.rst... the only thing I see
> > > there regarding patches that don't apply
> > > cleanly is that I may bring more patches through a tag for each version.
> > > 
> > > If we are indeed going to cc stable I can submit a v2 with added tags.
> > > If a patch that can be cc'ed to stable
> > > needs to be provided we may need to improve our docs, too.
> > 
> > That's correct. But once Cc:d stable, we can see from the GIT history
> > that it'll bounce back because it won't apply. For this specific case
> > that might cause system memory corruption, I'd make an exception and be
> > proactive.
> 
> Another option would be to cherry-pick
> 0890540e21cf1156b4cf960a4c1c734db4e816f9 and
> 41693fd5237397d3c61b311af0fda1f6f39297c2 so then all commits apply cleanly.

The stable patches should be as minimal as possible to avoid conflicts.
The first one has some potential for extra clashes, but whatever is
guesstimated to cause least conflicts, should be sent.

The tooling automatically picks up Fixes:, which those commits don't
have so it probably needs to be noted when sending the patch that
related commits need to be picked up.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] x86/gpu: add CFL to early quirks

[Jani Nikula]

On Mon, 11 Dec 2017, Lucas De Marchi <lucas.de.marchi@gmail.com> wrote:
> On Mon, Dec 11, 2017 at 2:26 AM, Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com> wrote:
>> On Fri, 2017-12-08 at 10:47 -0800, Lucas De Marchi wrote:
>>> CFL was missing from intel_early_ids[].
>>>
>>> Cc: Ingo Molnar <mingo@kernel.org>
>>> Cc: H. Peter Anvin <hpa@zytor.com>
>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>> Cc: x86@kernel.org
>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>>
>> This should come with a Fixes: line to be picked up to -fixes. The IDs
>
> I thought this didn't deserve CC to stable since alpha support was
> removed for CFL only for 4.15.

We'll need Fixes: no matter what to tell our scripts to pick this up for
v4.15 even. Otherwise this might slip to the queue targeting v4.16!

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx