* [PATCH igt] igt/kms_flip: Allow very large bo to fail pageflips with E2BIG
@ 2017-12-11 17:22 Chris Wilson
2017-12-11 18:35 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-12-12 10:02 ` [PATCH igt] " Joonas Lahtinen
0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2017-12-11 17:22 UTC (permalink / raw)
To: intel-gfx
We tried to allow very large buffers (larger than the mappable aperture)
to be flippable by allowing them to be bound into the unmappable region.
Sadly, not our hw is capable of utilising the unmappable region for
scanout (and on some older hw, there is only mappable). As such, we have
to allow the very large bo to either succeed in being flipped, or fail
with the expected E2BIG.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/kms_flip.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 63c58d2e1..fb4fe6514 100644
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1344,7 +1344,14 @@ static void run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
if (o->flags & TEST_CHECK_TS)
calibrate_ts(o, crtc_idxs[0]);
- igt_assert_eq(do_page_flip(o, o->fb_ids[1], true), 0);
+ if (o->flags & TEST_BO_TOOBIG) {
+ int err = do_page_flip(o, o->fb_ids[1], true);
+ igt_assert(err == 0 || err == -E2BIG);
+ if (err)
+ goto out;
+ } else {
+ igt_assert_eq(do_page_flip(o, o->fb_ids[1], true), 0);
+ }
wait_for_events(o);
o->current_fb_id = 1;
--
2.15.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✗ Fi.CI.BAT: failure for igt/kms_flip: Allow very large bo to fail pageflips with E2BIG
2017-12-11 17:22 [PATCH igt] igt/kms_flip: Allow very large bo to fail pageflips with E2BIG Chris Wilson
@ 2017-12-11 18:35 ` Patchwork
2017-12-12 10:02 ` [PATCH igt] " Joonas Lahtinen
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2017-12-11 18:35 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: igt/kms_flip: Allow very large bo to fail pageflips with E2BIG
URL : https://patchwork.freedesktop.org/series/35186/
State : failure
== Summary ==
IGT patchset tested on top of latest successful build
4d40a6776f08dd87b7e007da691b73d45a9bf1fa igt_fb: Add support for drawing to non-32bit Y/Yf tiled FBs
with latest DRM-Tip kernel build CI_DRM_3499
39419b521a0f drm-tip: 2017y-12m-11d-17h-25m-05s UTC integration manifest
No testlist changes.
Test debugfs_test:
Subgroup read_all_entries:
dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989
Test gem_exec_suspend:
Subgroup basic-s3:
pass -> INCOMPLETE (fi-kbl-r)
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:437s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:446s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:381s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:519s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:280s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:512s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:510s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:488s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:473s
fi-elk-e7500 total:224 pass:163 dwarn:14 dfail:1 fail:0 skip:45
fi-gdg-551 total:288 pass:178 dwarn:1 dfail:0 fail:1 skip:108 time:270s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:543s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:372s
fi-hsw-4770r total:288 pass:224 dwarn:0 dfail:0 fail:0 skip:64 time:261s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:396s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:481s
fi-ivb-3770 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:447s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:490s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:526s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:477s
fi-kbl-r total:108 pass:96 dwarn:0 dfail:0 fail:0 skip:11
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:587s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:451s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:551s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:569s
fi-skl-6700k total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:520s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:496s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:452s
fi-snb-2520m total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:551s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:418s
Blacklisted hosts:
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:602s
fi-cnl-y total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:627s
fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:497s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_648/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH igt] igt/kms_flip: Allow very large bo to fail pageflips with E2BIG
2017-12-11 17:22 [PATCH igt] igt/kms_flip: Allow very large bo to fail pageflips with E2BIG Chris Wilson
2017-12-11 18:35 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-12-12 10:02 ` Joonas Lahtinen
1 sibling, 0 replies; 3+ messages in thread
From: Joonas Lahtinen @ 2017-12-12 10:02 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On Mon, 2017-12-11 at 17:22 +0000, Chris Wilson wrote:
> We tried to allow very large buffers (larger than the mappable aperture)
> to be flippable by allowing them to be bound into the unmappable region.
> Sadly, not our hw is capable of utilising the unmappable region for
> scanout (and on some older hw, there is only mappable). As such, we have
> to allow the very large bo to either succeed in being flipped, or fail
> with the expected E2BIG.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-12 10:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-11 17:22 [PATCH igt] igt/kms_flip: Allow very large bo to fail pageflips with E2BIG Chris Wilson
2017-12-11 18:35 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-12-12 10:02 ` [PATCH igt] " Joonas Lahtinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.