From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Matthew Auld <matthew.auld@intel.com>
Subject: Re: [PATCH v2] drm/i915: Downgrade misleading "Memory usable" message
Date: Tue, 12 Dec 2017 15:10:58 +0200 [thread overview]
Message-ID: <1513084258.3809.11.camel@linux.intel.com> (raw)
In-Reply-To: <20171212113532.22574-1-chris@chris-wilson.co.uk>
On Tue, 2017-12-12 at 11:35 +0000, Chris Wilson wrote:
> It never meant what it said, as it was always the total size of the
> Global GTT and not a limit upon memory usage. Originally it served as a
> quick guide to the largest batch that could be submitted by userspace,
> an approximation to its maximum RSS, but was phrased badly. Today with
> the 48b ppgtt, it is even more meaningless. Replace with a more specific
> debug message; those wanting to know how much "video ram" they have
> should consult the userspace libraries for the relevant approximation.
>
> v2: Rebase
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Matthew Auld <matthew.auld@intel.com>
Yes, a much preferred improvement.
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-12-12 13:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 21:24 [PATCH] drm/i915: Downgrade misleading "Memory usable" message Chris Wilson
2017-10-27 22:09 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-12-12 11:35 ` [PATCH v2] " Chris Wilson
2017-12-12 12:16 ` Matthew Auld
2017-12-12 12:26 ` Chris Wilson
2017-12-12 13:10 ` Joonas Lahtinen [this message]
2017-12-12 12:41 ` ✗ Fi.CI.BAT: failure for drm/i915: Downgrade misleading "Memory usable" message (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513084258.3809.11.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.