* [PATCH] drm/i915: Downgrade misleading "Memory usable" message
@ 2017-10-27 21:24 Chris Wilson
2017-10-27 22:09 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Chris Wilson @ 2017-10-27 21:24 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter
It never meant what it said, as it was always the total size of the
Global GTT and not a limit upon memory usage. Originally it served as a
quick guide to the largest batch that could be submitted by userspace,
an approximation to its maximum RSS, but was phrased badly. Today with
the 48b ppgtt, it is even more meaningless. Replace with a more specific
debug message; those wanting to know how much "video ram" they have
should consult the userspace libraries for the relevant approximation.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 5eaa6893daaa..74676b1540d4 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -3502,10 +3502,9 @@ int i915_ggtt_probe_hw(struct drm_i915_private *dev_priv)
}
/* GMADR is the PCI mmio aperture into the global GTT. */
- DRM_INFO("Memory usable by graphics device = %lluM\n",
- ggtt->base.total >> 20);
+ DRM_DEBUG_DRIVER("GGTT size = %lluM\n", ggtt->base.total >> 20);
DRM_DEBUG_DRIVER("GMADR size = %lldM\n", ggtt->mappable_end >> 20);
- DRM_DEBUG_DRIVER("GTT stolen size = %uM\n", ggtt->stolen_size >> 20);
+ DRM_DEBUG_DRIVER("Stolen size = %uM\n", ggtt->stolen_size >> 20);
if (intel_vtd_active())
DRM_INFO("VT-d active for gfx access\n");
--
2.15.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Downgrade misleading "Memory usable" message
2017-10-27 21:24 [PATCH] drm/i915: Downgrade misleading "Memory usable" message Chris Wilson
@ 2017-10-27 22:09 ` Patchwork
2017-12-12 11:35 ` [PATCH v2] " Chris Wilson
2017-12-12 12:41 ` ✗ Fi.CI.BAT: failure for drm/i915: Downgrade misleading "Memory usable" message (rev2) Patchwork
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2017-10-27 22:09 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Downgrade misleading "Memory usable" message
URL : https://patchwork.freedesktop.org/series/32790/
State : failure
== Summary ==
Series 32790v1 drm/i915: Downgrade misleading "Memory usable" message
https://patchwork.freedesktop.org/api/1.0/series/32790/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-wb:
pass -> FAIL (fi-glk-dsi)
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-a-frame-sequence:
pass -> INCOMPLETE (fi-glk-1)
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:442s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:447s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:373s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:528s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:264s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:499s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:498s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:496s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:483s
fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:598s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:419s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:250s
fi-glk-1 total:234 pass:207 dwarn:0 dfail:0 fail:0 skip:26
fi-glk-dsi total:289 pass:257 dwarn:0 dfail:0 fail:2 skip:30 time:482s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:423s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:426s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:420s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:493s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:459s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:490s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:566s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:478s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:573s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:544s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:454s
fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:590s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:645s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:519s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:497s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:457s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:558s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:413s
d0582552491e17f5e386747f82147c1f2d9158c9 drm-tip: 2017y-10m-27d-19h-16m-21s UTC integration manifest
05a887a605ba drm/i915: Downgrade misleading "Memory usable" message
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6252/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] drm/i915: Downgrade misleading "Memory usable" message
2017-10-27 21:24 [PATCH] drm/i915: Downgrade misleading "Memory usable" message Chris Wilson
2017-10-27 22:09 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-12-12 11:35 ` Chris Wilson
2017-12-12 12:16 ` Matthew Auld
2017-12-12 13:10 ` Joonas Lahtinen
2017-12-12 12:41 ` ✗ Fi.CI.BAT: failure for drm/i915: Downgrade misleading "Memory usable" message (rev2) Patchwork
2 siblings, 2 replies; 7+ messages in thread
From: Chris Wilson @ 2017-12-12 11:35 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter, Matthew Auld
It never meant what it said, as it was always the total size of the
Global GTT and not a limit upon memory usage. Originally it served as a
quick guide to the largest batch that could be submitted by userspace,
an approximation to its maximum RSS, but was phrased badly. Today with
the 48b ppgtt, it is even more meaningless. Replace with a more specific
debug message; those wanting to know how much "video ram" they have
should consult the userspace libraries for the relevant approximation.
v2: Rebase
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 35b4317f1a7a..cd08f50eaa0a 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -3483,10 +3483,9 @@ int i915_ggtt_probe_hw(struct drm_i915_private *dev_priv)
}
/* GMADR is the PCI mmio aperture into the global GTT. */
- DRM_INFO("Memory usable by graphics device = %lluM\n",
- ggtt->base.total >> 20);
+ DRM_DEBUG_DRIVER("GGTT size = %lluM\n", ggtt->base.total >> 20);
DRM_DEBUG_DRIVER("GMADR size = %lluM\n", (u64)ggtt->mappable_end >> 20);
- DRM_DEBUG_DRIVER("GTT stolen size = %lluM\n",
+ DRM_DEBUG_DRIVER("DSM size = %lluM\n",
(u64)resource_size(&intel_graphics_stolen_res) >> 20);
if (intel_vtd_active())
DRM_INFO("VT-d active for gfx access\n");
--
2.15.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/i915: Downgrade misleading "Memory usable" message
2017-12-12 11:35 ` [PATCH v2] " Chris Wilson
@ 2017-12-12 12:16 ` Matthew Auld
2017-12-12 12:26 ` Chris Wilson
2017-12-12 13:10 ` Joonas Lahtinen
1 sibling, 1 reply; 7+ messages in thread
From: Matthew Auld @ 2017-12-12 12:16 UTC (permalink / raw)
To: Chris Wilson; +Cc: Daniel Vetter, Intel Graphics Development, Matthew Auld
On 12 December 2017 at 11:35, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> It never meant what it said, as it was always the total size of the
> Global GTT and not a limit upon memory usage. Originally it served as a
> quick guide to the largest batch that could be submitted by userspace,
> an approximation to its maximum RSS, but was phrased badly. Today with
> the 48b ppgtt, it is even more meaningless. Replace with a more specific
> debug message; those wanting to know how much "video ram" they have
> should consult the userspace libraries for the relevant approximation.
>
> v2: Rebase
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/i915: Downgrade misleading "Memory usable" message
2017-12-12 12:16 ` Matthew Auld
@ 2017-12-12 12:26 ` Chris Wilson
0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2017-12-12 12:26 UTC (permalink / raw)
To: Matthew Auld; +Cc: Daniel Vetter, Intel Graphics Development, Matthew Auld
Quoting Matthew Auld (2017-12-12 12:16:14)
> On 12 December 2017 at 11:35, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > It never meant what it said, as it was always the total size of the
> > Global GTT and not a limit upon memory usage. Originally it served as a
> > quick guide to the largest batch that could be submitted by userspace,
> > an approximation to its maximum RSS, but was phrased badly. Today with
> > the 48b ppgtt, it is even more meaningless. Replace with a more specific
> > debug message; those wanting to know how much "video ram" they have
> > should consult the userspace libraries for the relevant approximation.
> >
> > v2: Rebase
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Matthew Auld <matthew.auld@intel.com>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Ta, applied in anticipation that CI won't notice any difference.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Downgrade misleading "Memory usable" message (rev2)
2017-10-27 21:24 [PATCH] drm/i915: Downgrade misleading "Memory usable" message Chris Wilson
2017-10-27 22:09 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-12-12 11:35 ` [PATCH v2] " Chris Wilson
@ 2017-12-12 12:41 ` Patchwork
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2017-12-12 12:41 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Downgrade misleading "Memory usable" message (rev2)
URL : https://patchwork.freedesktop.org/series/32790/
State : failure
== Summary ==
Series 32790v2 drm/i915: Downgrade misleading "Memory usable" message
https://patchwork.freedesktop.org/api/1.0/series/32790/revisions/2/mbox/
Test gem_ctx_create:
Subgroup basic-files:
pass -> INCOMPLETE (fi-byt-j1900)
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
Test kms_frontbuffer_tracking:
Subgroup basic:
incomplete -> SKIP (fi-elk-e7500) fdo#103989 +1
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
pass -> DMESG-WARN (fi-kbl-r) fdo#104172 +1
Subgroup suspend-read-crc-pipe-b:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:436s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:443s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:383s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:512s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:279s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:503s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:509s
fi-byt-j1900 total:17 pass:16 dwarn:0 dfail:0 fail:0 skip:0
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:475s
fi-elk-e7500 total:229 pass:167 dwarn:15 dfail:0 fail:0 skip:46
fi-gdg-551 total:288 pass:178 dwarn:1 dfail:0 fail:1 skip:108 time:264s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:368s
fi-hsw-4770r total:288 pass:224 dwarn:0 dfail:0 fail:0 skip:64 time:257s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:393s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:480s
fi-ivb-3770 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:445s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:483s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:523s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:474s
fi-kbl-r total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:527s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:591s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:457s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:539s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:561s
fi-skl-6700k total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:515s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:497s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:446s
fi-snb-2520m total:245 pass:211 dwarn:0 dfail:0 fail:0 skip:33
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:410s
Blacklisted hosts:
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:592s
fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:489s
fi-glk-1 failed to collect. IGT log at Patchwork_7472/fi-glk-1/igt.log
12ecfba7559583eb311c862fc1b4766e0df5cfc8 drm-tip: 2017y-12m-12d-10h-48m-41s UTC integration manifest
88fb98c5b60b drm/i915: Downgrade misleading "Memory usable" message
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7472/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/i915: Downgrade misleading "Memory usable" message
2017-12-12 11:35 ` [PATCH v2] " Chris Wilson
2017-12-12 12:16 ` Matthew Auld
@ 2017-12-12 13:10 ` Joonas Lahtinen
1 sibling, 0 replies; 7+ messages in thread
From: Joonas Lahtinen @ 2017-12-12 13:10 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Daniel Vetter, Matthew Auld
On Tue, 2017-12-12 at 11:35 +0000, Chris Wilson wrote:
> It never meant what it said, as it was always the total size of the
> Global GTT and not a limit upon memory usage. Originally it served as a
> quick guide to the largest batch that could be submitted by userspace,
> an approximation to its maximum RSS, but was phrased badly. Today with
> the 48b ppgtt, it is even more meaningless. Replace with a more specific
> debug message; those wanting to know how much "video ram" they have
> should consult the userspace libraries for the relevant approximation.
>
> v2: Rebase
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Matthew Auld <matthew.auld@intel.com>
Yes, a much preferred improvement.
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-12-12 13:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-27 21:24 [PATCH] drm/i915: Downgrade misleading "Memory usable" message Chris Wilson
2017-10-27 22:09 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-12-12 11:35 ` [PATCH v2] " Chris Wilson
2017-12-12 12:16 ` Matthew Auld
2017-12-12 12:26 ` Chris Wilson
2017-12-12 13:10 ` Joonas Lahtinen
2017-12-12 12:41 ` ✗ Fi.CI.BAT: failure for drm/i915: Downgrade misleading "Memory usable" message (rev2) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.