From: smitha.t@samsung.com (Smitha T Murthy)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch v6 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder
Date: Wed, 13 Dec 2017 14:00:01 +0530 [thread overview]
Message-ID: <1513153801.22129.5.camel@smitha-fedora> (raw)
In-Reply-To: <10a80dd4-737d-2c96-1679-3b04cfc45a5d@samsung.com>
On Tue, 2017-12-12 at 10:46 +0100, Sylwester Nawrocki wrote:
> On 12/12/2017 03:34 AM, Smitha T Murthy wrote:
> >> s/Lay/Layer here and below
> >>
> > Ok I will change it.
>
> While it's fine to make such change for controls up to V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L6_QP...
>
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L1_QP: return "HEVC Hierarchical Lay 1 QP";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L2_QP: return "HEVC Hierarchical Lay 2 QP";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L3_QP: return "HEVC Hierarchical Lay 3 QP";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L4_QP: return "HEVC Hierarchical Lay 4 QP";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L5_QP: return "HEVC Hierarchical Lay 5 QP";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L6_QP: return "HEVC Hierarchical Lay 6 QP";
>
> ...for the controls below we may need to replace "Lay" with "L."
> to make sure the length of the string don't exceed 31 characters
> (32 with terminating NULL). The names below seem to be 1 character
> too long and will be truncated when running VIDIOC_QUERY_CTRL ioctl.
>
Yes true, also to keep the uniformity I will change for all
V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L1_QP and
V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L0_BR "Lay" with "L".
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L0_BR: return "HEVC Hierarchical Lay 0 Bit Rate";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L1_BR: return "HEVC Hierarchical Lay 1 Bit Rate";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L2_BR: return "HEVC Hierarchical Lay 2 Bit Rate";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L3_BR: return "HEVC Hierarchical Lay 3 Bit Rate";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L4_BR: return "HEVC Hierarchical Lay 4 Bit Rate";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L5_BR: return "HEVC Hierarchical Lay 5 Bit Rate";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L6_BR: return "HEVC Hierarchical Lay 6 Bit Rate";
>
> --
> Regards,
> Sylwester
>
Thank you for the review.
Regards,
Smitha
WARNING: multiple messages have this Message-ID (diff)
From: Smitha T Murthy <smitha.t@samsung.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com,
a.hajda@samsung.com, mchehab@kernel.org,
pankaj.dubey@samsung.com, krzk@kernel.org,
m.szyprowski@samsung.com
Subject: Re: [Patch v6 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder
Date: Wed, 13 Dec 2017 14:00:01 +0530 [thread overview]
Message-ID: <1513153801.22129.5.camel@smitha-fedora> (raw)
In-Reply-To: <10a80dd4-737d-2c96-1679-3b04cfc45a5d@samsung.com>
On Tue, 2017-12-12 at 10:46 +0100, Sylwester Nawrocki wrote:
> On 12/12/2017 03:34 AM, Smitha T Murthy wrote:
> >> s/Lay/Layer here and below
> >>
> > Ok I will change it.
>
> While it's fine to make such change for controls up to V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L6_QP...
>
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L1_QP: return "HEVC Hierarchical Lay 1 QP";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L2_QP: return "HEVC Hierarchical Lay 2 QP";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L3_QP: return "HEVC Hierarchical Lay 3 QP";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L4_QP: return "HEVC Hierarchical Lay 4 QP";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L5_QP: return "HEVC Hierarchical Lay 5 QP";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L6_QP: return "HEVC Hierarchical Lay 6 QP";
>
> ...for the controls below we may need to replace "Lay" with "L."
> to make sure the length of the string don't exceed 31 characters
> (32 with terminating NULL). The names below seem to be 1 character
> too long and will be truncated when running VIDIOC_QUERY_CTRL ioctl.
>
Yes true, also to keep the uniformity I will change for all
V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L1_QP and
V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L0_BR "Lay" with "L".
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L0_BR: return "HEVC Hierarchical Lay 0 Bit Rate";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L1_BR: return "HEVC Hierarchical Lay 1 Bit Rate";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L2_BR: return "HEVC Hierarchical Lay 2 Bit Rate";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L3_BR: return "HEVC Hierarchical Lay 3 Bit Rate";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L4_BR: return "HEVC Hierarchical Lay 4 Bit Rate";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L5_BR: return "HEVC Hierarchical Lay 5 Bit Rate";
> >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L6_BR: return "HEVC Hierarchical Lay 6 Bit Rate";
>
> --
> Regards,
> Sylwester
>
Thank you for the review.
Regards,
Smitha
next prev parent reply other threads:[~2017-12-13 8:30 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171208093612epcas1p1eda138655cf5397893fe1f2b2152bd1f@epcas1p1.samsung.com>
2017-12-08 9:08 ` [Patch v6 00/12] Add MFC v10.10 support Smitha T Murthy
2017-12-08 9:08 ` Smitha T Murthy
2017-12-08 9:08 ` [Patch v6 01/12] [media] s5p-mfc: Rename IS_MFCV8 macro Smitha T Murthy
2017-12-08 9:08 ` Smitha T Murthy
2017-12-08 9:08 ` [Patch v6 02/12] [media] s5p-mfc: Adding initial support for MFC v10.10 Smitha T Murthy
2017-12-08 9:08 ` Smitha T Murthy
2017-12-08 13:25 ` Philippe Ombredanne
2017-12-08 13:25 ` Philippe Ombredanne
2017-12-08 13:25 ` Philippe Ombredanne
2018-01-18 12:36 ` Smitha T Murthy
2018-01-18 12:36 ` Smitha T Murthy
2018-01-18 12:36 ` Smitha T Murthy
2018-01-18 13:19 ` Hans Verkuil
2018-01-18 13:19 ` Hans Verkuil
2017-12-08 9:08 ` [Patch v6 03/12] [media] s5p-mfc: Use min scratch buffer size as provided by F/W Smitha T Murthy
2017-12-08 9:08 ` Smitha T Murthy
2017-12-08 9:08 ` [Patch v6 04/12] [media] s5p-mfc: Support MFCv10.10 buffer requirements Smitha T Murthy
2017-12-08 9:08 ` Smitha T Murthy
2017-12-08 9:08 ` [Patch v6 05/12] [media] videodev2.h: Add v4l2 definition for HEVC Smitha T Murthy
2017-12-08 9:08 ` Smitha T Murthy
2017-12-08 15:47 ` Nicolas Dufresne
2017-12-08 15:47 ` Nicolas Dufresne
2017-12-08 16:07 ` Mauro Carvalho Chehab
2017-12-08 16:07 ` Mauro Carvalho Chehab
2017-12-08 9:08 ` [Patch v6 06/12] [media] v4l2-ioctl: add HEVC format description Smitha T Murthy
2017-12-08 9:08 ` Smitha T Murthy
2017-12-08 9:08 ` [Patch v6 07/12] Documentation: v4l: Documentation for HEVC v4l2 definition Smitha T Murthy
2017-12-08 9:08 ` Smitha T Murthy
2017-12-08 9:08 ` [Patch v6 08/12] [media] s5p-mfc: Add support for HEVC decoder Smitha T Murthy
2017-12-08 9:08 ` Smitha T Murthy
2017-12-08 9:08 ` [Patch v6 09/12] [media] s5p-mfc: Add VP9 decoder support Smitha T Murthy
2017-12-08 9:08 ` Smitha T Murthy
2017-12-08 9:08 ` [Patch v6 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder Smitha T Murthy
2017-12-08 9:08 ` Smitha T Murthy
2017-12-09 18:48 ` Stanimir Varbanov
2017-12-09 18:48 ` Stanimir Varbanov
2017-12-12 2:34 ` Smitha T Murthy
2017-12-12 2:34 ` Smitha T Murthy
2017-12-12 9:46 ` Sylwester Nawrocki
2017-12-12 9:46 ` Sylwester Nawrocki
2017-12-13 8:30 ` Smitha T Murthy [this message]
2017-12-13 8:30 ` Smitha T Murthy
2018-01-22 11:08 ` Hans Verkuil
2018-01-22 11:08 ` Hans Verkuil
2018-01-23 4:24 ` Smitha T Murthy
2018-01-23 4:24 ` Smitha T Murthy
2017-12-08 9:08 ` [Patch v6 11/12] [media] s5p-mfc: Add support " Smitha T Murthy
2017-12-08 9:08 ` Smitha T Murthy
2017-12-08 9:08 ` [Patch v6 12/12] Documention: v4l: Documentation for HEVC CIDs Smitha T Murthy
2017-12-08 9:08 ` Smitha T Murthy
2018-01-22 12:15 ` Hans Verkuil
2018-01-22 12:15 ` Hans Verkuil
2018-01-23 5:40 ` Smitha T Murthy
2018-01-23 5:40 ` Smitha T Murthy
2018-01-22 12:18 ` [Patch v6 00/12] Add MFC v10.10 support Hans Verkuil
2018-01-22 12:18 ` Hans Verkuil
2018-01-23 5:41 ` Smitha T Murthy
2018-01-23 5:41 ` Smitha T Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513153801.22129.5.camel@smitha-fedora \
--to=smitha.t@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.