From: Ben Hutchings <ben.hutchings-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
To: Deepa Dinamani
<deepa.kernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Cc: y2038-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org
Subject: Re: [Y2038] [PATCH v2 10/10] nanosleep: change time types to safe __kernel_* types
Date: Fri, 15 Dec 2017 00:31:31 +0000 [thread overview]
Message-ID: <1513297891.18523.295.camel@codethink.co.uk> (raw)
In-Reply-To: <20171127193037.8711-11-deepa.kernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Mon, 2017-11-27 at 11:30 -0800, Deepa Dinamani wrote:
[...]
> @@ -15,9 +16,7 @@ struct pollfd;
> enum timespec_type {
> TT_NONE = 0,
> TT_NATIVE = 1,
> -#ifdef CONFIG_COMPAT
> TT_COMPAT = 2,
> -#endif
> };
>
> /*
> @@ -40,10 +39,8 @@ struct restart_block {
> clockid_t clockid;
> enum timespec_type type;
> union {
> - struct timespec __user *rmtp;
> -#ifdef CONFIG_COMPAT
> + struct __kernel_timespec __user *rmtp;
> struct compat_timespec __user *compat_rmtp;
> -#endif
> };
> u64 expires;
> } nanosleep;
[...]
The deletions of #ifdef and #endif here seem to belong in patch #6, as
that's the one that changes the condition for the compat nanosleep
implementation which uses the compat_rmtp field.
Ben.
--
Ben Hutchings
Software Developer, Codethink Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Deepa Dinamani <deepa.kernel@gmail.com>,
tglx@linutronix.de, john.stultz@linaro.org
Cc: y2038@lists.linaro.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [Y2038] [PATCH v2 10/10] nanosleep: change time types to safe __kernel_* types
Date: Fri, 15 Dec 2017 00:31:31 +0000 [thread overview]
Message-ID: <1513297891.18523.295.camel@codethink.co.uk> (raw)
In-Reply-To: <20171127193037.8711-11-deepa.kernel@gmail.com>
On Mon, 2017-11-27 at 11:30 -0800, Deepa Dinamani wrote:
[...]
> @@ -15,9 +16,7 @@ struct pollfd;
> enum timespec_type {
> TT_NONE = 0,
> TT_NATIVE = 1,
> -#ifdef CONFIG_COMPAT
> TT_COMPAT = 2,
> -#endif
> };
>
> /*
> @@ -40,10 +39,8 @@ struct restart_block {
> clockid_t clockid;
> enum timespec_type type;
> union {
> - struct timespec __user *rmtp;
> -#ifdef CONFIG_COMPAT
> + struct __kernel_timespec __user *rmtp;
> struct compat_timespec __user *compat_rmtp;
> -#endif
> };
> u64 expires;
> } nanosleep;
[...]
The deletions of #ifdef and #endif here seem to belong in patch #6, as
that's the one that changes the condition for the compat nanosleep
implementation which uses the compat_rmtp field.
Ben.
--
Ben Hutchings
Software Developer, Codethink Ltd.
next prev parent reply other threads:[~2017-12-15 0:31 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 19:30 [PATCH v2 00/10] posix_clocks: Prepare syscalls for 64 bit time_t conversion Deepa Dinamani
2017-11-27 19:30 ` Deepa Dinamani
2017-11-27 19:30 ` Deepa Dinamani
2017-11-27 19:30 ` Deepa Dinamani
2017-11-27 19:30 ` [PATCH v2 01/10] compat: Make compat helpers independent of CONFIG_COMPAT Deepa Dinamani
2017-11-27 19:30 ` [PATCH v2 02/10] include: Move compat_timespec/ timeval to compat_time.h Deepa Dinamani
2017-11-27 19:30 ` Deepa Dinamani
2017-11-27 19:30 ` Deepa Dinamani
2017-11-27 19:30 ` [PATCH v2 03/10] compat: enable compat_get/put_timespec64 always Deepa Dinamani
2017-12-14 23:27 ` [Y2038] " Ben Hutchings
2018-01-07 16:28 ` Deepa Dinamani
2017-11-27 19:30 ` [PATCH v2 04/10] arch: introduce CONFIG_64BIT_TIME Deepa Dinamani
2017-12-14 23:22 ` [Y2038] " Ben Hutchings
2017-11-27 19:30 ` [PATCH v2 05/10] arch: Introduce CONFIG_COMPAT_32BIT_TIME Deepa Dinamani
2017-11-27 19:30 ` [PATCH v2 06/10] posix-clocks: Make compat syscalls depend on CONFIG_COMPAT_32BIT_TIME Deepa Dinamani
2017-11-27 19:30 ` [PATCH v2 07/10] include: Add new y2038 safe __kernel_timespec Deepa Dinamani
2017-12-15 0:11 ` [Y2038] " Ben Hutchings
2017-12-15 10:36 ` Arnd Bergmann
2017-12-15 10:36 ` [Y2038] " Arnd Bergmann
2017-11-27 19:30 ` [PATCH v2 08/10] fix get_timespec64() for y2038 safe compat interfaces Deepa Dinamani
2017-12-15 0:21 ` [Y2038] " Ben Hutchings
2017-12-15 12:02 ` Arnd Bergmann
2017-12-17 23:51 ` Ben Hutchings
2017-12-18 5:11 ` Deepa Dinamani
2017-11-27 19:30 ` [PATCH v2 09/10] change time types to new y2038 safe __kernel_* types Deepa Dinamani
[not found] ` <20171127193037.8711-1-deepa.kernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-27 19:30 ` [PATCH v2 10/10] nanosleep: change time types to " Deepa Dinamani
2017-11-27 19:30 ` Deepa Dinamani
[not found] ` <20171127193037.8711-11-deepa.kernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-15 0:31 ` Ben Hutchings [this message]
2017-12-15 0:31 ` [Y2038] " Ben Hutchings
2017-11-27 21:58 ` [PATCH v2 00/10] posix_clocks: Prepare syscalls for 64 bit time_t conversion Arnd Bergmann
2017-11-27 21:58 ` Arnd Bergmann
2017-11-27 21:58 ` Arnd Bergmann
2017-11-27 21:58 ` Arnd Bergmann
2017-11-27 22:29 ` Deepa Dinamani
2017-11-27 22:29 ` Deepa Dinamani
2017-11-27 22:29 ` Deepa Dinamani
2017-11-27 22:29 ` Deepa Dinamani
2017-11-28 14:17 ` Arnd Bergmann
2017-11-28 14:17 ` Arnd Bergmann
2017-11-28 14:17 ` Arnd Bergmann
2017-11-28 14:17 ` Arnd Bergmann
2017-11-28 23:17 ` Deepa Dinamani
2017-11-28 23:17 ` Deepa Dinamani
2017-11-28 23:17 ` Deepa Dinamani
2017-11-28 23:17 ` Deepa Dinamani
2017-11-29 21:12 ` Arnd Bergmann
2017-11-29 21:12 ` Arnd Bergmann
2017-11-29 21:12 ` Arnd Bergmann
2017-11-29 21:12 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513297891.18523.295.camel@codethink.co.uk \
--to=ben.hutchings-4ydnlxn2s6swdatgbsphta@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=deepa.kernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=y2038-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.