All of lore.kernel.org
 help / color / mirror / Atom feed
From: knut.omang@oracle.com (Knut Omang)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH v2 2/5] Documentation: Add doc for runchecks
Date: Mon, 18 Dec 2017 18:05:33 +0100	[thread overview]
Message-ID: <1513616733.31439.188.camel@oracle.com> (raw)
In-Reply-To: <9102c188-847a-6a59-5fce-85dfa01ad280@users.sourceforge.net>

On Mon, 2017-12-18 at 17:23 +0100, SF Markus Elfring wrote:
> > I'll take these in for v3 as well and carefully review myself 
> > for any further errors of the same sorts..
> 
> I suggest to consider a few additional wording adjustments.
> 
> 
> > +``runchecks``. You can for instance use::
> 
> +``runchecks``. You can use for instance::

Will fix.

> * Do you care for the handling of orphaned words in paragraphs?

Will look over it, thanks.

> * Was any consensus achieved already for corresponding names?
> 
>   x Could a longer variable name like ?CHECKING_FLAGS? be easier to remember
>     than the proposed ?CF??

I kept CF as is already established as the flag to use for parameters with C= 

>   x Will the naming style matter (if you compare the approaches ?checkpatch?
>     and ?get_maintainer?)?

No consensus made on the naming, just that I tried using verbatim names from sparse, eg
lowercase-dash vs UPPERCASE_UNDERSCORE as in checkpatch and found the runchecks.cfg and
reporting lines more easy to read using the uppercase variants, and that it looks more
nice to have a uniform output across checkers.

I think that the visual output of a test is important, as even we developers tend to be
more happy with (and willing to execute) programs that produce nice output vs ones with
ugly, cluttery, inconsistent output :-)

Thanks,
Knut

> 
> 
> Regards,
> Markus

  parent reply	other threads:[~2017-12-18 17:05 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-16 14:42 [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} via a wrapper program Knut Omang
2017-12-16 14:42 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-16 14:42 ` Knut Omang
2017-12-16 14:42 ` [PATCH v2 1/5] runchecks: Generalize make C={1,2} to support multiple checkers Knut Omang
2017-12-16 14:42 ` [Cocci] [PATCH v2 2/5] Documentation: Add doc for runchecks, a checker runner Knut Omang
2017-12-16 14:42   ` Knut Omang
2017-12-16 15:08   ` [Cocci] " Julia Lawall
2017-12-16 15:08     ` Julia Lawall
2017-12-16 15:52     ` [Cocci] " Knut Omang
2017-12-16 15:52       ` Knut Omang
     [not found]   ` <4be59ef0-50a9-83f5-2cf1-f5a34e5810a7@users.sourceforge.net>
2017-12-16 16:26     ` [Cocci] [PATCH v2 2/5] Documentation: Add doc for runchecks Knut Omang
2017-12-16 16:32       ` Julia Lawall
     [not found]       ` <4fe0691a-ca79-6bfc-918c-77c109ac14b3@users.sourceforge.net>
2017-12-16 17:36         ` Knut Omang
     [not found]           ` <c4c816cc-580f-d60b-1048-23a35ba287d3@users.sourceforge.net>
2017-12-17  2:19             ` Knut Omang
     [not found]       ` <9102c188-847a-6a59-5fce-85dfa01ad280@users.sourceforge.net>
2017-12-18 17:05         ` Knut Omang [this message]
     [not found]   ` <67ce13bc-6022-9110-6d14-45ca22f91492@users.sourceforge.net>
2017-12-23 11:22     ` [Cocci] [PATCH v2 2/5] Documentation: Further challenges around “runchecks” Knut Omang
2017-12-16 14:42 ` [PATCH v2 3/5] checkpatch: Improve --fix-inplace for TABSTOP Knut Omang
2017-12-16 15:13   ` Joe Perches
2017-12-16 15:55     ` Knut Omang
2017-12-16 14:42 ` [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds Knut Omang
2017-12-16 17:45   ` Stephen Hemminger
2017-12-16 18:24     ` Joe Perches
2017-12-16 20:00       ` santosh.shilimkar
     [not found]         ` <499ec5ae-d1d5-3bb2-8e10-de48283a1c2e-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-12-17  2:02           ` Knut Omang
2017-12-17  2:02             ` Knut Omang
     [not found]             ` <1513476136.31439.96.camel-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-12-18 19:28               ` Santosh Shilimkar
2017-12-18 19:28                 ` Santosh Shilimkar
2017-12-17  1:57       ` Knut Omang
2017-12-17  1:46     ` Knut Omang
2017-12-17  1:46       ` Knut Omang
2017-12-16 14:42 ` [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core Knut Omang
     [not found]   ` <0ce3c307255b22d23f49d13213b76044647e6f60.1513430008.git-series.knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-12-18  8:02     ` Leon Romanovsky
2017-12-18  8:02       ` Leon Romanovsky
     [not found]       ` <20171218080223.GB18894-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-12-18 12:36         ` Knut Omang
2017-12-18 12:36           ` Knut Omang
     [not found]           ` <1513600586.22938.29.camel-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-12-18 14:04             ` Leon Romanovsky
2017-12-18 14:04               ` Leon Romanovsky
2017-12-18 15:23               ` Knut Omang
2017-12-18 19:03             ` Joe Perches
2017-12-18 19:03               ` Joe Perches
     [not found]               ` <1513623831.31581.121.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-12-18 19:18                 ` Leon Romanovsky
2017-12-18 19:18                   ` Leon Romanovsky
2017-12-16 15:21 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} via a wrapper program Joe Perches
2017-12-16 15:21   ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Joe Perches
2017-12-16 16:27   ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Knut Omang
2017-12-16 16:27     ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-16 17:00     ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Joe Perches
2017-12-16 17:00       ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Joe Perches
2017-12-16 17:11       ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Knut Omang
2017-12-16 17:11         ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-16 17:47 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Stephen Hemminger
2017-12-16 17:47   ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Stephen Hemminger
2017-12-16 17:47   ` Stephen Hemminger
2017-12-16 18:02   ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Joe Perches
2017-12-16 18:02     ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Joe Perches
2017-12-16 18:02     ` Joe Perches
2017-12-17  2:14   ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Knut Omang
2017-12-17  2:14     ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-17  2:14     ` Knut Omang
2017-12-18  5:00     ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Jason Gunthorpe
2017-12-18  5:00       ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Jason Gunthorpe
2017-12-18  5:00       ` Jason Gunthorpe
2017-12-18  6:00       ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Joe Perches
2017-12-18  6:00         ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Joe Perches
2017-12-18  6:00         ` Joe Perches
2017-12-18 13:05         ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Knut Omang
2017-12-18 13:05           ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-18 13:05           ` Knut Omang
2017-12-18 15:30           ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Joe Perches
2017-12-18 15:30             ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Joe Perches
2017-12-18 15:30             ` Joe Perches
2017-12-18 16:41             ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Knut Omang
2017-12-18 16:41               ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-18 16:41               ` Knut Omang
2017-12-18 17:49           ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Jason Gunthorpe
2017-12-18 17:49             ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Jason Gunthorpe
2017-12-18 17:49             ` Jason Gunthorpe
2017-12-18 17:46         ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Jason Gunthorpe
2017-12-18 17:46           ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Jason Gunthorpe
2017-12-18 17:46           ` Jason Gunthorpe
2017-12-18 17:53           ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Joe Perches
2017-12-18 17:53             ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Joe Perches
2017-12-18 17:53             ` Joe Perches
2017-12-18 17:56           ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Bart Van Assche
2017-12-18 17:56             ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Bart Van Assche
2017-12-18 17:56             ` Bart Van Assche
2017-12-18 18:39             ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Knut Omang
2017-12-18 18:39               ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-18 18:39               ` Knut Omang
2017-12-18 18:39               ` Knut Omang
2017-12-18 19:24               ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Leon Romanovsky
2017-12-18 19:24                 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Leon Romanovsky
2017-12-18 19:24                 ` Leon Romanovsky
2017-12-18 19:24                 ` Leon Romanovsky
2017-12-18 13:41       ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Knut Omang
2017-12-18 13:41         ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-18 13:41         ` Knut Omang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513616733.31439.188.camel@oracle.com \
    --to=knut.omang@oracle.com \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.