From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: "Knut Omang" <knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Jason Gunthorpe" <jgg-uk2M96/98Pc@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Doug Ledford" <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Håkon Bugge"
<haakon.bugge-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
"Åsmund Østvold"
<asmund.ostvold-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core
Date: Mon, 18 Dec 2017 21:18:00 +0200 [thread overview]
Message-ID: <20171218191800.GE18894@mtr-leonro.local> (raw)
In-Reply-To: <1513623831.31581.121.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
On Mon, Dec 18, 2017 at 11:03:51AM -0800, Joe Perches wrote:
> On Mon, 2017-12-18 at 13:36 +0100, Knut Omang wrote:
> > On Mon, 2017-12-18 at 10:02 +0200, Leon Romanovsky wrote:
> []
> > > Also, I agree with other reviewers, there is no excuse for adding
> > > checkpatch specifics per-subsystem/folder, the differences are better
> > > to be treated in checkpatch.pl itself.
>
> What other reviewers are those?
I saw responses from Stephen and Jason.
>
> As a checkpatch maintainer, I don't believe it's appropriate
> to add many per-subsystem specific rules to checkpatch.
There are not so much differences, I'm aware of only one specific subsystem - netdev.
The rest of the kernel more or less follows general CodingStyle and
don't need anything specific in checkpatch.pl
Thanks
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leon@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: "Knut Omang" <knut.omang@oracle.com>,
linux-kernel@vger.kernel.org, "Jason Gunthorpe" <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org, "Doug Ledford" <dledford@redhat.com>,
"Håkon Bugge" <haakon.bugge@oracle.com>,
"Åsmund Østvold" <asmund.ostvold@oracle.com>
Subject: Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core
Date: Mon, 18 Dec 2017 21:18:00 +0200 [thread overview]
Message-ID: <20171218191800.GE18894@mtr-leonro.local> (raw)
In-Reply-To: <1513623831.31581.121.camel@perches.com>
[-- Attachment #1: Type: text/plain, Size: 991 bytes --]
On Mon, Dec 18, 2017 at 11:03:51AM -0800, Joe Perches wrote:
> On Mon, 2017-12-18 at 13:36 +0100, Knut Omang wrote:
> > On Mon, 2017-12-18 at 10:02 +0200, Leon Romanovsky wrote:
> []
> > > Also, I agree with other reviewers, there is no excuse for adding
> > > checkpatch specifics per-subsystem/folder, the differences are better
> > > to be treated in checkpatch.pl itself.
>
> What other reviewers are those?
I saw responses from Stephen and Jason.
>
> As a checkpatch maintainer, I don't believe it's appropriate
> to add many per-subsystem specific rules to checkpatch.
There are not so much differences, I'm aware of only one specific subsystem - netdev.
The rest of the kernel more or less follows general CodingStyle and
don't need anything specific in checkpatch.pl
Thanks
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-12-18 19:18 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-16 14:42 [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} via a wrapper program Knut Omang
2017-12-16 14:42 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-16 14:42 ` Knut Omang
2017-12-16 14:42 ` [PATCH v2 1/5] runchecks: Generalize make C={1,2} to support multiple checkers Knut Omang
2017-12-16 14:42 ` [Cocci] [PATCH v2 2/5] Documentation: Add doc for runchecks, a checker runner Knut Omang
2017-12-16 14:42 ` Knut Omang
2017-12-16 15:08 ` [Cocci] " Julia Lawall
2017-12-16 15:08 ` Julia Lawall
2017-12-16 15:52 ` [Cocci] " Knut Omang
2017-12-16 15:52 ` Knut Omang
[not found] ` <4be59ef0-50a9-83f5-2cf1-f5a34e5810a7@users.sourceforge.net>
2017-12-16 16:26 ` [Cocci] [PATCH v2 2/5] Documentation: Add doc for runchecks Knut Omang
2017-12-16 16:32 ` Julia Lawall
[not found] ` <4fe0691a-ca79-6bfc-918c-77c109ac14b3@users.sourceforge.net>
2017-12-16 17:36 ` Knut Omang
[not found] ` <c4c816cc-580f-d60b-1048-23a35ba287d3@users.sourceforge.net>
2017-12-17 2:19 ` Knut Omang
[not found] ` <9102c188-847a-6a59-5fce-85dfa01ad280@users.sourceforge.net>
2017-12-18 17:05 ` Knut Omang
[not found] ` <67ce13bc-6022-9110-6d14-45ca22f91492@users.sourceforge.net>
2017-12-23 11:22 ` [Cocci] [PATCH v2 2/5] Documentation: Further challenges around “runchecks” Knut Omang
2017-12-16 14:42 ` [PATCH v2 3/5] checkpatch: Improve --fix-inplace for TABSTOP Knut Omang
2017-12-16 15:13 ` Joe Perches
2017-12-16 15:55 ` Knut Omang
2017-12-16 14:42 ` [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds Knut Omang
2017-12-16 17:45 ` Stephen Hemminger
2017-12-16 18:24 ` Joe Perches
2017-12-16 20:00 ` santosh.shilimkar
[not found] ` <499ec5ae-d1d5-3bb2-8e10-de48283a1c2e-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-12-17 2:02 ` Knut Omang
2017-12-17 2:02 ` Knut Omang
[not found] ` <1513476136.31439.96.camel-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-12-18 19:28 ` Santosh Shilimkar
2017-12-18 19:28 ` Santosh Shilimkar
2017-12-17 1:57 ` Knut Omang
2017-12-17 1:46 ` Knut Omang
2017-12-17 1:46 ` Knut Omang
2017-12-16 14:42 ` [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core Knut Omang
[not found] ` <0ce3c307255b22d23f49d13213b76044647e6f60.1513430008.git-series.knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-12-18 8:02 ` Leon Romanovsky
2017-12-18 8:02 ` Leon Romanovsky
[not found] ` <20171218080223.GB18894-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-12-18 12:36 ` Knut Omang
2017-12-18 12:36 ` Knut Omang
[not found] ` <1513600586.22938.29.camel-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-12-18 14:04 ` Leon Romanovsky
2017-12-18 14:04 ` Leon Romanovsky
2017-12-18 15:23 ` Knut Omang
2017-12-18 19:03 ` Joe Perches
2017-12-18 19:03 ` Joe Perches
[not found] ` <1513623831.31581.121.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-12-18 19:18 ` Leon Romanovsky [this message]
2017-12-18 19:18 ` Leon Romanovsky
2017-12-16 15:21 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} via a wrapper program Joe Perches
2017-12-16 15:21 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Joe Perches
2017-12-16 16:27 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Knut Omang
2017-12-16 16:27 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-16 17:00 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Joe Perches
2017-12-16 17:00 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Joe Perches
2017-12-16 17:11 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Knut Omang
2017-12-16 17:11 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-16 17:47 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Stephen Hemminger
2017-12-16 17:47 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Stephen Hemminger
2017-12-16 17:47 ` Stephen Hemminger
2017-12-16 18:02 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Joe Perches
2017-12-16 18:02 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Joe Perches
2017-12-16 18:02 ` Joe Perches
2017-12-17 2:14 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Knut Omang
2017-12-17 2:14 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-17 2:14 ` Knut Omang
2017-12-18 5:00 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Jason Gunthorpe
2017-12-18 5:00 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Jason Gunthorpe
2017-12-18 5:00 ` Jason Gunthorpe
2017-12-18 6:00 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Joe Perches
2017-12-18 6:00 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Joe Perches
2017-12-18 6:00 ` Joe Perches
2017-12-18 13:05 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Knut Omang
2017-12-18 13:05 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-18 13:05 ` Knut Omang
2017-12-18 15:30 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Joe Perches
2017-12-18 15:30 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Joe Perches
2017-12-18 15:30 ` Joe Perches
2017-12-18 16:41 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Knut Omang
2017-12-18 16:41 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-18 16:41 ` Knut Omang
2017-12-18 17:49 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Jason Gunthorpe
2017-12-18 17:49 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Jason Gunthorpe
2017-12-18 17:49 ` Jason Gunthorpe
2017-12-18 17:46 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Jason Gunthorpe
2017-12-18 17:46 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Jason Gunthorpe
2017-12-18 17:46 ` Jason Gunthorpe
2017-12-18 17:53 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Joe Perches
2017-12-18 17:53 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Joe Perches
2017-12-18 17:53 ` Joe Perches
2017-12-18 17:56 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Bart Van Assche
2017-12-18 17:56 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Bart Van Assche
2017-12-18 17:56 ` Bart Van Assche
2017-12-18 18:39 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Knut Omang
2017-12-18 18:39 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-18 18:39 ` Knut Omang
2017-12-18 18:39 ` Knut Omang
2017-12-18 19:24 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Leon Romanovsky
2017-12-18 19:24 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Leon Romanovsky
2017-12-18 19:24 ` Leon Romanovsky
2017-12-18 19:24 ` Leon Romanovsky
2017-12-18 13:41 ` [Cocci] [PATCH v2 0/5] Support for generalized use of make C={1, 2} " Knut Omang
2017-12-18 13:41 ` [PATCH v2 0/5] Support for generalized use of make C={1,2} " Knut Omang
2017-12-18 13:41 ` Knut Omang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218191800.GE18894@mtr-leonro.local \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=asmund.ostvold-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=haakon.bugge-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=jgg-uk2M96/98Pc@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.