From: Mike Galbraith <efault@gmx.de>
To: Trond Myklebust <trondmy@primarydata.com>,
"bfields@fieldses.org" <bfields@fieldses.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"jlayton@kernel.org" <jlayton@kernel.org>
Subject: Re: NFS: 82ms wakeup latency 4.14-rc4
Date: Mon, 18 Dec 2017 18:26:59 +0100 [thread overview]
Message-ID: <1513618019.7113.27.camel@gmx.de> (raw)
In-Reply-To: <1513617866.4581.6.camel@primarydata.com>
On Mon, 2017-12-18 at 17:24 +0000, Trond Myklebust wrote:
> On Mon, 2017-12-18 at 18:00 +0100, Mike Galbraith wrote:
> > On Mon, 2017-12-18 at 11:35 -0500, J. Bruce Fields wrote:
> > >
> > > Like I say, I don't really understand the issues here, so it's more
> > > a
> > > question than an objection.... (I don't know any reason a
> > > cond_resched() would be bad there.)
> >
> > Think of it this way: what all can be queued up behind that kworker
> > that is hogging CPU for huge swaths of time? It's not only userspace
> > that suffers.
> >
>
> Any cond_sched() belongs in the loop in nfs_commit_release_pages()
> (where it can be mitigated) rather than in a function whose purpose is
> to free memory. There is no reason to call it from the writeback or
> readpages code.
(this is why bandaid didn't come equipped with changelog etc:)
next prev parent reply other threads:[~2017-12-18 17:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 15:17 NFS: 82ms wakeup latency 4.14-rc4 Mike Galbraith
2017-12-18 15:31 ` Mike Galbraith
2017-12-18 16:35 ` J. Bruce Fields
2017-12-18 16:48 ` Mike Galbraith
2017-12-18 17:00 ` Mike Galbraith
2017-12-18 17:17 ` Mike Galbraith
2017-12-18 17:27 ` J. Bruce Fields
2017-12-18 17:47 ` Mike Galbraith
2017-12-18 18:34 ` Mike Galbraith
2017-12-18 17:24 ` Trond Myklebust
2017-12-18 17:24 ` Trond Myklebust
2017-12-18 17:26 ` Mike Galbraith [this message]
2018-01-02 20:29 ` [patch] fs/nfs: Add a resched point to nfs_commit_release_pages() Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513618019.7113.27.camel@gmx.de \
--to=efault@gmx.de \
--cc=bfields@fieldses.org \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.