From: Trond Myklebust <trondmy@primarydata.com>
To: "bfields@fieldses.org" <bfields@fieldses.org>,
"efault@gmx.de" <efault@gmx.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"jlayton@kernel.org" <jlayton@kernel.org>
Subject: Re: NFS: 82ms wakeup latency 4.14-rc4
Date: Mon, 18 Dec 2017 17:24:29 +0000 [thread overview]
Message-ID: <1513617866.4581.6.camel@primarydata.com> (raw)
In-Reply-To: <1513616405.7113.18.camel@gmx.de>
T24gTW9uLCAyMDE3LTEyLTE4IGF0IDE4OjAwICswMTAwLCBNaWtlIEdhbGJyYWl0aCB3cm90ZToN
Cj4gT24gTW9uLCAyMDE3LTEyLTE4IGF0IDExOjM1IC0wNTAwLCBKLiBCcnVjZSBGaWVsZHMgd3Jv
dGU6DQo+ID4gDQo+ID4gTGlrZSBJIHNheSwgSSBkb24ndCByZWFsbHkgdW5kZXJzdGFuZCB0aGUg
aXNzdWVzIGhlcmUsIHNvIGl0J3MgbW9yZQ0KPiA+IGENCj4gPiBxdWVzdGlvbiB0aGFuIGFuIG9i
amVjdGlvbi4uLi4gIChJIGRvbid0IGtub3cgYW55IHJlYXNvbiBhDQo+ID4gY29uZF9yZXNjaGVk
KCkgd291bGQgYmUgYmFkIHRoZXJlLikNCj4gDQo+IFRoaW5rIG9mIGl0IHRoaXMgd2F5OiB3aGF0
IGFsbCBjYW4gYmUgcXVldWVkIHVwIGJlaGluZCB0aGF0IGt3b3JrZXINCj4gdGhhdCBpcyBob2dn
aW5nIENQVSBmb3IgaHVnZSBzd2F0aHMgb2YgdGltZT8gIEl0J3Mgbm90IG9ubHkgdXNlcnNwYWNl
DQo+IHRoYXQgc3VmZmVycy4NCj4gDQoNCkFueSBjb25kX3NjaGVkKCkgYmVsb25ncyBpbiB0aGUg
bG9vcCBpbiBuZnNfY29tbWl0X3JlbGVhc2VfcGFnZXMoKQ0KKHdoZXJlIGl0IGNhbiBiZSBtaXRp
Z2F0ZWQpIHJhdGhlciB0aGFuIGluIGEgZnVuY3Rpb24gd2hvc2UgcHVycG9zZSBpcw0KdG8gZnJl
ZSBtZW1vcnkuIFRoZXJlIGlzIG5vIHJlYXNvbiB0byBjYWxsIGl0IGZyb20gdGhlIHdyaXRlYmFj
ayBvcg0KcmVhZHBhZ2VzIGNvZGUuDQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMg
Y2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9uZC5teWtsZWJ1c3RAcHJpbWFyeWRh
dGEuY29tDQo=
WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trondmy@primarydata.com>
To: "bfields@fieldses.org" <bfields@fieldses.org>,
"efault@gmx.de" <efault@gmx.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"jlayton@kernel.org" <jlayton@kernel.org>
Subject: Re: NFS: 82ms wakeup latency 4.14-rc4
Date: Mon, 18 Dec 2017 17:24:29 +0000 [thread overview]
Message-ID: <1513617866.4581.6.camel@primarydata.com> (raw)
In-Reply-To: <1513616405.7113.18.camel@gmx.de>
On Mon, 2017-12-18 at 18:00 +0100, Mike Galbraith wrote:
> On Mon, 2017-12-18 at 11:35 -0500, J. Bruce Fields wrote:
> >
> > Like I say, I don't really understand the issues here, so it's more
> > a
> > question than an objection.... (I don't know any reason a
> > cond_resched() would be bad there.)
>
> Think of it this way: what all can be queued up behind that kworker
> that is hogging CPU for huge swaths of time? It's not only userspace
> that suffers.
>
Any cond_sched() belongs in the loop in nfs_commit_release_pages()
(where it can be mitigated) rather than in a function whose purpose is
to free memory. There is no reason to call it from the writeback or
readpages code.
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
next prev parent reply other threads:[~2017-12-18 17:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 15:17 NFS: 82ms wakeup latency 4.14-rc4 Mike Galbraith
2017-12-18 15:31 ` Mike Galbraith
2017-12-18 16:35 ` J. Bruce Fields
2017-12-18 16:48 ` Mike Galbraith
2017-12-18 17:00 ` Mike Galbraith
2017-12-18 17:17 ` Mike Galbraith
2017-12-18 17:27 ` J. Bruce Fields
2017-12-18 17:47 ` Mike Galbraith
2017-12-18 18:34 ` Mike Galbraith
2017-12-18 17:24 ` Trond Myklebust [this message]
2017-12-18 17:24 ` Trond Myklebust
2017-12-18 17:26 ` Mike Galbraith
2018-01-02 20:29 ` [patch] fs/nfs: Add a resched point to nfs_commit_release_pages() Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513617866.4581.6.camel@primarydata.com \
--to=trondmy@primarydata.com \
--cc=bfields@fieldses.org \
--cc=efault@gmx.de \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.