All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH igt] igt/pm_rps: Always allocate spin[0]
@ 2017-12-11 12:37 Chris Wilson
  2017-12-11 14:37 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (6 more replies)
  0 siblings, 7 replies; 11+ messages in thread
From: Chris Wilson @ 2017-12-11 12:37 UTC (permalink / raw)
  To: intel-gfx

Avoid having to test for spin[0] existing by starting the load-loop with
it allocated.

References: https://bugs.freedesktop.org/show_bug.cgi?id=104060
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/pm_rps.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/tests/pm_rps.c b/tests/pm_rps.c
index 57633c547..8f16ea47f 100644
--- a/tests/pm_rps.c
+++ b/tests/pm_rps.c
@@ -231,24 +231,24 @@ static void load_helper_run(enum load load)
 
 		igt_debug("Applying %s load...\n", lh.load ? "high" : "low");
 
+		spin[0] = igt_spin_batch_new(drm_fd, 0, 0, 0);
 		while (!lh.exit) {
-			if (spin[0]) {
-				handle = spin[0]->handle;
-				igt_spin_batch_end(spin[0]);
-				while (gem_bo_busy(drm_fd, handle))
-					usleep(100);
-				igt_spin_batch_free(drm_fd, spin[0]);
+			handle = spin[0]->handle;
+			igt_spin_batch_end(spin[0]);
+			while (gem_bo_busy(drm_fd, handle))
 				usleep(100);
-			}
+
+			igt_spin_batch_free(drm_fd, spin[0]);
+			usleep(100);
+
 			spin[0] = spin[1];
 			spin[lh.load == HIGH] =
-				igt_spin_batch_new(drm_fd, 0, 0, 0);
+				__igt_spin_batch_new(drm_fd, 0, 0, 0);
 		}
 
-		if (spin[0]) {
-			handle = spin[0]->handle;
-			igt_spin_batch_end(spin[0]);
-		}
+		handle = spin[0]->handle;
+		igt_spin_batch_end(spin[0]);
+
 		if (spin[1]) {
 			handle = spin[1]->handle;
 			igt_spin_batch_end(spin[1]);
-- 
2.15.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* ✓ Fi.CI.BAT: success for igt/pm_rps: Always allocate spin[0]
  2017-12-11 12:37 [PATCH igt] igt/pm_rps: Always allocate spin[0] Chris Wilson
@ 2017-12-11 14:37 ` Patchwork
  2017-12-11 15:23 ` Patchwork
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2017-12-11 14:37 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/pm_rps: Always allocate spin[0]
URL   : https://patchwork.freedesktop.org/series/35176/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
4d40a6776f08dd87b7e007da691b73d45a9bf1fa igt_fb: Add support for drawing to non-32bit Y/Yf tiled FBs

with latest DRM-Tip kernel build CI_DRM_3497
bb55ba9311de drm-tip: 2017y-12m-11d-11h-51m-11s UTC integration manifest

No testlist changes.


== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_642/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* ✓ Fi.CI.BAT: success for igt/pm_rps: Always allocate spin[0]
  2017-12-11 12:37 [PATCH igt] igt/pm_rps: Always allocate spin[0] Chris Wilson
  2017-12-11 14:37 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-12-11 15:23 ` Patchwork
  2017-12-11 16:18 ` ✗ Fi.CI.IGT: failure " Patchwork
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2017-12-11 15:23 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/pm_rps: Always allocate spin[0]
URL   : https://patchwork.freedesktop.org/series/35176/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
4d40a6776f08dd87b7e007da691b73d45a9bf1fa igt_fb: Add support for drawing to non-32bit Y/Yf tiled FBs

with latest DRM-Tip kernel build CI_DRM_3497
bb55ba9311de drm-tip: 2017y-12m-11d-11h-51m-11s UTC integration manifest

No testlist changes.

Test debugfs_test:
        Subgroup read_all_entries:
                dmesg-fail -> FAIL       (fi-elk-e7500) fdo#103989 +1

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:438s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:446s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:386s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:510s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:283s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:502s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:507s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:492s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:470s
fi-elk-e7500     total:224  pass:162  dwarn:15  dfail:0   fail:1   skip:45 
fi-gdg-551       total:288  pass:178  dwarn:1   dfail:0   fail:1   skip:108 time:269s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:541s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:388s
fi-hsw-4770r     total:288  pass:224  dwarn:0   dfail:0   fail:0   skip:64  time:261s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:397s
fi-ivb-3770      total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:445s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:490s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:526s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:471s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:593s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:539s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:566s
fi-skl-6700k     total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:521s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:502s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:450s
fi-snb-2520m     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:549s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:420s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:608s
fi-cnl-y         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:637s
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:501s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_642/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* ✗ Fi.CI.IGT: failure for igt/pm_rps: Always allocate spin[0]
  2017-12-11 12:37 [PATCH igt] igt/pm_rps: Always allocate spin[0] Chris Wilson
  2017-12-11 14:37 ` ✓ Fi.CI.BAT: success for " Patchwork
  2017-12-11 15:23 ` Patchwork
@ 2017-12-11 16:18 ` Patchwork
  2017-12-19 12:05   ` Arkadiusz Hiler
  2017-12-15 12:41 ` ✓ Fi.CI.BAT: success " Patchwork
                   ` (3 subsequent siblings)
  6 siblings, 1 reply; 11+ messages in thread
From: Patchwork @ 2017-12-11 16:18 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/pm_rps: Always allocate spin[0]
URL   : https://patchwork.freedesktop.org/series/35176/
State : failure

== Summary ==

Test gem_tiled_swapping:
        Subgroup non-threaded:
                incomplete -> PASS       (shard-hsw) fdo#104009
Test pm_rps:
        Subgroup min-max-config-loaded:
                pass       -> FAIL       (shard-snb)
                pass       -> FAIL       (shard-hsw)
Test gem_eio:
        Subgroup in-flight-suspend:
                skip       -> PASS       (shard-snb)
Test kms_flip:
        Subgroup vblank-vs-suspend-interruptible:
                incomplete -> PASS       (shard-hsw) fdo#100368
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
                pass       -> FAIL       (shard-snb) fdo#101623
Test gem_softpin:
        Subgroup noreloc-s4:
                dmesg-fail -> FAIL       (shard-hsw) fdo#103375

fdo#104009 https://bugs.freedesktop.org/show_bug.cgi?id=104009
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375

shard-hsw        total:2692 pass:1536 dwarn:1   dfail:0   fail:11  skip:1144 time:9516s
shard-snb        total:2692 pass:1308 dwarn:1   dfail:0   fail:13  skip:1370 time:8153s
Blacklisted hosts:
shard-apl        total:2670 pass:1661 dwarn:1   dfail:0   fail:25  skip:981 time:13592s
shard-kbl        total:2649 pass:1778 dwarn:1   dfail:0   fail:23  skip:846 time:10695s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_642/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* ✓ Fi.CI.BAT: success for igt/pm_rps: Always allocate spin[0]
  2017-12-11 12:37 [PATCH igt] igt/pm_rps: Always allocate spin[0] Chris Wilson
                   ` (2 preceding siblings ...)
  2017-12-11 16:18 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2017-12-15 12:41 ` Patchwork
  2017-12-19 12:34 ` [PATCH igt v2] " Chris Wilson
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2017-12-15 12:41 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/pm_rps: Always allocate spin[0]
URL   : https://patchwork.freedesktop.org/series/35176/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
417b29e2fbc97f99455a9e4bd22270bab0a4628f lib/igt_sysfs: Let igt_sysfs_read|write return -errno

with latest DRM-Tip kernel build CI_DRM_3521
ad43db157c69 drm-tip: 2017y-12m-14d-20h-09m-53s UTC integration manifest

No testlist changes.

Test debugfs_test:
        Subgroup read_all_entries:
                dmesg-fail -> DMESG-WARN (fi-elk-e7500) fdo#103989 +1
                incomplete -> PASS       (fi-snb-2520m) fdo#103713 +1
Test gem_sync:
        Subgroup basic-each:
                skip       -> PASS       (fi-blb-e6850)
        Subgroup basic-many-each:
                skip       -> PASS       (fi-blb-e6850)
        Subgroup basic-store-all:
                skip       -> PASS       (fi-blb-e6850)
        Subgroup basic-store-each:
                skip       -> PASS       (fi-blb-e6850)
Test gem_tiled_blits:
        Subgroup basic:
                skip       -> PASS       (fi-blb-e6850)
Test gem_tiled_fence_blits:
        Subgroup basic:
                skip       -> PASS       (fi-blb-e6850)
Test gem_wait:
        Subgroup basic-busy-all:
                skip       -> PASS       (fi-blb-e6850)
        Subgroup basic-wait-all:
                skip       -> PASS       (fi-blb-e6850)
        Subgroup basic-await-all:
                skip       -> PASS       (fi-blb-e6850)
Test kms_busy:
        Subgroup basic-flip-a:
                skip       -> PASS       (fi-blb-e6850)
        Subgroup basic-flip-b:
                skip       -> PASS       (fi-blb-e6850)
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-legacy:
                skip       -> PASS       (fi-blb-e6850)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                dmesg-warn -> PASS       (fi-kbl-r) fdo#104172

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:435s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:439s
fi-blb-e6850     total:288  pass:222  dwarn:1   dfail:1   fail:0   skip:64  time:395s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:508s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:279s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:499s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:498s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:488s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:472s
fi-elk-e7500     total:224  pass:163  dwarn:15  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:178  dwarn:1   dfail:0   fail:1   skip:108 time:267s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:535s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:405s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:414s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:389s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:474s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:429s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:484s
fi-kbl-7560u     total:288  pass:268  dwarn:1   dfail:0   fail:0   skip:19  time:520s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:471s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:527s
fi-pnv-d510      total:288  pass:221  dwarn:1   dfail:0   fail:1   skip:65  time:596s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:451s
fi-skl-6600u     total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:533s
fi-skl-6700hq    total:288  pass:261  dwarn:1   dfail:0   fail:0   skip:26  time:559s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:487s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:450s
fi-snb-2520m     total:245  pass:211  dwarn:0   dfail:0   fail:0   skip:33 
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:427s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:596s
fi-cnl-y         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:619s
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:484s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_678/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: ✗ Fi.CI.IGT:  failure for igt/pm_rps: Always allocate spin[0]
  2017-12-11 16:18 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2017-12-19 12:05   ` Arkadiusz Hiler
  0 siblings, 0 replies; 11+ messages in thread
From: Arkadiusz Hiler @ 2017-12-19 12:05 UTC (permalink / raw)
  To: intel-gfx

On Mon, Dec 11, 2017 at 04:18:40PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: igt/pm_rps: Always allocate spin[0]
> URL   : https://patchwork.freedesktop.org/series/35176/
> State : failure
> 
> == Summary ==
> 
> Test gem_tiled_swapping:
>         Subgroup non-threaded:
>                 incomplete -> PASS       (shard-hsw) fdo#104009
> Test pm_rps:
>         Subgroup min-max-config-loaded:
>                 pass       -> FAIL       (shard-snb)
>                 pass       -> FAIL       (shard-hsw)

Just for the sanity, so it does not look like it's lingering here
unattended.

Seems to break it for all platforms:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_642/shard-snb4/igt@pm_rps@min-max-config-loaded.html
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_642/shard-hsw1/igt@pm_rps@min-max-config-loaded.html
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_642/shard-apl1/igt@pm_rps@min-max-config-loaded.html
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_642/shard-kbl7/igt@pm_rps@min-max-config-loaded.html

Causing the same fail:
--------------------------------------------------------------------------------------------------------
Increase max above RP0 (invalid)...
(pm_rps:2211) DEBUG: gt freq (MHz):  cur=1350  min=850  max=1350  RP0=1350  RP1=850  RPn=850  boost=1350
(pm_rps:2211) DEBUG: Required 0 msec to reach cur=max
(pm_rps:2211) CRITICAL: Test assertion failure function load_helper_stop, file pm_rps.c:277:
(pm_rps:2211) CRITICAL: Failed assertion: igt_wait_helper(&lh.igt_proc) == 0
(pm_rps:2211) CRITICAL: Last errno: 22, Invalid argument
(pm_rps:2211) igt-core-INFO: Stack trace:
(pm_rps:2211) igt-core-INFO:   #0 [__igt_fail_assert+0x101]
(pm_rps:2211) igt-core-INFO:   #1 [load_helper_stop+0x4f]
(pm_rps:2211) igt-core-INFO:   #2 [__real_main564+0x1a8]
(pm_rps:2211) igt-core-INFO:   #3 [main+0x27]
(pm_rps:2211) igt-core-INFO:   #4 [__libc_start_main+0xf1]
(pm_rps:2211) igt-core-INFO:   #5 [_start+0x2a]
(pm_rps:2211) igt-core-INFO:   #6 [<unknown>+0x2a]
--------------------------------------------------------------------------------------------------------

-- 
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH igt v2] igt/pm_rps: Always allocate spin[0]
  2017-12-11 12:37 [PATCH igt] igt/pm_rps: Always allocate spin[0] Chris Wilson
                   ` (3 preceding siblings ...)
  2017-12-15 12:41 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2017-12-19 12:34 ` Chris Wilson
  2017-12-20 10:12   ` Szwichtenberg, Radoslaw
  2017-12-19 16:54 ` ✓ Fi.CI.BAT: success for igt/pm_rps: Always allocate spin[0] (rev2) Patchwork
  2017-12-19 21:20 ` ✓ Fi.CI.IGT: " Patchwork
  6 siblings, 1 reply; 11+ messages in thread
From: Chris Wilson @ 2017-12-19 12:34 UTC (permalink / raw)
  To: intel-gfx

Avoid having to test for spin[0] existing by starting the load-loop with
it allocated.

v2: Preallocate the spin[1] as well for high load.

References: https://bugs.freedesktop.org/show_bug.cgi?id=104060
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/pm_rps.c | 27 +++++++++++++++------------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/tests/pm_rps.c b/tests/pm_rps.c
index 57633c547..6148f5532 100644
--- a/tests/pm_rps.c
+++ b/tests/pm_rps.c
@@ -191,6 +191,7 @@ static void load_helper_signal_handler(int sig)
 	if (sig == SIGUSR2) {
 		lh.load = !lh.load;
 		igt_debug("Switching background load to %s\n", lh.load ? "high" : "low");
+		usleep(200); /* wait for a spin-batch cycle */
 	} else
 		lh.exit = true;
 }
@@ -231,24 +232,26 @@ static void load_helper_run(enum load load)
 
 		igt_debug("Applying %s load...\n", lh.load ? "high" : "low");
 
+		spin[0] = igt_spin_batch_new(drm_fd, 0, 0, 0);
+		if (lh.load == HIGH)
+			spin[1] = __igt_spin_batch_new(drm_fd, 0, 0, 0);
 		while (!lh.exit) {
-			if (spin[0]) {
-				handle = spin[0]->handle;
-				igt_spin_batch_end(spin[0]);
-				while (gem_bo_busy(drm_fd, handle))
-					usleep(100);
-				igt_spin_batch_free(drm_fd, spin[0]);
+			handle = spin[0]->handle;
+			igt_spin_batch_end(spin[0]);
+			while (gem_bo_busy(drm_fd, handle))
 				usleep(100);
-			}
+
+			igt_spin_batch_free(drm_fd, spin[0]);
+			usleep(100);
+
 			spin[0] = spin[1];
 			spin[lh.load == HIGH] =
-				igt_spin_batch_new(drm_fd, 0, 0, 0);
+				__igt_spin_batch_new(drm_fd, 0, 0, 0);
 		}
 
-		if (spin[0]) {
-			handle = spin[0]->handle;
-			igt_spin_batch_end(spin[0]);
-		}
+		handle = spin[0]->handle;
+		igt_spin_batch_end(spin[0]);
+
 		if (spin[1]) {
 			handle = spin[1]->handle;
 			igt_spin_batch_end(spin[1]);
-- 
2.15.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* ✓ Fi.CI.BAT: success for igt/pm_rps: Always allocate spin[0] (rev2)
  2017-12-11 12:37 [PATCH igt] igt/pm_rps: Always allocate spin[0] Chris Wilson
                   ` (4 preceding siblings ...)
  2017-12-19 12:34 ` [PATCH igt v2] " Chris Wilson
@ 2017-12-19 16:54 ` Patchwork
  2017-12-19 21:20 ` ✓ Fi.CI.IGT: " Patchwork
  6 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2017-12-19 16:54 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/pm_rps: Always allocate spin[0] (rev2)
URL   : https://patchwork.freedesktop.org/series/35176/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
da0889bfacff106fb3ecb7049a7a21f78b4b301b igt/kms_frontbuffer_tracking: Access via GGTT is not guaranteed to be tracked

with latest DRM-Tip kernel build CI_DRM_3549
cd7e14499b1d drm-tip: 2017y-12m-19d-15h-09m-52s UTC integration manifest

No testlist changes.

Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                pass       -> FAIL       (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> DMESG-WARN (fi-kbl-r) fdo#104172 +1
        Subgroup suspend-read-crc-pipe-b:
                pass       -> INCOMPLETE (fi-snb-2520m) fdo#103713
Test kms_psr_sink_crc:
        Subgroup psr_basic:
                dmesg-warn -> PASS       (fi-skl-6700hq) fdo#101144

fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:431s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:439s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:385s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:503s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:278s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:503s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:496s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:479s
fi-elk-e7500     total:224  pass:163  dwarn:15  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:178  dwarn:1   dfail:0   fail:1   skip:108 time:263s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:532s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:408s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:418s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:397s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:477s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:430s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:479s
fi-kbl-7560u     total:288  pass:268  dwarn:1   dfail:0   fail:0   skip:19  time:521s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:467s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:523s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:584s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:443s
fi-skl-6600u     total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:531s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:556s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:511s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:503s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:447s
fi-snb-2520m     total:245  pass:211  dwarn:0   dfail:0   fail:0   skip:33 
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:417s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:594s
fi-cnl-y         total:288  pass:260  dwarn:0   dfail:0   fail:2   skip:26  time:598s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_702/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* ✓ Fi.CI.IGT: success for igt/pm_rps: Always allocate spin[0] (rev2)
  2017-12-11 12:37 [PATCH igt] igt/pm_rps: Always allocate spin[0] Chris Wilson
                   ` (5 preceding siblings ...)
  2017-12-19 16:54 ` ✓ Fi.CI.BAT: success for igt/pm_rps: Always allocate spin[0] (rev2) Patchwork
@ 2017-12-19 21:20 ` Patchwork
  6 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2017-12-19 21:20 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/pm_rps: Always allocate spin[0] (rev2)
URL   : https://patchwork.freedesktop.org/series/35176/
State : success

== Summary ==

Warning: bzip IGTPW_702/shard-hsw6/results18.json.bz2 wasn't in correct JSON format
Test kms_flip:
        Subgroup vblank-vs-modeset-suspend:
                skip       -> PASS       (shard-snb) fdo#102365
        Subgroup flip-vs-modeset-vs-hang:
                pass       -> DMESG-WARN (shard-snb) fdo#103821
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
                pass       -> FAIL       (shard-snb) fdo#101623 +1
Test perf:
        Subgroup blocking:
                fail       -> PASS       (shard-hsw) fdo#102252
Test kms_atomic_transition:
        Subgroup 1x-modeset-transitions-nonblocking:
                skip       -> PASS       (shard-snb)
Test kms_draw_crc:
        Subgroup draw-method-xrgb2101010-mmap-gtt-untiled:
                skip       -> PASS       (shard-snb)
Test gem_eio:
        Subgroup in-flight:
                pass       -> DMESG-WARN (shard-snb) fdo#104058
Test kms_setmode:
        Subgroup basic:
                fail       -> PASS       (shard-hsw) fdo#99912
Test kms_busy:
        Subgroup extended-pageflip-hang-oldfb-render-b:
                skip       -> PASS       (shard-snb)

fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#103821 https://bugs.freedesktop.org/show_bug.cgi?id=103821
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#104058 https://bugs.freedesktop.org/show_bug.cgi?id=104058
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

shard-hsw        total:2636 pass:1498 dwarn:1   dfail:0   fail:9   skip:1128 time:9222s
shard-snb        total:2712 pass:1306 dwarn:3   dfail:0   fail:12  skip:1391 time:8153s
Blacklisted hosts:
shard-apl        total:2614 pass:1618 dwarn:2   dfail:0   fail:22  skip:971 time:13098s
shard-kbl        total:2705 pass:1799 dwarn:6   dfail:1   fail:23  skip:875 time:10751s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_702/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH igt v2] igt/pm_rps: Always allocate spin[0]
  2017-12-19 12:34 ` [PATCH igt v2] " Chris Wilson
@ 2017-12-20 10:12   ` Szwichtenberg, Radoslaw
  2017-12-20 11:06     ` Chris Wilson
  0 siblings, 1 reply; 11+ messages in thread
From: Szwichtenberg, Radoslaw @ 2017-12-20 10:12 UTC (permalink / raw)
  To: intel-gfx@lists.freedesktop.org, chris@chris-wilson.co.uk

On Tue, 2017-12-19 at 12:34 +0000, Chris Wilson wrote:
> Avoid having to test for spin[0] existing by starting the load-loop with
> it allocated.
> 
> v2: Preallocate the spin[1] as well for high load.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=104060
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Radoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH igt v2] igt/pm_rps: Always allocate spin[0]
  2017-12-20 10:12   ` Szwichtenberg, Radoslaw
@ 2017-12-20 11:06     ` Chris Wilson
  0 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2017-12-20 11:06 UTC (permalink / raw)
  To: Szwichtenberg, Radoslaw, intel-gfx@lists.freedesktop.org

Quoting Szwichtenberg, Radoslaw (2017-12-20 10:12:23)
> On Tue, 2017-12-19 at 12:34 +0000, Chris Wilson wrote:
> > Avoid having to test for spin[0] existing by starting the load-loop with
> > it allocated.
> > 
> > v2: Preallocate the spin[1] as well for high load.
> > 
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=104060
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Radoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>

Also marked it as Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104318
and pushed. Thanks,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-12-20 11:06 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-11 12:37 [PATCH igt] igt/pm_rps: Always allocate spin[0] Chris Wilson
2017-12-11 14:37 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-11 15:23 ` Patchwork
2017-12-11 16:18 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-12-19 12:05   ` Arkadiusz Hiler
2017-12-15 12:41 ` ✓ Fi.CI.BAT: success " Patchwork
2017-12-19 12:34 ` [PATCH igt v2] " Chris Wilson
2017-12-20 10:12   ` Szwichtenberg, Radoslaw
2017-12-20 11:06     ` Chris Wilson
2017-12-19 16:54 ` ✓ Fi.CI.BAT: success for igt/pm_rps: Always allocate spin[0] (rev2) Patchwork
2017-12-19 21:20 ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.