From: Zhang Rui <rui.zhang@intel.com>
To: Matthias Brugger <matthias.bgg@gmail.com>, edubezval@gmail.com
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH 1/2] thermal: mtk: Cleanup unused defines
Date: Thu, 21 Dec 2017 21:40:13 +0800 [thread overview]
Message-ID: <1513863613.2785.6.camel@intel.com> (raw)
In-Reply-To: <feb1e2bd-bee8-0950-7ecf-8e8c0e157f57@gmail.com>
On Thu, 2017-12-21 at 11:01 +0100, Matthias Brugger wrote:
>
> On 12/01/2017 11:43 AM, Matthias Brugger wrote:
> >
> > The mtk_thermal has some defiens which are never used within the
> > driver.
> > This patch delets them.
> >
> > Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> > ---
> Rui, Eduardo, do you have any comments on this patch?
>
No, I don't have any.
I suppose Eduardo will review them soon as I need the thermal soc
material for next merge window.
thanks,
rui
> Regards,
> Matthias
>
> >
> > drivers/thermal/mtk_thermal.c | 9 +--------
> > 1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/drivers/thermal/mtk_thermal.c
> > b/drivers/thermal/mtk_thermal.c
> > index 1e61c09153c9..c75661a3801a 100644
> > --- a/drivers/thermal/mtk_thermal.c
> > +++ b/drivers/thermal/mtk_thermal.c
> > @@ -32,15 +32,10 @@
> > #include <linux/types.h>
> >
> > /* AUXADC Registers */
> > -#define AUXADC_CON0_V 0x000
> > -#define AUXADC_CON1_V 0x004
> > #define AUXADC_CON1_SET_V 0x008
> > #define AUXADC_CON1_CLR_V 0x00c
> > #define AUXADC_CON2_V 0x010
> > #define AUXADC_DATA(channel) (0x14 + (channel) * 4)
> > -#define AUXADC_MISC_V 0x094
> > -
> > -#define AUXADC_CON1_CHANNEL(x) BIT(x)
> >
> > #define APMIXED_SYS_TS_CON1 0x604
> >
> > @@ -158,8 +153,6 @@
> > /* The number of sensing points per bank */
> > #define MT2712_NUM_SENSORS_PER_ZONE 4
> >
> > -#define THERMAL_NAME "mtk-thermal"
> > -
> > struct mtk_thermal;
> >
> > struct thermal_bank_cfg {
> > @@ -765,7 +758,7 @@ static struct platform_driver
> > mtk_thermal_driver = {
> > .probe = mtk_thermal_probe,
> > .remove = mtk_thermal_remove,
> > .driver = {
> > - .name = THERMAL_NAME,
> > + .name = "mtk-thermal",
> > .of_match_table = mtk_thermal_of_match,
> > },
> > };
> >
WARNING: multiple messages have this Message-ID (diff)
From: rui.zhang@intel.com (Zhang Rui)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] thermal: mtk: Cleanup unused defines
Date: Thu, 21 Dec 2017 21:40:13 +0800 [thread overview]
Message-ID: <1513863613.2785.6.camel@intel.com> (raw)
In-Reply-To: <feb1e2bd-bee8-0950-7ecf-8e8c0e157f57@gmail.com>
On Thu, 2017-12-21 at 11:01 +0100, Matthias Brugger wrote:
>
> On 12/01/2017 11:43 AM, Matthias Brugger wrote:
> >
> > The mtk_thermal has some defiens which are never used within the
> > driver.
> > This patch delets them.
> >
> > Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> > ---
> Rui, Eduardo, do you have any comments on this patch?
>
No, I don't have any.
I suppose Eduardo will review them soon as I need the thermal soc
material for next merge window.
thanks,
rui
> Regards,
> Matthias
>
> >
> > ?drivers/thermal/mtk_thermal.c | 9 +--------
> > ?1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/drivers/thermal/mtk_thermal.c
> > b/drivers/thermal/mtk_thermal.c
> > index 1e61c09153c9..c75661a3801a 100644
> > --- a/drivers/thermal/mtk_thermal.c
> > +++ b/drivers/thermal/mtk_thermal.c
> > @@ -32,15 +32,10 @@
> > ?#include <linux/types.h>
> > ?
> > ?/* AUXADC Registers */
> > -#define AUXADC_CON0_V 0x000
> > -#define AUXADC_CON1_V 0x004
> > ?#define AUXADC_CON1_SET_V 0x008
> > ?#define AUXADC_CON1_CLR_V 0x00c
> > ?#define AUXADC_CON2_V 0x010
> > ?#define AUXADC_DATA(channel) (0x14 + (channel) * 4)
> > -#define AUXADC_MISC_V 0x094
> > -
> > -#define AUXADC_CON1_CHANNEL(x) BIT(x)
> > ?
> > ?#define APMIXED_SYS_TS_CON1 0x604
> > ?
> > @@ -158,8 +153,6 @@
> > ?/* The number of sensing points per bank */
> > ?#define MT2712_NUM_SENSORS_PER_ZONE 4
> > ?
> > -#define THERMAL_NAME????"mtk-thermal"
> > -
> > ?struct mtk_thermal;
> > ?
> > ?struct thermal_bank_cfg {
> > @@ -765,7 +758,7 @@ static struct platform_driver
> > mtk_thermal_driver = {
> > ? .probe = mtk_thermal_probe,
> > ? .remove = mtk_thermal_remove,
> > ? .driver = {
> > - .name = THERMAL_NAME,
> > + .name = "mtk-thermal",
> > ? .of_match_table = mtk_thermal_of_match,
> > ? },
> > ?};
> >
next prev parent reply other threads:[~2017-12-21 13:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 10:43 [PATCH 1/2] thermal: mtk: Cleanup unused defines Matthias Brugger
2017-12-01 10:43 ` Matthias Brugger
2017-12-14 11:21 ` Matthias Brugger
2017-12-14 11:21 ` Matthias Brugger
2017-12-14 11:26 ` Daniel Lezcano
2017-12-14 11:26 ` Daniel Lezcano
2017-12-21 10:01 ` Matthias Brugger
2017-12-21 10:01 ` Matthias Brugger
2017-12-21 13:40 ` Zhang Rui [this message]
2017-12-21 13:40 ` Zhang Rui
2018-01-01 19:56 ` Eduardo Valentin
2018-01-01 19:56 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513863613.2785.6.camel@intel.com \
--to=rui.zhang@intel.com \
--cc=edubezval@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mbrugger@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.