* [PATCH] virt: vbox: use %pR format for printing resource_size_t
@ 2017-12-21 14:59 Arnd Bergmann
2017-12-21 15:42 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2017-12-21 14:59 UTC (permalink / raw)
To: Hans de Goede, Arnd Bergmann, Greg Kroah-Hartman
Cc: Larry Finger, linux-kernel
resource_size_t may be larger than pointers depending on configuration,
so we can run into this build warning:
drivers/virt/vboxguest/vboxguest_linux.c: In function 'vbg_pci_probe':
drivers/virt/vboxguest/vboxguest_linux.c:295:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
drivers/virt/vboxguest/vboxguest_linux.c:367:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
This uses the special %pR to print the address by reference.
Fixes: 0ba002bc4393 ("virt: Add vboxguest driver for Virtual Box Guest integration")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/virt/vboxguest/vboxguest_linux.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c
index d045aa51ce03..1074ff59721e 100644
--- a/drivers/virt/vboxguest/vboxguest_linux.c
+++ b/drivers/virt/vboxguest/vboxguest_linux.c
@@ -291,8 +291,8 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
vmmdev = devm_ioremap(dev, mmio, mmio_len);
if (!vmmdev) {
- vbg_err("vboxguest: Error ioremap failed; MMIO addr=%p size=%d\n",
- (void *)mmio, (int)mmio_len);
+ vbg_err("vboxguest: Error ioremap failed; MMIO addr=%pR size=%pR\n",
+ &mmio, &mmio_len);
goto err_disable_pcidev;
}
@@ -362,9 +362,9 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
device_create_file(dev, &dev_attr_host_version);
device_create_file(dev, &dev_attr_host_features);
- vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %p (size %d)\n",
+ vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %pR (size %pR)\n",
gdev->misc_device.minor, pci->irq, gdev->io_port,
- (void *)mmio, (int)mmio_len);
+ &mmio, &mmio_len);
return 0;
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] virt: vbox: use %pR format for printing resource_size_t
2017-12-21 14:59 [PATCH] virt: vbox: use %pR format for printing resource_size_t Arnd Bergmann
@ 2017-12-21 15:42 ` Joe Perches
2017-12-21 15:46 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2017-12-21 15:42 UTC (permalink / raw)
To: Arnd Bergmann, Hans de Goede, Greg Kroah-Hartman
Cc: Larry Finger, linux-kernel
On Thu, 2017-12-21 at 15:59 +0100, Arnd Bergmann wrote:
> resource_size_t may be larger than pointers depending on configuration,
> so we can run into this build warning:
nak.
struct resource is different than resource_size_t
> drivers/virt/vboxguest/vboxguest_linux.c: In function 'vbg_pci_probe':
> drivers/virt/vboxguest/vboxguest_linux.c:295:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> drivers/virt/vboxguest/vboxguest_linux.c:367:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>
> This uses the special %pR to print the address by reference.
>
> Fixes: 0ba002bc4393 ("virt: Add vboxguest driver for Virtual Box Guest integration")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/virt/vboxguest/vboxguest_linux.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c
> index d045aa51ce03..1074ff59721e 100644
> --- a/drivers/virt/vboxguest/vboxguest_linux.c
> +++ b/drivers/virt/vboxguest/vboxguest_linux.c
> @@ -291,8 +291,8 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
>
> vmmdev = devm_ioremap(dev, mmio, mmio_len);
> if (!vmmdev) {
> - vbg_err("vboxguest: Error ioremap failed; MMIO addr=%p size=%d\n",
> - (void *)mmio, (int)mmio_len);
> + vbg_err("vboxguest: Error ioremap failed; MMIO addr=%pR size=%pR\n",
> + &mmio, &mmio_len);
> goto err_disable_pcidev;
> }
>
> @@ -362,9 +362,9 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
> device_create_file(dev, &dev_attr_host_version);
> device_create_file(dev, &dev_attr_host_features);
>
> - vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %p (size %d)\n",
> + vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %pR (size %pR)\n",
> gdev->misc_device.minor, pci->irq, gdev->io_port,
> - (void *)mmio, (int)mmio_len);
> + &mmio, &mmio_len);
>
> return 0;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virt: vbox: use %pR format for printing resource_size_t
2017-12-21 15:42 ` Joe Perches
@ 2017-12-21 15:46 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-12-21 15:46 UTC (permalink / raw)
To: Joe Perches
Cc: Hans de Goede, Greg Kroah-Hartman, Larry Finger,
Linux Kernel Mailing List
On Thu, Dec 21, 2017 at 4:42 PM, Joe Perches <joe@perches.com> wrote:
> On Thu, 2017-12-21 at 15:59 +0100, Arnd Bergmann wrote:
>> resource_size_t may be larger than pointers depending on configuration,
>> so we can run into this build warning:
>
> nak.
>
> struct resource is different than resource_size_t
Ouch, thanks for catching this!
It should have been %pap of course.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-21 15:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-21 14:59 [PATCH] virt: vbox: use %pR format for printing resource_size_t Arnd Bergmann
2017-12-21 15:42 ` Joe Perches
2017-12-21 15:46 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.