All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Show FBC worker status in debugfs
@ 2017-12-20 20:58 Chris Wilson
  2017-12-20 21:31 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2017-12-20 20:58 UTC (permalink / raw)
  To: intel-gfx; +Cc: Paulo Zanoni

Include the pending update from the FBC worker in i915_fbc_status.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index c4780f085428..931037a458be 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -1581,18 +1581,23 @@ static int i915_frontbuffer_tracking(struct seq_file *m, void *unused)
 static int i915_fbc_status(struct seq_file *m, void *unused)
 {
 	struct drm_i915_private *dev_priv = node_to_i915(m->private);
+	struct intel_fbc *fbc = &dev_priv->fbc;
 
 	if (!HAS_FBC(dev_priv))
 		return -ENODEV;
 
 	intel_runtime_pm_get(dev_priv);
-	mutex_lock(&dev_priv->fbc.lock);
+	mutex_lock(&fbc->lock);
 
 	if (intel_fbc_is_active(dev_priv))
 		seq_puts(m, "FBC enabled\n");
 	else
-		seq_printf(m, "FBC disabled: %s\n",
-			   dev_priv->fbc.no_fbc_reason);
+		seq_printf(m, "FBC disabled: %s\n", fbc->no_fbc_reason);
+
+	if (fbc->work.scheduled)
+		seq_printf(m, "FBC worker scheduled on vblank %d, now %llu\n",
+			   fbc->work.scheduled_vblank,
+			   drm_crtc_vblank_count(&fbc->crtc->base));
 
 	if (intel_fbc_is_active(dev_priv)) {
 		u32 mask;
@@ -1612,7 +1617,7 @@ static int i915_fbc_status(struct seq_file *m, void *unused)
 		seq_printf(m, "Compressing: %s\n", yesno(mask));
 	}
 
-	mutex_unlock(&dev_priv->fbc.lock);
+	mutex_unlock(&fbc->lock);
 	intel_runtime_pm_put(dev_priv);
 
 	return 0;
-- 
2.15.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Show FBC worker status in debugfs
  2017-12-20 20:58 [PATCH] drm/i915: Show FBC worker status in debugfs Chris Wilson
@ 2017-12-20 21:31 ` Patchwork
  2017-12-20 22:52 ` ✗ Fi.CI.IGT: warning " Patchwork
  2017-12-21 17:20 ` [PATCH] " Paulo Zanoni
  2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-12-20 21:31 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Show FBC worker status in debugfs
URL   : https://patchwork.freedesktop.org/series/35646/
State : success

== Summary ==

Series 35646v1 drm/i915: Show FBC worker status in debugfs
https://patchwork.freedesktop.org/api/1.0/series/35646/revisions/1/mbox/

Test debugfs_test:
        Subgroup read_all_entries:
                dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> DMESG-WARN (fi-kbl-r) fdo#104172 +1
        Subgroup suspend-read-crc-pipe-b:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713
Test kms_psr_sink_crc:
        Subgroup psr_basic:
                pass       -> DMESG-WARN (fi-skl-6700hq) fdo#101144

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:433s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:440s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:385s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:501s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:277s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:495s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:502s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:480s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:470s
fi-elk-e7500     total:224  pass:163  dwarn:14  dfail:1   fail:0   skip:45 
fi-gdg-551       total:288  pass:178  dwarn:1   dfail:0   fail:1   skip:108 time:260s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:533s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:406s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:414s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:396s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:477s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:432s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:478s
fi-kbl-7560u     total:288  pass:268  dwarn:1   dfail:0   fail:0   skip:19  time:516s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:471s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:521s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:581s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:445s
fi-skl-6600u     total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:531s
fi-skl-6700hq    total:288  pass:261  dwarn:1   dfail:0   fail:0   skip:26  time:555s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:506s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:508s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:446s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:551s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:415s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:589s
fi-cnl-y         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:630s

16c40c33a5ea1777e50496fd6e19c7011a939c01 drm-tip: 2017y-12m-20d-19h-24m-38s UTC integration manifest
8e88148936f4 drm/i915: Show FBC worker status in debugfs

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7552/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* ✗ Fi.CI.IGT: warning for drm/i915: Show FBC worker status in debugfs
  2017-12-20 20:58 [PATCH] drm/i915: Show FBC worker status in debugfs Chris Wilson
  2017-12-20 21:31 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-12-20 22:52 ` Patchwork
  2017-12-21 17:20 ` [PATCH] " Paulo Zanoni
  2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-12-20 22:52 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Show FBC worker status in debugfs
URL   : https://patchwork.freedesktop.org/series/35646/
State : warning

== Summary ==

Test gem_softpin:
        Subgroup noreloc-s4:
                fail       -> SKIP       (shard-snb) fdo#103375
        Subgroup noreloc-s3:
                skip       -> PASS       (shard-hsw) fdo#103540
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
                fail       -> PASS       (shard-snb) fdo#101623 +1
Test kms_flip:
        Subgroup wf_vblank-vs-modeset:
                dmesg-warn -> PASS       (shard-hsw) fdo#102614
        Subgroup blocking-absolute-wf_vblank-interruptible:
                pass       -> SKIP       (shard-hsw)
Test drv_suspend:
        Subgroup sysfs-reader:
                skip       -> PASS       (shard-snb)
Test kms_universal_plane:
        Subgroup universal-plane-pipe-c-sanity:
                skip       -> PASS       (shard-hsw)
Test perf:
        Subgroup polling:
                pass       -> FAIL       (shard-hsw) fdo#102252

fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252

shard-hsw        total:2712 pass:1534 dwarn:1   dfail:0   fail:11  skip:1166 time:9368s
shard-snb        total:2712 pass:1310 dwarn:1   dfail:0   fail:9   skip:1392 time:8039s
Blacklisted hosts:
shard-kbl        total:2699 pass:1800 dwarn:1   dfail:0   fail:24  skip:873 time:10520s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7552/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Show FBC worker status in debugfs
  2017-12-20 20:58 [PATCH] drm/i915: Show FBC worker status in debugfs Chris Wilson
  2017-12-20 21:31 ` ✓ Fi.CI.BAT: success for " Patchwork
  2017-12-20 22:52 ` ✗ Fi.CI.IGT: warning " Patchwork
@ 2017-12-21 17:20 ` Paulo Zanoni
  2017-12-21 17:36   ` Chris Wilson
  2 siblings, 1 reply; 5+ messages in thread
From: Paulo Zanoni @ 2017-12-21 17:20 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx

Em Qua, 2017-12-20 às 20:58 +0000, Chris Wilson escreveu:
> Include the pending update from the FBC worker in i915_fbc_status.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> b/drivers/gpu/drm/i915/i915_debugfs.c
> index c4780f085428..931037a458be 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1581,18 +1581,23 @@ static int i915_frontbuffer_tracking(struct
> seq_file *m, void *unused)
>  static int i915_fbc_status(struct seq_file *m, void *unused)
>  {
>  	struct drm_i915_private *dev_priv = node_to_i915(m-
> >private);
> +	struct intel_fbc *fbc = &dev_priv->fbc;
>  
>  	if (!HAS_FBC(dev_priv))
>  		return -ENODEV;
>  
>  	intel_runtime_pm_get(dev_priv);
> -	mutex_lock(&dev_priv->fbc.lock);
> +	mutex_lock(&fbc->lock);
>  
>  	if (intel_fbc_is_active(dev_priv))
>  		seq_puts(m, "FBC enabled\n");
>  	else
> -		seq_printf(m, "FBC disabled: %s\n",
> -			   dev_priv->fbc.no_fbc_reason);
> +		seq_printf(m, "FBC disabled: %s\n", fbc-
> >no_fbc_reason);
> +
> +	if (fbc->work.scheduled)
> +		seq_printf(m, "FBC worker scheduled on vblank %d, 

vblank %u since this is u32?

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> now %llu\n",
> +			   fbc->work.scheduled_vblank,
> +			   drm_crtc_vblank_count(&fbc->crtc->base));
>  
>  	if (intel_fbc_is_active(dev_priv)) {
>  		u32 mask;
> @@ -1612,7 +1617,7 @@ static int i915_fbc_status(struct seq_file *m,
> void *unused)
>  		seq_printf(m, "Compressing: %s\n", yesno(mask));
>  	}
>  
> -	mutex_unlock(&dev_priv->fbc.lock);
> +	mutex_unlock(&fbc->lock);
>  	intel_runtime_pm_put(dev_priv);
>  
>  	return 0;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Show FBC worker status in debugfs
  2017-12-21 17:20 ` [PATCH] " Paulo Zanoni
@ 2017-12-21 17:36   ` Chris Wilson
  0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2017-12-21 17:36 UTC (permalink / raw)
  To: Paulo Zanoni, intel-gfx

Quoting Paulo Zanoni (2017-12-21 17:20:50)
> Em Qua, 2017-12-20 às 20:58 +0000, Chris Wilson escreveu:
> > Include the pending update from the FBC worker in i915_fbc_status.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_debugfs.c | 13 +++++++++----
> >  1 file changed, 9 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> > b/drivers/gpu/drm/i915/i915_debugfs.c
> > index c4780f085428..931037a458be 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -1581,18 +1581,23 @@ static int i915_frontbuffer_tracking(struct
> > seq_file *m, void *unused)
> >  static int i915_fbc_status(struct seq_file *m, void *unused)
> >  {
> >       struct drm_i915_private *dev_priv = node_to_i915(m-
> > >private);
> > +     struct intel_fbc *fbc = &dev_priv->fbc;
> >  
> >       if (!HAS_FBC(dev_priv))
> >               return -ENODEV;
> >  
> >       intel_runtime_pm_get(dev_priv);
> > -     mutex_lock(&dev_priv->fbc.lock);
> > +     mutex_lock(&fbc->lock);
> >  
> >       if (intel_fbc_is_active(dev_priv))
> >               seq_puts(m, "FBC enabled\n");
> >       else
> > -             seq_printf(m, "FBC disabled: %s\n",
> > -                        dev_priv->fbc.no_fbc_reason);
> > +             seq_printf(m, "FBC disabled: %s\n", fbc-
> > >no_fbc_reason);
> > +
> > +     if (fbc->work.scheduled)
> > +             seq_printf(m, "FBC worker scheduled on vblank %d, 
> 
> vblank %u since this is u32?
> 
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Deal. Thanks,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-21 17:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-20 20:58 [PATCH] drm/i915: Show FBC worker status in debugfs Chris Wilson
2017-12-20 21:31 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-20 22:52 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-12-21 17:20 ` [PATCH] " Paulo Zanoni
2017-12-21 17:36   ` Chris Wilson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.