All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Roberto Sassu <roberto.sassu@huawei.com>,
	James Morris <jmorris@namei.org>
Cc: linux-security-module <linux-security-module@vger.kernel.org>,
	linux-integrity <linux-integrity@vger.kernel.org>
Subject: Re: [GIT PULL] linux-integrity patches for 4.16-security-next-general
Date: Fri, 05 Jan 2018 09:59:57 -0500	[thread overview]
Message-ID: <1515164397.4418.11.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <4806797a-bb15-6996-6654-7e21d39b7699@huawei.com>

Hi Roberto,

On Fri, 2018-01-05 at 15:55 +0100, Roberto Sassu wrote:
> On 1/5/2018 2:43 PM, Mimi Zohar wrote:
> > Hi James,
> > 
> > Mimi Zohar (2):
> >        ima: relax requiring a file signature for new files with zero length
> >        ima: support new "hash" and "dont_hash" policy actions
> Hi Mimi
> 
> I think there is an issue in the patch above.
> 
> +	/* HASH just sets the digital signature flag, nothing else */
> +	if ((action & IMA_HASH) && !(iint->flags & IMA_DIGSIG)) {
> 
> IMA_DIGSIG now is an atomic flag.

Yes, this caused me grief, but is fixed in next-integrity branch.

Mimi

WARNING: multiple messages have this Message-ID (diff)
From: zohar@linux.vnet.ibm.com (Mimi Zohar)
To: linux-security-module@vger.kernel.org
Subject: [GIT PULL] linux-integrity patches for 4.16-security-next-general
Date: Fri, 05 Jan 2018 09:59:57 -0500	[thread overview]
Message-ID: <1515164397.4418.11.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <4806797a-bb15-6996-6654-7e21d39b7699@huawei.com>

Hi Roberto,

On Fri, 2018-01-05 at 15:55 +0100, Roberto Sassu wrote:
> On 1/5/2018 2:43 PM, Mimi Zohar wrote:
> > Hi James,
> > 
> > Mimi Zohar (2):
> >        ima: relax requiring a file signature for new files with zero length
> >        ima: support new "hash" and "dont_hash" policy actions
> Hi Mimi
> 
> I think there is an issue in the patch above.
> 
> +	/* HASH just sets the digital signature flag, nothing else */
> +	if ((action & IMA_HASH) && !(iint->flags & IMA_DIGSIG)) {
> 
> IMA_DIGSIG now is an atomic flag.

Yes, this caused me grief, but is fixed in next-integrity branch.

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-01-05 15:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-05 13:43 [GIT PULL] linux-integrity patches for 4.16-security-next-general Mimi Zohar
2018-01-05 13:43 ` Mimi Zohar
2018-01-05 14:55 ` Roberto Sassu
2018-01-05 14:55   ` Roberto Sassu
2018-01-05 14:59   ` Mimi Zohar [this message]
2018-01-05 14:59     ` Mimi Zohar
2018-01-05 15:04     ` Roberto Sassu
2018-01-05 15:04       ` Roberto Sassu
2018-01-08  0:04 ` James Morris
2018-01-08  0:04   ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1515164397.4418.11.camel@linux.vnet.ibm.com \
    --to=zohar@linux.vnet.ibm.com \
    --cc=jmorris@namei.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=roberto.sassu@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.