From: Joe Perches <joe@perches.com>
To: Jonathan Cameron <jic23@kernel.org>,
George Edward Bulmer <gebulmer@googlemail.com>
Cc: gregkh@linuxfoundation.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, masneyb@onstation.org,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: light: Add breaks to lengthy lines
Date: Sun, 07 Jan 2018 08:42:27 -0800 [thread overview]
Message-ID: <1515343347.8292.1.camel@perches.com> (raw)
In-Reply-To: <20180107162848.37108f96@archlinux>
On Sun, 2018-01-07 at 16:28 +0000, Jonathan Cameron wrote:
> On Sun, 7 Jan 2018 15:08:01 +0000
> George Edward Bulmer <gebulmer@googlemail.com> wrote:
>
> > This fixes three instances of checkpatch warning:
> > WARNING: line over 80 characters
> >
> > Signed-off-by: George Edward Bulmer <gebulmer@googlemail.com>
>
> Applied, thanks,
I believe these are examples of long line conversions
that should not be applied.
Most of the problem here is the very long identifier naming.
57 character identifiers are pretty unnecessary.
> Jonathan
> > ---
> > drivers/staging/iio/light/tsl2x7x.c | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/iio/light/tsl2x7x.c b/drivers/staging/iio/light/tsl2x7x.c
> > index 42ed9c015aaf..126e11530ce0 100644
> > --- a/drivers/staging/iio/light/tsl2x7x.c
> > +++ b/drivers/staging/iio/light/tsl2x7x.c
> > @@ -1441,7 +1441,8 @@ static irqreturn_t tsl2x7x_event_handler(int irq, void *private)
> >
> > static struct attribute *tsl2x7x_ALS_device_attrs[] = {
> > &dev_attr_in_illuminance0_calibscale_available.attr,
> > - &iio_const_attr_in_illuminance0_integration_time_available.dev_attr.attr,
> > + &iio_const_attr_in_illuminance0_integration_time_available
> > + .dev_attr.attr,
> > &dev_attr_in_illuminance0_target_input.attr,
> > &dev_attr_in_illuminance0_calibrate.attr,
> > &dev_attr_in_illuminance0_lux_table.attr,
> > @@ -1455,7 +1456,8 @@ static struct attribute *tsl2x7x_PRX_device_attrs[] = {
> >
> > static struct attribute *tsl2x7x_ALSPRX_device_attrs[] = {
> > &dev_attr_in_illuminance0_calibscale_available.attr,
> > - &iio_const_attr_in_illuminance0_integration_time_available.dev_attr.attr,
> > + &iio_const_attr_in_illuminance0_integration_time_available
> > + .dev_attr.attr,
> > &dev_attr_in_illuminance0_target_input.attr,
> > &dev_attr_in_illuminance0_calibrate.attr,
> > &dev_attr_in_illuminance0_lux_table.attr,
> > @@ -1471,7 +1473,8 @@ static struct attribute *tsl2x7x_PRX2_device_attrs[] = {
> >
> > static struct attribute *tsl2x7x_ALSPRX2_device_attrs[] = {
> > &dev_attr_in_illuminance0_calibscale_available.attr,
> > - &iio_const_attr_in_illuminance0_integration_time_available.dev_attr.attr,
> > + &iio_const_attr_in_illuminance0_integration_time_available
> > + .dev_attr.attr,
> > &dev_attr_in_illuminance0_target_input.attr,
> > &dev_attr_in_illuminance0_calibrate.attr,
> > &dev_attr_in_illuminance0_lux_table.attr,
>
>
next prev parent reply other threads:[~2018-01-07 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-07 15:08 [PATCH] staging: iio: light: Add breaks to lengthy lines George Edward Bulmer
2018-01-07 16:28 ` Jonathan Cameron
2018-01-07 16:42 ` Joe Perches [this message]
2018-01-07 17:17 ` Jonathan Cameron
2018-01-08 12:02 ` Dan Carpenter
2018-01-08 14:59 ` Joe Perches
2018-01-08 11:48 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515343347.8292.1.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gebulmer@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.