From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: devel@driverdev.osuosl.org, lars@metafoo.de,
linux-iio@vger.kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, pmeerw@pmeerw.net,
knaack.h@gmx.de, George Edward Bulmer <gebulmer@googlemail.com>
Subject: Re: [PATCH] staging: iio: light: Add breaks to lengthy lines
Date: Mon, 08 Jan 2018 06:59:37 -0800 [thread overview]
Message-ID: <1515423577.9619.22.camel@perches.com> (raw)
In-Reply-To: <20180108120210.fqh7of2e5tv5242j@mwanda>
On Mon, 2018-01-08 at 15:02 +0300, Dan Carpenter wrote:
> On Sun, Jan 07, 2018 at 05:17:42PM +0000, Jonathan Cameron wrote:
> > On Sun, 07 Jan 2018 08:42:27 -0800
> > Joe Perches <joe@perches.com> wrote:
> >
> > > On Sun, 2018-01-07 at 16:28 +0000, Jonathan Cameron wrote:
> > > > On Sun, 7 Jan 2018 15:08:01 +0000
> > > > George Edward Bulmer <gebulmer@googlemail.com> wrote:
> > > >
> > > > > This fixes three instances of checkpatch warning:
> > > > > WARNING: line over 80 characters
> > > > >
> > > > > Signed-off-by: George Edward Bulmer <gebulmer@googlemail.com>
> > > >
> > > > Applied, thanks,
> > >
> > > I believe these are examples of long line conversions
> > > that should not be applied.
> >
> > On this one I disagree. The line breaks don't hurt readability
> > so aren't a problem. The benefit is admittedly small, however
> > we are adding churn in a fairly safe place - this stuff rarely
> > changes.
>
> They do hurt read
> ability.
>
> Checkpatch.pl should maybe have a special case to not complain if the
> last variable in the line is over 40 characters long. I didn't
> realize that we had LONG_LINE_COMMENT. Does that mean we don't complain
> if comment goes over 80 characters?
No. It's just an extra classifier.
It means that long lines with comments that
exceed 80 columns can be ignored by using the
command line argument
--ignore=long_line_comment
next prev parent reply other threads:[~2018-01-08 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-07 15:08 [PATCH] staging: iio: light: Add breaks to lengthy lines George Edward Bulmer
2018-01-07 16:28 ` Jonathan Cameron
2018-01-07 16:42 ` Joe Perches
2018-01-07 17:17 ` Jonathan Cameron
2018-01-08 12:02 ` Dan Carpenter
2018-01-08 14:59 ` Joe Perches [this message]
2018-01-08 11:48 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515423577.9619.22.camel@perches.com \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gebulmer@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.