From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 2/5] ARM64: dts: meson-axg: uart: drop legacy compatible name from EE UART
Date: Mon, 08 Jan 2018 09:56:42 +0100 [thread overview]
Message-ID: <1515401802.5048.71.camel@baylibre.com> (raw)
In-Reply-To: <20180106001044.108163-3-yixun.lan@amlogic.com>
On Sat, 2018-01-06 at 08:10 +0800, Yixun Lan wrote:
> When update the clock info for the UART controller in the EE domain,
> the driver explicitly require 'pclk' in order to work properly.
>
> With current logic of the code, the driver will go for the legacy clock probe
> routine[1] if it find current compatible string match to 'amlogic,meson-uart',
> which result in not requesting the 'pclk' clock, thus break the driver in the end.
>
> [1] drivers/tty/serial/meson_uart.c:685
>
> /* Use legacy way until all platforms switch to new bindings */
> if (of_device_is_compatible(pdev->dev.of_node, "amlogic,meson-uart"))
> ret = meson_uart_probe_clocks_legacy(pdev, port);
> else
> ret = meson_uart_probe_clocks(pdev, port);
I don't think you should add this code snip here. Anybody can look at the driver
code to see that
>
> Acked-by: Jerome Brunet <jbrunet@baylibre.com>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] ARM64: dts: meson-axg: uart: drop legacy compatible name from EE UART
Date: Mon, 08 Jan 2018 09:56:42 +0100 [thread overview]
Message-ID: <1515401802.5048.71.camel@baylibre.com> (raw)
In-Reply-To: <20180106001044.108163-3-yixun.lan@amlogic.com>
On Sat, 2018-01-06 at 08:10 +0800, Yixun Lan wrote:
> When update the clock info for the UART controller in the EE domain,
> the driver explicitly require 'pclk' in order to work properly.
>
> With current logic of the code, the driver will go for the legacy clock probe
> routine[1] if it find current compatible string match to 'amlogic,meson-uart',
> which result in not requesting the 'pclk' clock, thus break the driver in the end.
>
> [1] drivers/tty/serial/meson_uart.c:685
>
> /* Use legacy way until all platforms switch to new bindings */
> if (of_device_is_compatible(pdev->dev.of_node, "amlogic,meson-uart"))
> ret = meson_uart_probe_clocks_legacy(pdev, port);
> else
> ret = meson_uart_probe_clocks(pdev, port);
I don't think you should add this code snip here. Anybody can look at the driver
code to see that
>
> Acked-by: Jerome Brunet <jbrunet@baylibre.com>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
To: Yixun Lan <yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>,
Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Neil Armstrong
<narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>,
linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 2/5] ARM64: dts: meson-axg: uart: drop legacy compatible name from EE UART
Date: Mon, 08 Jan 2018 09:56:42 +0100 [thread overview]
Message-ID: <1515401802.5048.71.camel@baylibre.com> (raw)
In-Reply-To: <20180106001044.108163-3-yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
On Sat, 2018-01-06 at 08:10 +0800, Yixun Lan wrote:
> When update the clock info for the UART controller in the EE domain,
> the driver explicitly require 'pclk' in order to work properly.
>
> With current logic of the code, the driver will go for the legacy clock probe
> routine[1] if it find current compatible string match to 'amlogic,meson-uart',
> which result in not requesting the 'pclk' clock, thus break the driver in the end.
>
> [1] drivers/tty/serial/meson_uart.c:685
>
> /* Use legacy way until all platforms switch to new bindings */
> if (of_device_is_compatible(pdev->dev.of_node, "amlogic,meson-uart"))
> ret = meson_uart_probe_clocks_legacy(pdev, port);
> else
> ret = meson_uart_probe_clocks(pdev, port);
I don't think you should add this code snip here. Anybody can look at the driver
code to see that
>
> Acked-by: Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Yixun Lan <yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Yixun Lan <yixun.lan@amlogic.com>,
Kevin Hilman <khilman@baylibre.com>,
devicetree@vger.kernel.org
Cc: Neil Armstrong <narmstrong@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] ARM64: dts: meson-axg: uart: drop legacy compatible name from EE UART
Date: Mon, 08 Jan 2018 09:56:42 +0100 [thread overview]
Message-ID: <1515401802.5048.71.camel@baylibre.com> (raw)
In-Reply-To: <20180106001044.108163-3-yixun.lan@amlogic.com>
On Sat, 2018-01-06 at 08:10 +0800, Yixun Lan wrote:
> When update the clock info for the UART controller in the EE domain,
> the driver explicitly require 'pclk' in order to work properly.
>
> With current logic of the code, the driver will go for the legacy clock probe
> routine[1] if it find current compatible string match to 'amlogic,meson-uart',
> which result in not requesting the 'pclk' clock, thus break the driver in the end.
>
> [1] drivers/tty/serial/meson_uart.c:685
>
> /* Use legacy way until all platforms switch to new bindings */
> if (of_device_is_compatible(pdev->dev.of_node, "amlogic,meson-uart"))
> ret = meson_uart_probe_clocks_legacy(pdev, port);
> else
> ret = meson_uart_probe_clocks(pdev, port);
I don't think you should add this code snip here. Anybody can look at the driver
code to see that
>
> Acked-by: Jerome Brunet <jbrunet@baylibre.com>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
next prev parent reply other threads:[~2018-01-08 8:56 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 0:10 [PATCH v2 0/5] ARM64: dts: meson-axg: UART DT updates Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-06 0:10 ` [PATCH v2 1/5] ARM64: dts: meson: uart: fix address space range Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-08 8:54 ` Jerome Brunet
2018-01-08 8:54 ` Jerome Brunet
2018-01-08 8:54 ` Jerome Brunet
[not found] ` <1515401694.5048.69.camel-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2018-01-17 0:01 ` Kevin Hilman
2018-01-17 0:01 ` Kevin Hilman
2018-01-06 0:10 ` [PATCH v2 2/5] ARM64: dts: meson-axg: uart: drop legacy compatible name from EE UART Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-08 8:56 ` Jerome Brunet [this message]
2018-01-08 8:56 ` Jerome Brunet
2018-01-08 8:56 ` Jerome Brunet
2018-01-08 8:56 ` Jerome Brunet
2018-01-06 0:10 ` [PATCH v2 3/5] ARM64: dts: meson-axg: uart: Add the pinctrl info description Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-07 20:19 ` Martin Blumenstingl
2018-01-07 20:19 ` Martin Blumenstingl
2018-01-07 20:19 ` Martin Blumenstingl
2018-01-07 20:19 ` Martin Blumenstingl
2018-01-08 6:07 ` Yixun Lan
2018-01-08 6:07 ` Yixun Lan
2018-01-08 6:07 ` Yixun Lan
2018-01-08 6:07 ` Yixun Lan
2018-01-08 6:44 ` Yixun Lan
2018-01-08 6:44 ` Yixun Lan
2018-01-08 6:44 ` Yixun Lan
2018-01-08 6:44 ` Yixun Lan
2018-01-08 8:42 ` Jerome Brunet
2018-01-08 8:42 ` Jerome Brunet
2018-01-08 8:42 ` Jerome Brunet
2018-01-08 8:42 ` Jerome Brunet
2018-01-06 0:10 ` [PATCH v2 4/5] ARM64: dts: meson-axg: complete the pinctrl info for UART_AO_A Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-06 0:10 ` [PATCH v2 5/5] ARM64: dts: meson-axg: enable the UART_A controller Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-06 0:10 ` Yixun Lan
2018-01-06 0:10 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515401802.5048.71.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.