All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Sohil Mehta <sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
	Alex Williamson
	<alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Ravi V Shankar
	<ravi.v.shankar-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Fenghua Yu <fenghua.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Gayatri Kammela
	<gayatri.kammela-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v6 3/5] iommu/vt-d: Add debugfs support to show register contents
Date: Wed, 10 Jan 2018 15:35:39 +0200	[thread overview]
Message-ID: <1515591339.7000.863.camel@linux.intel.com> (raw)
In-Reply-To: <1515556102-34150-4-git-send-email-sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On Tue, 2018-01-09 at 19:48 -0800, Sohil Mehta wrote:

> Debugfs extension to dump all the register contents for each IOMMU
> device to the user space via debugfs.
> 
> example:
> root@OTC-KBLH-01:~# cat /sys/kernel/debug/intel_iommu/iommu_regset
> 
> DMAR: dmar1: reg_base_addr fed90000
> Name         Offset     Contents
> VER          0x00       0x0000000000000010
> CAP          0x08       0x01c0000c40660462
> ECAP         0x10       0x0000019e2ff0505e
> GCMD         0x18       0x0000000000000000
> GSTS         0x1c       0x00000000c7000000
> RTADDR       0x20       0x00000004558d6800
> CCMD         0x28       0x0800000000000000
> FSTS         0x34       0x0000000000000000
> FECTL        0x38       0x0000000000000000
> FEDATA       0x3c       0xfee0100c00004141

> +		seq_printf(m, "\nDMAR: %s: reg_base_addr %llx\n",
> iommu->name,
> +			   base);

Can we get rid of leading '\n'?

-- 
Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Intel Finland Oy

WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sohil Mehta <sohil.mehta@intel.com>,
	Joerg Roedel <joro@8bytes.org>,
	Alex Williamson <alex.williamson@redhat.com>
Cc: Ashok Raj <ashok.raj@intel.com>,
	David Woodhouse <dwmw2@infradead.org>,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	Jacob Pan <jacob.jun.pan@linux.intel.com>,
	Gayatri Kammela <gayatri.kammela@intel.com>,
	Ravi V Shankar <ravi.v.shankar@intel.com>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH v6 3/5] iommu/vt-d: Add debugfs support to show register contents
Date: Wed, 10 Jan 2018 15:35:39 +0200	[thread overview]
Message-ID: <1515591339.7000.863.camel@linux.intel.com> (raw)
In-Reply-To: <1515556102-34150-4-git-send-email-sohil.mehta@intel.com>

On Tue, 2018-01-09 at 19:48 -0800, Sohil Mehta wrote:

> Debugfs extension to dump all the register contents for each IOMMU
> device to the user space via debugfs.
> 
> example:
> root@OTC-KBLH-01:~# cat /sys/kernel/debug/intel_iommu/iommu_regset
> 
> DMAR: dmar1: reg_base_addr fed90000
> Name         Offset     Contents
> VER          0x00       0x0000000000000010
> CAP          0x08       0x01c0000c40660462
> ECAP         0x10       0x0000019e2ff0505e
> GCMD         0x18       0x0000000000000000
> GSTS         0x1c       0x00000000c7000000
> RTADDR       0x20       0x00000004558d6800
> CCMD         0x28       0x0800000000000000
> FSTS         0x34       0x0000000000000000
> FECTL        0x38       0x0000000000000000
> FEDATA       0x3c       0xfee0100c00004141

> +		seq_printf(m, "\nDMAR: %s: reg_base_addr %llx\n",
> iommu->name,
> +			   base);

Can we get rid of leading '\n'?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  parent reply	other threads:[~2018-01-10 13:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-10  3:48 [PATCH v6 0/5] Add Intel IOMMU debugfs support Sohil Mehta
2018-01-10  3:48 ` Sohil Mehta
     [not found] ` <1515556102-34150-1-git-send-email-sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-01-10  3:48   ` [PATCH v6 1/5] iommu/vt-d: Add debugfs support for Intel IOMMU internals Sohil Mehta
2018-01-10  3:48     ` Sohil Mehta
     [not found]     ` <1515556102-34150-2-git-send-email-sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-01-10 13:32       ` Andy Shevchenko
2018-01-10 13:32         ` Andy Shevchenko
2018-01-10  3:48   ` [PATCH v6 2/5] iommu/vt-d: Add debugfs support to show context internals Sohil Mehta
2018-01-10  3:48     ` Sohil Mehta
     [not found]     ` <1515556102-34150-3-git-send-email-sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-01-10 17:02       ` Gary R Hook
2018-01-10 17:02         ` Gary R Hook
2018-01-10  3:48   ` [PATCH v6 3/5] iommu/vt-d: Add debugfs support to show register contents Sohil Mehta
2018-01-10  3:48     ` Sohil Mehta
     [not found]     ` <1515556102-34150-4-git-send-email-sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-01-10 13:35       ` Andy Shevchenko [this message]
2018-01-10 13:35         ` Andy Shevchenko
2018-01-10  3:48   ` [PATCH v6 4/5] iommu/vt-d: Add debugfs support to show Pasid table contents Sohil Mehta
2018-01-10  3:48     ` Sohil Mehta
2018-01-10 13:40     ` Andy Shevchenko
2018-01-10  3:48   ` [PATCH v6 5/5] iommu/vt-d: Add debugfs support for Interrupt remapping Sohil Mehta
2018-01-10  3:48     ` Sohil Mehta
     [not found]     ` <1515556102-34150-6-git-send-email-sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-01-10 13:43       ` Andy Shevchenko
2018-01-10 13:43         ` Andy Shevchenko
2018-01-10 13:46 ` [PATCH v6 0/5] Add Intel IOMMU debugfs support Andy Shevchenko
     [not found]   ` <1515592011.7000.873.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-01-11  1:32     ` Mehta, Sohil
2018-01-11  1:32       ` Mehta, Sohil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1515591339.7000.863.camel@linux.intel.com \
    --to=andriy.shevchenko-vuqaysv1563yd54fqh9/ca@public.gmane.org \
    --cc=alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=fenghua.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=gayatri.kammela-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ravi.v.shankar-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.