All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: Benjamin Marzinski <bmarzins@redhat.com>,
	device-mapper development <dm-devel@redhat.com>
Cc: Guan Junxiong <guanjunxiong@huawei.com>
Subject: Re: [PATCH 1/2] remove delay_(watch|wait)_checks
Date: Fri, 12 Jan 2018 22:09:00 +0100	[thread overview]
Message-ID: <1515791340.3409.35.camel@suse.com> (raw)
In-Reply-To: <1513188487-31852-1-git-send-email-bmarzins@redhat.com>

Hi Ben,

On Wed, 2017-12-13 at 12:08 -0600, Benjamin Marzinski wrote:
> These configuration options do essentially the same thing as the
> marginal paths options do, but since they don't do the increased IO
> testing, they are less likely to find the marginal paths. Guan, if
> you
> left these in for a reason (such as to deal with devices that don't
> do
> well with IO testing, such as passive paths) I'm open to keeping
> them.
> But it seems like the marginal paths options options do a better job
> than they do, and if there are cases that they doesn't handle well,
> they
> should be expanded to do so.

I think we should wait a bit more before removing this stuff. The
marginal paths code hasn't seen much testing yet AFAICS.

Regards
Martin

-- 
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

  parent reply	other threads:[~2018-01-12 21:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13 18:08 [PATCH 1/2] remove delay_(watch|wait)_checks Benjamin Marzinski
2017-12-13 18:08 ` [PATCH 2/2] libmultipath: don't update path queueing on reload Benjamin Marzinski
2017-12-18 13:49   ` Martin Wilck
2018-01-13  9:18     ` Christophe Varoqui
2018-01-12 21:09 ` Martin Wilck [this message]
2018-01-18 17:29   ` [PATCH 1/2] remove delay_(watch|wait)_checks Benjamin Marzinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1515791340.3409.35.camel@suse.com \
    --to=mwilck@suse.com \
    --cc=bmarzins@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=guanjunxiong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.