Re: [oe-commits] [openembedded-core] branch morty updated: image: Expand PV to avoid AUTOREV parsing failures

Re: [oe-commits] [openembedded-core] branch morty updated: image: Expand PV to avoid AUTOREV parsing failures

[Martin Jansa]

This causes:

Exception: TypeError: getVar() missing 1 required positional argument:
'expand'

On Sat, Jan 20, 2018 at 11:30 PM, <git@git.openembedded.org> wrote:

> This is an automated email from the git hooks/post-receive script.
>
> rpurdie pushed a commit to branch morty
> in repository openembedded-core.
>
> The following commit(s) were added to refs/heads/morty by this push:
>      new 9ce26c1  image: Expand PV to avoid AUTOREV parsing failures
> 9ce26c1 is described below
>
> commit 9ce26c121f52d5194732be34f93e86128e1fdeaf
> Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> AuthorDate: Mon Jan 8 17:41:27 2018 +0000
>
>     image: Expand PV to avoid AUTOREV parsing failures
>
>     Currently, setting PV to include SRCPV for build-appliance results in:
>
>     bb.data_smart.ExpansionError: Failure expanding variable SRCPV,
> expression was
>     ${@bb.fetch2.get_srcrev(d)} which triggered exception FetchError:
> Fetcher
>     failure: Fetch command export ftp_proxy="http://proxy.yocto.io:5187/";
> export
>     FTP_PROXY="http://proxy.yocto.io:5187/"; export PATH="${TMPDIR}/work/
>     qemux86_64-poky-linux/build-appliance-image/fetcheravoidrecurse-r0/
>     recipe-sysroot-native/usr/bin/python3-native:${TMPDIR}/work/
>     qemux86_64-poky-linux/build-appliance-image/fetcheravoidrecurse-r0/
>     recipe-sysroot-native/usr/bin/python3-native:${TMPDIR}/work/
>     qemux86_64-poky-linux/build-appliance-image/fetcheravoidrecurse-r0/
>     recipe-sysroot-native/usr/bin/python3-native:/home/pokybuild/
>     yocto-autobuilder/yocto-worker/buildtools/build/scripts:${TMPDIR}/
>     work/qemux86_64-poky-linux/build-appliance-image/
> fetcheravoidrecurse-r0/
>     recipe-sysroot-native/usr/bin/x86_64-poky-linux:${TMPDIR}/work/
>     qemux86_64-poky-linux/build-appliance-image/fetcheravoidrecurse-r0/
>     recipe-sysroot/usr/bin/crossscripts:${TMPDIR}/work/
> qemux86_64-poky-linux/
>     build-appliance-image/fetcheravoidrecurse-r0/recipe-
> sysroot-native/usr/sbin:
>     ${TMPDIR}/work/qemux86_64-poky-linux/build-appliance-image/
>     fetcheravoidrecurse-r0/recipe-sysroot-native/usr/bin:${TMPDIR}/work/
>     qemux86_64-poky-linux/build-appliance-image/fetcheravoidrecurse-r0/
>     recipe-sysroot-native/sbin:${TMPDIR}/work/qemux86_64-poky-linux/
>     build-appliance-image/fetcheravoidrecurse-r0/recipe-
> sysroot-native/bin:/home/
>     pokybuild/yocto-autobuilder/yocto-worker/buildtools/build/
> bitbake/bin:${TMPDIR}
>     /hosttools"; export HOME="/home/pokybuild"; git -c
> core.fsyncobjectfiles=0
>     ls-remote git://git.yoctoproject.org/poky  failed with exit code 127,
> output:
>     /bin/sh: 1: git: not found
>
>     This is because PV is being expanded when TMPDIR is unset.
>
>     Expand PV in advance to avoid this problem.
>
>     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/classes/image.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index a9ab2fa..3e6b6e1 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -439,6 +439,8 @@ python () {
>          # This means the task's hash can be stable rather than having
> hardcoded
>          # date/time values. It will get expanded at execution time.
>          # Similarly TMPDIR since otherwise we see QA stamp comparision
> problems
> +        # Expand PV else it can trigger get_srcrev which can fail due to
> these variables being unset
> +        localdata.setVar('PV', d.getVar('PV'))
>          localdata.delVar('DATETIME')
>          localdata.delVar('TMPDIR')
>
>
> --
> To stop receiving notification emails like this one, please contact
> the administrator of this repository.
> --
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits
>

Re: [oe-commits] [openembedded-core] branch morty updated: image: Expand PV to avoid AUTOREV parsing failures

[Richard Purdie]

On Sun, 2018-01-21 at 00:51 +0100, Martin Jansa wrote:
> This causes:
> 
> Exception: TypeError: getVar() missing 1 required positional
> argument: 'expand'

Sorry, fix pushed.

Cheers,

Richard

Re: [oe-commits] [openembedded-core] branch morty updated: image: Expand PV to avoid AUTOREV parsing failures

[Martin Jansa]

Thanks, but was it really pushed?

http://git.openembedded.org/openembedded-core/log/?h=morty

still ends with:
* image: Expand PV to avoid AUTOREV parsing failuresmorty Richard Purdie 10
hours 1 -0/+2
* libunwind: Disable documentation explicitlymorty-next Richard Purdie 8
days 1 -0/+1


On Sun, Jan 21, 2018 at 1:01 AM, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Sun, 2018-01-21 at 00:51 +0100, Martin Jansa wrote:
> > This causes:
> >
> > Exception: TypeError: getVar() missing 1 required positional
> > argument: 'expand'
>
> Sorry, fix pushed.
>
> Cheers,
>
> Richard
>

Re: [oe-commits] [openembedded-core] branch morty updated: image: Expand PV to avoid AUTOREV parsing failures

[Richard Purdie]

On Sun, 2018-01-21 at 09:51 +0100, Martin Jansa wrote:
> Thanks, but was it really pushed?
> 
> http://git.openembedded.org/openembedded-core/log/?h=morty
> 
> still ends with:
> * 	image: Expand PV to avoid AUTOREV parsing failuresmorty	
> Richard Purdie	10 hours	1	-0/+2
> * 	libunwind: Disable documentation explicitlymorty-next	
> Richard Purdie	8 days	1	-0/+1

Sorry, the push failed and I didn't notice. It should really be there
now.

Cheers,

Richard