From: Yu Wang <yyuwang@codeaurora.org>
To: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH] ath10k: fix kernel panic issue during pci probe
Date: Mon, 29 Jan 2018 16:00:00 +0800 [thread overview]
Message-ID: <1517212801-7523-1-git-send-email-yyuwang@codeaurora.org> (raw)
If device gone during chip reset, ar->normal_mode_fw.board is not
initialized, but ath10k_debug_print_hwfw_info() will try to access its
member, which will cause 'kernel NULL pointer' issue. This was found
using a faulty device (pci link went down sometimes) in a random
insmod/rmmod/other-op test.
To fix it, check ar->normal_mode_fw.board before accessing the member.
Yu Wang (1):
ath10k: fix kernel panic issue during pci probe
drivers/net/wireless/ath/ath10k/debug.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Yu Wang <yyuwang@codeaurora.org>
To: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH] ath10k: fix kernel panic issue during pci probe
Date: Mon, 29 Jan 2018 16:00:00 +0800 [thread overview]
Message-ID: <1517212801-7523-1-git-send-email-yyuwang@codeaurora.org> (raw)
If device gone during chip reset, ar->normal_mode_fw.board is not
initialized, but ath10k_debug_print_hwfw_info() will try to access its
member, which will cause 'kernel NULL pointer' issue. This was found
using a faulty device (pci link went down sometimes) in a random
insmod/rmmod/other-op test.
To fix it, check ar->normal_mode_fw.board before accessing the member.
Yu Wang (1):
ath10k: fix kernel panic issue during pci probe
drivers/net/wireless/ath/ath10k/debug.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
--
1.9.1
next reply other threads:[~2018-01-29 8:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 8:00 Yu Wang [this message]
2018-01-29 8:00 ` [PATCH] ath10k: fix kernel panic issue during pci probe Yu Wang
2018-01-29 8:00 ` Yu Wang
2018-01-29 8:00 ` Yu Wang
2018-02-07 14:16 ` Kalle Valo
2018-02-07 14:16 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517212801-7523-1-git-send-email-yyuwang@codeaurora.org \
--to=yyuwang@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.