From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Igor Ryzhov <iryzhov@nfware.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] pci: fix one device probing
Date: Fri, 16 Sep 2016 15:20:04 +0200 [thread overview]
Message-ID: <1517241.brkdynD5ST@xps13> (raw)
In-Reply-To: <1470311406-38841-1-git-send-email-iryzhov@nfware.com>
2016-08-04 14:50, Igor Ryzhov:
> The rte_eal_pci_probe_one function could return false positive result if
> no driver is found for the device.
>
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
[...]
> --- a/lib/librte_eal/common/eal_common_pci.c
> +++ b/lib/librte_eal/common/eal_common_pci.c
> @@ -344,7 +344,7 @@ rte_eal_pci_probe_one(const struct rte_pci_addr *addr)
> continue;
>
> ret = pci_probe_all_drivers(dev);
> - if (ret < 0)
> + if (ret)
> goto err_return;
> return 0;
> }
This patch was discussed in another thread:
http://dpdk.org/ml/archives/dev/2016-August/045127.html
Is there anyone thinking this patch is not a step forward?
next prev parent reply other threads:[~2016-09-16 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 11:50 [PATCH] pci: fix one device probing Igor Ryzhov
2016-09-16 13:20 ` Thomas Monjalon [this message]
2016-11-07 13:26 ` David Marchand
2016-11-07 13:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517241.brkdynD5ST@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=iryzhov@nfware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.