From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Kenzior <denkenz@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [RFC v3 0/6] EAPoL over NL80211
Date: Wed, 31 Jan 2018 23:00:00 +0100 [thread overview]
Message-ID: <1517436000.28814.3.camel@sipsolutions.net> (raw)
In-Reply-To: <20180131213329.25322-1-denkenz@gmail.com> (sfid-20180131_223342_909055_336D73F4)
Looks pretty good! Some comments over in separate emails.
Maybe you should consider reordering:
[1/6] keep
[2/6] keep
[3/6] introduce TX (now patch 5)
[4/6] introduce RX (now patch 3)
modify this to require TX from the driver in order to be able to
set the new flag
[5/6] add TX to mac80211
[6/6] add RX to mac80211 and set the flag
Ok, you don't really have to do that, since you only set the flag in
the last patch anyway, but that'd make it better to add the check that
requires TX, so you don't have to do that in the TX patch and modify
the RX portion again.
johannes
next prev parent reply other threads:[~2018-01-31 22:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 21:33 [RFC v3 0/6] EAPoL over NL80211 Denis Kenzior
2018-01-31 21:33 ` [PATCH 1/6] uapi: Add 802.11 Preauthentication to if_ether Denis Kenzior
2018-01-31 21:33 ` [PATCH 2/6] nl80211: Add CONTROL_PORT_OVER_NL80211 attribute Denis Kenzior
2018-01-31 21:33 ` [PATCH 3/6] nl80211: Add CMD_CONTROL_PORT_FRAME API Denis Kenzior
2018-01-31 21:45 ` Johannes Berg
2018-01-31 22:01 ` Denis Kenzior
2018-01-31 22:03 ` Johannes Berg
2018-01-31 21:33 ` [PATCH 4/6] mac80211: Send control port frames over nl80211 Denis Kenzior
2018-01-31 21:50 ` Johannes Berg
2018-01-31 21:33 ` [PATCH 5/6] nl80211: Implement TX of control port frames Denis Kenzior
2018-01-31 21:52 ` Johannes Berg
2018-01-31 21:53 ` Johannes Berg
2018-01-31 21:58 ` Denis Kenzior
2018-01-31 22:00 ` Johannes Berg
2018-01-31 21:33 ` [PATCH 6/6] mac80211: Add support for tx_control_port Denis Kenzior
2018-01-31 22:00 ` Johannes Berg [this message]
2018-02-01 1:09 ` [RFC v3 0/6] EAPoL over NL80211 Denis Kenzior
2018-02-01 8:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517436000.28814.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=denkenz@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.