[PATCH v2] apt-native: Add libapt-pkg headers

[PATCH v2] apt-native: Add libapt-pkg headers

[Jan Siegmund]

From: Jan Siegmund <jsiegmund@arri.de>

Native tools were not able to use the headers of apt-pkg. This patch
adds the feature.
The headers were added from apt-pkg and apt-inst to the native recipe.
The shipped headers match the ones in the Ubuntu package libapt-pkg-dev.

Signed-off-by: Jan Siegmund <jsiegmund@arri.de>
---
 meta/recipes-devtools/apt/apt-native.inc | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/meta/recipes-devtools/apt/apt-native.inc b/meta/recipes-devtools/apt/apt-native.inc
index 68f1b3ce2c..d82ffcc59f 100644
--- a/meta/recipes-devtools/apt/apt-native.inc
+++ b/meta/recipes-devtools/apt/apt-native.inc
@@ -35,6 +35,8 @@ python do_install_config () {
         outfile.close()
 }
 
+FILES_${PN} += "${includedir}"
+
 do_install_base () {
 	install -d ${D}${bindir}
 	install -m 0755 bin/apt-cdrom ${D}${bindir}/
@@ -67,4 +69,10 @@ do_install_base () {
 	install -d ${D}${localstatedir}/cache/apt/archives/partial
 
 	install -d ${D}${localstatedir}/log/apt/
+
+	install -d ${D}${includedir}/apt-pkg
+	for h in `find ${S}/apt-pkg ${S}/apt-inst -name '*.h'`
+	do
+		install -m 0644 $h ${D}${includedir}/apt-pkg
+	done
 }
-- 
2.14.1

Re: [PATCH v2] apt-native: Add libapt-pkg headers

[Richard Purdie]

On Sat, 2018-02-03 at 11:33 +0100, Jan Siegmund wrote:
> From: Jan Siegmund <jsiegmund@arri.de>
> 
> Native tools were not able to use the headers of apt-pkg. This patch
> adds the feature.
> The headers were added from apt-pkg and apt-inst to the native
> recipe.
> The shipped headers match the ones in the Ubuntu package libapt-pkg-
> dev.
> 
> Signed-off-by: Jan Siegmund <jsiegmund@arri.de>
> ---
>  meta/recipes-devtools/apt/apt-native.inc | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/meta/recipes-devtools/apt/apt-native.inc b/meta/recipes-
> devtools/apt/apt-native.inc
> index 68f1b3ce2c..d82ffcc59f 100644
> --- a/meta/recipes-devtools/apt/apt-native.inc
> +++ b/meta/recipes-devtools/apt/apt-native.inc
> @@ -35,6 +35,8 @@ python do_install_config () {
>          outfile.close()
>  }
>  
> +FILES_${PN} += "${includedir}"
> +
>  do_install_base () {
>  	install -d ${D}${bindir}
>  	install -m 0755 bin/apt-cdrom ${D}${bindir}/

I suspect a native recipe doesn't need to set FILES?

Cheers,

Richard

Re: [PATCH v2] apt-native: Add libapt-pkg headers

[Jan Siegmund]

Am 04.02.2018 um 10:59 schrieb Richard Purdie:
> On Sat, 2018-02-03 at 11:33 +0100, Jan Siegmund wrote:
>> From: Jan Siegmund <jsiegmund@arri.de>
>>
>> Native tools were not able to use the headers of apt-pkg. This patch
>> adds the feature.
>> The headers were added from apt-pkg and apt-inst to the native
>> recipe.
>> The shipped headers match the ones in the Ubuntu package libapt-pkg-
>> dev.
>>
>> Signed-off-by: Jan Siegmund <jsiegmund@arri.de>
>> ---
>>  meta/recipes-devtools/apt/apt-native.inc | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/meta/recipes-devtools/apt/apt-native.inc b/meta/recipes-
>> devtools/apt/apt-native.inc
>> index 68f1b3ce2c..d82ffcc59f 100644
>> --- a/meta/recipes-devtools/apt/apt-native.inc
>> +++ b/meta/recipes-devtools/apt/apt-native.inc
>> @@ -35,6 +35,8 @@ python do_install_config () {
>>          outfile.close()
>>  }
>>  
>> +FILES_${PN} += "${includedir}"
>> +
>>  do_install_base () {
>>  	install -d ${D}${bindir}
>>  	install -m 0755 bin/apt-cdrom ${D}${bindir}/
> 
> I suspect a native recipe doesn't need to set FILES?

I'll drop it and send version 3.

> 
> Cheers,
> 
> Richard
> 

Thanks for the review,

Jan