From: embed3d@gmail.com (Philipp Rossak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] arm: dts: sun6i: a31s: bpi-m2: update mmc supply nodes
Date: Sun, 11 Feb 2018 23:15:02 +0100 [thread overview]
Message-ID: <1518387302.1342.3.camel@gmail.com> (raw)
In-Reply-To: <20180209175236.21215-2-embed3d@gmail.com>
Am Freitag, den 09.02.2018, 18:52 +0100 schrieb Philipp Rossak:
> This patch updates the vmmc-supply properties on the mmc0 and mmc2
> node to use the allready existent regulators.
> We can now remove the sunxi-common-regulators.dtsi include since we
> don't need it anymore.
>
> Signed-off-by: Philipp Rossak <embed3d@gmail.com>
> ---
> ?arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts | 5 ++---
> ?1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts
> b/arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts
> index 51e6f1d21c32..a8d86211c8f3 100644
> --- a/arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts
> +++ b/arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts
> @@ -42,7 +42,6 @@
> ?
> ?/dts-v1/;
> ?#include "sun6i-a31s.dtsi"
> -#include "sunxi-common-regulators.dtsi"
> ?#include <dt-bindings/gpio/gpio.h>
> ?
> ?/ {
> @@ -118,7 +117,7 @@
> ?&mmc0 {
> ? pinctrl-names = "default";
> ? pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_bpi_m2>;
> - vmmc-supply = <®_vcc3v0>;
> + vmmc-supply = <®_dcdc1>;
> ? bus-width = <4>;
> ? cd-gpios = <&pio 0 4 GPIO_ACTIVE_HIGH>; /* PA4 */
> ? cd-inverted;
> @@ -132,7 +131,7 @@
> ?&mmc2 {
> ? pinctrl-names = "default";
> ? pinctrl-0 = <&mmc2_pins_a>;
> - vmmc-supply = <®_vcc3v0>;
> + vmmc-supply = <®_dcdc1>;
^^
this here is wrong! this should be ®_aldo1
> ? mmc-pwrseq = <&mmc2_pwrseq>;
> ? bus-width = <4>;
> ? non-removable;
Philipp
WARNING: multiple messages have this Message-ID (diff)
From: Philipp Rossak <embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
wens-jdAy2FN1RRM@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 1/3] arm: dts: sun6i: a31s: bpi-m2: update mmc supply nodes
Date: Sun, 11 Feb 2018 23:15:02 +0100 [thread overview]
Message-ID: <1518387302.1342.3.camel@gmail.com> (raw)
In-Reply-To: <20180209175236.21215-2-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Am Freitag, den 09.02.2018, 18:52 +0100 schrieb Philipp Rossak:
> This patch updates the vmmc-supply properties on the mmc0 and mmc2
> node to use the allready existent regulators.
> We can now remove the sunxi-common-regulators.dtsi include since we
> don't need it anymore.
>
> Signed-off-by: Philipp Rossak <embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts
> b/arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts
> index 51e6f1d21c32..a8d86211c8f3 100644
> --- a/arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts
> +++ b/arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts
> @@ -42,7 +42,6 @@
>
> /dts-v1/;
> #include "sun6i-a31s.dtsi"
> -#include "sunxi-common-regulators.dtsi"
> #include <dt-bindings/gpio/gpio.h>
>
> / {
> @@ -118,7 +117,7 @@
> &mmc0 {
> pinctrl-names = "default";
> pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_bpi_m2>;
> - vmmc-supply = <®_vcc3v0>;
> + vmmc-supply = <®_dcdc1>;
> bus-width = <4>;
> cd-gpios = <&pio 0 4 GPIO_ACTIVE_HIGH>; /* PA4 */
> cd-inverted;
> @@ -132,7 +131,7 @@
> &mmc2 {
> pinctrl-names = "default";
> pinctrl-0 = <&mmc2_pins_a>;
> - vmmc-supply = <®_vcc3v0>;
> + vmmc-supply = <®_dcdc1>;
^^
this here is wrong! this should be ®_aldo1
> mmc-pwrseq = <&mmc2_pwrseq>;
> bus-width = <4>;
> non-removable;
Philipp
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Philipp Rossak <embed3d@gmail.com>
To: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
maxime.ripard@free-electrons.com, wens@csie.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 1/3] arm: dts: sun6i: a31s: bpi-m2: update mmc supply nodes
Date: Sun, 11 Feb 2018 23:15:02 +0100 [thread overview]
Message-ID: <1518387302.1342.3.camel@gmail.com> (raw)
In-Reply-To: <20180209175236.21215-2-embed3d@gmail.com>
Am Freitag, den 09.02.2018, 18:52 +0100 schrieb Philipp Rossak:
> This patch updates the vmmc-supply properties on the mmc0 and mmc2
> node to use the allready existent regulators.
> We can now remove the sunxi-common-regulators.dtsi include since we
> don't need it anymore.
>
> Signed-off-by: Philipp Rossak <embed3d@gmail.com>
> ---
> arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts
> b/arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts
> index 51e6f1d21c32..a8d86211c8f3 100644
> --- a/arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts
> +++ b/arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts
> @@ -42,7 +42,6 @@
>
> /dts-v1/;
> #include "sun6i-a31s.dtsi"
> -#include "sunxi-common-regulators.dtsi"
> #include <dt-bindings/gpio/gpio.h>
>
> / {
> @@ -118,7 +117,7 @@
> &mmc0 {
> pinctrl-names = "default";
> pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_bpi_m2>;
> - vmmc-supply = <®_vcc3v0>;
> + vmmc-supply = <®_dcdc1>;
> bus-width = <4>;
> cd-gpios = <&pio 0 4 GPIO_ACTIVE_HIGH>; /* PA4 */
> cd-inverted;
> @@ -132,7 +131,7 @@
> &mmc2 {
> pinctrl-names = "default";
> pinctrl-0 = <&mmc2_pins_a>;
> - vmmc-supply = <®_vcc3v0>;
> + vmmc-supply = <®_dcdc1>;
^^
this here is wrong! this should be ®_aldo1
> mmc-pwrseq = <&mmc2_pwrseq>;
> bus-width = <4>;
> non-removable;
Philipp
next prev parent reply other threads:[~2018-02-11 22:15 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 17:52 [PATCH 0/3] Fix broken bananapi m2 devicetree/regulators Philipp Rossak
2018-02-09 17:52 ` Philipp Rossak
2018-02-09 17:52 ` [PATCH 1/3] arm: dts: sun6i: a31s: bpi-m2: update mmc supply nodes Philipp Rossak
2018-02-09 17:52 ` Philipp Rossak
2018-02-09 17:52 ` Philipp Rossak
2018-02-11 22:15 ` Philipp Rossak [this message]
2018-02-11 22:15 ` Philipp Rossak
2018-02-11 22:15 ` Philipp Rossak
2018-02-09 17:52 ` [PATCH 2/3] arm: dts: sun6i: a31s: bpi-m2: improve pmic properties Philipp Rossak
2018-02-09 17:52 ` Philipp Rossak
2018-02-09 17:52 ` Philipp Rossak
2018-02-09 17:52 ` [PATCH 3/3] arm: dts: sun6i: a31s: fix: bpi-m2: add missing regulators Philipp Rossak
2018-02-09 17:52 ` Philipp Rossak
2018-02-09 17:52 ` Philipp Rossak
2018-02-10 13:56 ` [PATCH 0/3] Fix broken bananapi m2 devicetree/regulators Sergey Suloev
2018-02-10 13:56 ` Sergey Suloev
2018-02-10 21:01 ` Philipp Rossak
2018-02-10 21:01 ` Philipp Rossak
2018-02-10 21:01 ` Philipp Rossak
2018-02-10 21:08 ` Sergey Suloev
2018-02-10 21:08 ` Sergey Suloev
2018-02-10 22:07 ` Philipp Rossak
2018-02-10 22:07 ` Philipp Rossak
2018-02-10 22:07 ` Philipp Rossak
2018-02-11 7:29 ` Sergey Suloev
2018-02-11 7:29 ` Sergey Suloev
2018-02-11 7:29 ` Sergey Suloev
2018-02-11 7:55 ` Sergey Suloev
2018-02-11 7:55 ` Sergey Suloev
2018-02-11 7:55 ` Sergey Suloev
2018-02-11 11:30 ` Philipp Rossak
2018-02-11 11:30 ` Philipp Rossak
2018-02-11 11:30 ` Philipp Rossak
2018-02-11 11:36 ` Sergey Suloev
2018-02-11 11:36 ` Sergey Suloev
2018-02-11 11:44 ` Sergey Suloev
2018-02-11 11:44 ` Sergey Suloev
2018-02-11 11:44 ` Sergey Suloev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518387302.1342.3.camel@gmail.com \
--to=embed3d@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.