From: Joe Perches <joe@perches.com>
To: Mario Leinweber <marioleinweber@web.de>, akpm@linux-foundation.org
Cc: mingo@kernel.org, kirill.shutemov@linux.intel.com,
aneesh.kumar@linux.vnet.ibm.com, mhocko@suse.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/gup: Fixed coding style error and warnings.
Date: Tue, 13 Feb 2018 11:32:48 -0800 [thread overview]
Message-ID: <1518550368.22190.53.camel@perches.com> (raw)
In-Reply-To: <20180213191722.11228-1-marioleinweber@web.de>
You should have a changelog.
On Tue, 2018-02-13 at 14:17 -0500, Mario Leinweber wrote:
[]
> diff --git a/mm/gup.c b/mm/gup.c
[]
> @@ -1635,7 +1640,7 @@ static int gup_pmd_range(pud_t pud, unsigned long addr, unsigned long end,
> PMD_SHIFT, next, write, pages, nr))
> return 0;
> } else if (!gup_pte_range(pmd, addr, next, write, pages, nr))
> - return 0;
> + return 0;
And of all these changes, this might be the only really useful one
as the
indentation is misleading.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Mario Leinweber <marioleinweber@web.de>, akpm@linux-foundation.org
Cc: mingo@kernel.org, kirill.shutemov@linux.intel.com,
aneesh.kumar@linux.vnet.ibm.com, mhocko@suse.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/gup: Fixed coding style error and warnings.
Date: Tue, 13 Feb 2018 11:32:48 -0800 [thread overview]
Message-ID: <1518550368.22190.53.camel@perches.com> (raw)
In-Reply-To: <20180213191722.11228-1-marioleinweber@web.de>
You should have a changelog.
On Tue, 2018-02-13 at 14:17 -0500, Mario Leinweber wrote:
[]
> diff --git a/mm/gup.c b/mm/gup.c
[]
> @@ -1635,7 +1640,7 @@ static int gup_pmd_range(pud_t pud, unsigned long addr, unsigned long end,
> PMD_SHIFT, next, write, pages, nr))
> return 0;
> } else if (!gup_pte_range(pmd, addr, next, write, pages, nr))
> - return 0;
> + return 0;
And of all these changes, this might be the only really useful one
as the
indentation is misleading.
next prev parent reply other threads:[~2018-02-13 19:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 19:17 [PATCH] mm/gup: Fixed coding style error and warnings Mario Leinweber
2018-02-13 19:17 ` Mario Leinweber
2018-02-13 19:32 ` Joe Perches [this message]
2018-02-13 19:32 ` Joe Perches
2018-02-13 19:36 ` Matthew Wilcox
2018-02-13 19:36 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518550368.22190.53.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marioleinweber@web.de \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.