[PATCH] platform/x86: intel_turbo_max_3: Remove restriction for HWP platforms

[PATCH] platform/x86: intel_turbo_max_3: Remove restriction for HWP platforms

[Srinivas Pandruvada]

On systems supporting HWP (Hardware P-States) mode, we expected to
enumerate core priority via ACPI-CPPC tables. Unfortunately deployment of
TURBO 3.0 didn't use this method to show core priority. So users are not
able to utilize this feature in HWP mode.

So remove the loading restriction of this driver for HWP enabled systems.
Even if there are some systems, which are providing the core priority via
ACPI CPPC, this shouldn't cause any conflict as the source of priority
definition is same.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Reported-and-tested-and-reviewed-by: Arjan van de Ven <arjan@linux.intel.com>
---
 drivers/platform/x86/intel_turbo_max_3.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/platform/x86/intel_turbo_max_3.c b/drivers/platform/x86/intel_turbo_max_3.c
index d4ea01805879..a6d5aa0c3c47 100644
--- a/drivers/platform/x86/intel_turbo_max_3.c
+++ b/drivers/platform/x86/intel_turbo_max_3.c
@@ -138,9 +138,6 @@ static int __init itmt_legacy_init(void)
 	if (!id)
 		return -ENODEV;
 
-	if (boot_cpu_has(X86_FEATURE_HWP))
-		return -ENODEV;
-
 	ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
 				"platform/x86/turbo_max_3:online",
 				itmt_legacy_cpu_online,	NULL);
-- 
2.13.6

Re: [PATCH] platform/x86: intel_turbo_max_3: Remove restriction for HWP platforms

[Andy Shevchenko]

On Mon, Feb 12, 2018 at 9:50 PM, Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
> On systems supporting HWP (Hardware P-States) mode, we expected to
> enumerate core priority via ACPI-CPPC tables. Unfortunately deployment of
> TURBO 3.0 didn't use this method to show core priority. So users are not
> able to utilize this feature in HWP mode.
>
> So remove the loading restriction of this driver for HWP enabled systems.
> Even if there are some systems, which are providing the core priority via
> ACPI CPPC, this shouldn't cause any conflict as the source of priority
> definition is same.
>

Pushed to my review and testing queue, thanks!

P.S. Should it go to stable?

> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Reported-and-tested-and-reviewed-by: Arjan van de Ven <arjan@linux.intel.com>
> ---
>  drivers/platform/x86/intel_turbo_max_3.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_turbo_max_3.c b/drivers/platform/x86/intel_turbo_max_3.c
> index d4ea01805879..a6d5aa0c3c47 100644
> --- a/drivers/platform/x86/intel_turbo_max_3.c
> +++ b/drivers/platform/x86/intel_turbo_max_3.c
> @@ -138,9 +138,6 @@ static int __init itmt_legacy_init(void)
>         if (!id)
>                 return -ENODEV;
>
> -       if (boot_cpu_has(X86_FEATURE_HWP))
> -               return -ENODEV;
> -
>         ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
>                                 "platform/x86/turbo_max_3:online",
>                                 itmt_legacy_cpu_online, NULL);
> --
> 2.13.6
>



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/x86: intel_turbo_max_3: Remove restriction for HWP platforms

[Arjan van de Ven]

On 2/14/2018 11:29 AM, Andy Shevchenko wrote:
> On Mon, Feb 12, 2018 at 9:50 PM, Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com> wrote:
>> On systems supporting HWP (Hardware P-States) mode, we expected to
>> enumerate core priority via ACPI-CPPC tables. Unfortunately deployment of
>> TURBO 3.0 didn't use this method to show core priority. So users are not
>> able to utilize this feature in HWP mode.
>>
>> So remove the loading restriction of this driver for HWP enabled systems.
>> Even if there are some systems, which are providing the core priority via
>> ACPI CPPC, this shouldn't cause any conflict as the source of priority
>> definition is same.
>>
> 
> Pushed to my review and testing queue, thanks!
> 
> P.S. Should it go to stable?

older stable at least did not have the problem

Re: [PATCH] platform/x86: intel_turbo_max_3: Remove restriction for HWP platforms

[Srinivas Pandruvada]

On Wed, 2018-02-14 at 21:29 +0200, Andy Shevchenko wrote:
> On Mon, Feb 12, 2018 at 9:50 PM, Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com> wrote:
> > On systems supporting HWP (Hardware P-States) mode, we expected to
> > enumerate core priority via ACPI-CPPC tables. Unfortunately
> > deployment of
> > TURBO 3.0 didn't use this method to show core priority. So users
> > are not
> > able to utilize this feature in HWP mode.
> > 
> > So remove the loading restriction of this driver for HWP enabled
> > systems.
> > Even if there are some systems, which are providing the core
> > priority via
> > ACPI CPPC, this shouldn't cause any conflict as the source of
> > priority
> > definition is same.
> > 
> 
> Pushed to my review and testing queue, thanks!
> 
> P.S. Should it go to stable?
I want to avoid stable kernel for now.

Thanks,
Srinivas

> 
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel
> > .com>
> > Reported-and-tested-and-reviewed-by: Arjan van de Ven <arjan@linux.
> > intel.com>
> > ---
> >  drivers/platform/x86/intel_turbo_max_3.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/drivers/platform/x86/intel_turbo_max_3.c
> > b/drivers/platform/x86/intel_turbo_max_3.c
> > index d4ea01805879..a6d5aa0c3c47 100644
> > --- a/drivers/platform/x86/intel_turbo_max_3.c
> > +++ b/drivers/platform/x86/intel_turbo_max_3.c
> > @@ -138,9 +138,6 @@ static int __init itmt_legacy_init(void)
> >         if (!id)
> >                 return -ENODEV;
> > 
> > -       if (boot_cpu_has(X86_FEATURE_HWP))
> > -               return -ENODEV;
> > -
> >         ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
> >                                 "platform/x86/turbo_max_3:online",
> >                                 itmt_legacy_cpu_online, NULL);
> > --
> > 2.13.6
> > 
> 
> 
>