All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramamurthy, Harshitha <harshitha.ramamurthy@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower
Date: Thu, 15 Feb 2018 17:56:40 +0000	[thread overview]
Message-ID: <1518717442.29950.1.camel@intel.com> (raw)
In-Reply-To: <20180215174435.GA19969@embeddedor.com>

On Thu, 2018-02-15 at 11:44 -0600, Gustavo A. R. Silva wrote:
> It seems this is a copy-paste error and that the proper variable to
> use
> in this particular case is _src_ instead of _dst_.
> 
> Addresses-Coverity-ID: 1465282 ("Copy-paste error")
> Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Thanks for the patch!

Acked-by:Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>
> ---
> ?drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> index 4955ce3..58be99e 100644
> --- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> +++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> @@ -2763,7 +2763,7 @@ static int i40evf_parse_cls_flower(struct
> i40evf_adapter *adapter,
> ?
> ?		if (key->src) {
> ?			filter->f.mask.tcp_spec.src_port |=
> cpu_to_be16(0xffff);
> -			filter->f.data.tcp_spec.src_port = key->dst;
> +			filter->f.data.tcp_spec.src_port = key->src;
> ?		}
> ?	}
> ?	filter->f.field_flags = field_flags;

WARNING: multiple messages have this Message-ID (diff)
From: "Ramamurthy, Harshitha" <harshitha.ramamurthy@intel.com>
To: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
	"garsilva@embeddedor.com" <garsilva@embeddedor.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>
Subject: Re: [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower
Date: Thu, 15 Feb 2018 17:56:40 +0000	[thread overview]
Message-ID: <1518717442.29950.1.camel@intel.com> (raw)
In-Reply-To: <20180215174435.GA19969@embeddedor.com>

On Thu, 2018-02-15 at 11:44 -0600, Gustavo A. R. Silva wrote:
> It seems this is a copy-paste error and that the proper variable to
> use
> in this particular case is _src_ instead of _dst_.
> 
> Addresses-Coverity-ID: 1465282 ("Copy-paste error")
> Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Thanks for the patch!

Acked-by:Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>
> ---
>  drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> index 4955ce3..58be99e 100644
> --- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> +++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> @@ -2763,7 +2763,7 @@ static int i40evf_parse_cls_flower(struct
> i40evf_adapter *adapter,
>  
>  		if (key->src) {
>  			filter->f.mask.tcp_spec.src_port |=
> cpu_to_be16(0xffff);
> -			filter->f.data.tcp_spec.src_port = key->dst;
> +			filter->f.data.tcp_spec.src_port = key->src;
>  		}
>  	}
>  	filter->f.field_flags = field_flags;

  reply	other threads:[~2018-02-15 17:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15 17:44 [Intel-wired-lan] [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower Gustavo A. R. Silva
2018-02-15 17:44 ` Gustavo A. R. Silva
2018-02-15 17:56 ` Ramamurthy, Harshitha [this message]
2018-02-15 17:56   ` Ramamurthy, Harshitha
2018-02-15 18:11   ` [Intel-wired-lan] " Jeff Kirsher
2018-02-15 18:11     ` Jeff Kirsher
2018-02-15 18:38     ` [Intel-wired-lan] " Gustavo A. R. Silva
2018-02-15 18:38       ` Gustavo A. R. Silva
2018-03-05 22:01 ` [Intel-wired-lan] " Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518717442.29950.1.camel@intel.com \
    --to=harshitha.ramamurthy@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.