diff for duplicates of <1518785796.9517.25.camel@nxp.com> diff --git a/a/1.txt b/N1/1.txt index 6e5d2c3..fa15db6 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,12 +1,19 @@ -SGkgUm9kcmlnbywNCg0KSSB0aGluayB0aGlzIGlzIGEgbmljZSBmaW5kaW5nLiBPbmUgY29tbWVu -dCBpbmxpbmU6DQoNCk9uIFZpLCAyMDE4LTAyLTE2IGF0IDEwOjUwIC0wMjAwLCByb2RyaWdvc2lx -dWVpcmEgd3JvdGU6DQo+IFRoaXMgcGF0Y2ggZml4ZXMgdGhlIGNoZWNrcGF0Y2gucGwgd2Fybmlu -ZzoNCj4gDQo+IGRyaXZlcnMvc3RhZ2luZy9paW8vbWV0ZXIvYWRlNzg1NC5oOjE1NzogV0FSTklO -RzogZnVuY3Rpb24gZGVmaW5pdGlvbg0KPiBhcmd1bWVudCAnc3RydWN0IGRldmljZSAqJyBzaG91 -bGQgYWxzbyBoYXZlIGFuIGlkZW50aWZpZXIgbmFtZS4uLg0KPsKgDQo+ICsJaW50ICgqcmVhZF9y -ZWdfMzIpKHN0cnVjdCBkZXZpY2UgKmRldiwgdTE2IHJlZ19hZGRyZXNzLCB1MzIgKnZhbCk7DQo+ -ICsJaW50ICgqd3JpdGVfcmVnXzgpKHN0cnVjdCBkZXZpY2UgKmRldiwgdTE2IHJlZ19hZGRyZXNz -LCB1OCB2YWx1ZSk7DQoNCg0KQW55IHBhcnRpY3VsYXIgcmVhc29uIGZvciB1c2luZyB2YWwgdnMg -dmFsdWU/IEkgZ2V0IHRoYXQgb25lIGlzIGEgcG9pbnRlcg0KYW5kIGFub3RoZXIgYSBwbGFpbiB0 -eXBlLCBidXQgSSB0aGluayB0aGUgbmFtZSBzaG91bGQgYmUgdGhlIHNhbWUuDQoNCnRoYW5rcywN -CkRhbmllbC4NCg0K +Hi Rodrigo, + +I think this is a nice finding. One comment inline: + +On Vi, 2018-02-16 at 10:50 -0200, rodrigosiqueira wrote: +> This patch fixes the checkpatch.pl warning: +> +> drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition +> argument 'struct device *' should also have an identifier name... +> +> + int (*read_reg_32)(struct device *dev, u16 reg_address, u32 *val); +> + int (*write_reg_8)(struct device *dev, u16 reg_address, u8 value); + + +Any particular reason for using val vs value? I get that one is a pointer +and another a plain type, but I think the name should be the same. + +thanks, +Daniel. diff --git a/a/content_digest b/N1/content_digest index d0d0bd4..666faf4 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -14,17 +14,24 @@ " devel@driverdev.osuosl.org <devel@driverdev.osuosl.org>\0" "\00:1\0" "b\0" - "SGkgUm9kcmlnbywNCg0KSSB0aGluayB0aGlzIGlzIGEgbmljZSBmaW5kaW5nLiBPbmUgY29tbWVu\n" - "dCBpbmxpbmU6DQoNCk9uIFZpLCAyMDE4LTAyLTE2IGF0IDEwOjUwIC0wMjAwLCByb2RyaWdvc2lx\n" - "dWVpcmEgd3JvdGU6DQo+IFRoaXMgcGF0Y2ggZml4ZXMgdGhlIGNoZWNrcGF0Y2gucGwgd2Fybmlu\n" - "ZzoNCj4gDQo+IGRyaXZlcnMvc3RhZ2luZy9paW8vbWV0ZXIvYWRlNzg1NC5oOjE1NzogV0FSTklO\n" - "RzogZnVuY3Rpb24gZGVmaW5pdGlvbg0KPiBhcmd1bWVudCAnc3RydWN0IGRldmljZSAqJyBzaG91\n" - "bGQgYWxzbyBoYXZlIGFuIGlkZW50aWZpZXIgbmFtZS4uLg0KPsKgDQo+ICsJaW50ICgqcmVhZF9y\n" - "ZWdfMzIpKHN0cnVjdCBkZXZpY2UgKmRldiwgdTE2IHJlZ19hZGRyZXNzLCB1MzIgKnZhbCk7DQo+\n" - "ICsJaW50ICgqd3JpdGVfcmVnXzgpKHN0cnVjdCBkZXZpY2UgKmRldiwgdTE2IHJlZ19hZGRyZXNz\n" - "LCB1OCB2YWx1ZSk7DQoNCg0KQW55IHBhcnRpY3VsYXIgcmVhc29uIGZvciB1c2luZyB2YWwgdnMg\n" - "dmFsdWU/IEkgZ2V0IHRoYXQgb25lIGlzIGEgcG9pbnRlcg0KYW5kIGFub3RoZXIgYSBwbGFpbiB0\n" - "eXBlLCBidXQgSSB0aGluayB0aGUgbmFtZSBzaG91bGQgYmUgdGhlIHNhbWUuDQoNCnRoYW5rcywN\n" - CkRhbmllbC4NCg0K + "Hi Rodrigo,\n" + "\n" + "I think this is a nice finding. One comment inline:\n" + "\n" + "On Vi, 2018-02-16 at 10:50 -0200, rodrigosiqueira wrote:\n" + "> This patch fixes the checkpatch.pl warning:\n" + "> \n" + "> drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition\n" + "> argument 'struct device *' should also have an identifier name...\n" + ">\302\240\n" + "> +\tint (*read_reg_32)(struct device *dev, u16 reg_address, u32 *val);\n" + "> +\tint (*write_reg_8)(struct device *dev, u16 reg_address, u8 value);\n" + "\n" + "\n" + "Any particular reason for using val vs value? I get that one is a pointer\n" + "and another a plain type, but I think the name should be the same.\n" + "\n" + "thanks,\n" + Daniel. -93f3e33a14660fd24ccc74cd83faecd1c1f927de4d93547fa85efb1af823daec +5947bd940206a0c89635ce51162f1a8d3c303952b0a5e7b9b00c47ec2f27b64b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.