All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Baluta <daniel.baluta@nxp.com>
To: "lars@metafoo.de" <lars@metafoo.de>,
	"knaack.h@gmx.de" <knaack.h@gmx.de>,
	"rodrigosiqueiramelo@gmail.com" <rodrigosiqueiramelo@gmail.com>,
	"Michael.Hennerich@analog.com" <Michael.Hennerich@analog.com>,
	"jic23@kernel.org" <jic23@kernel.org>,
	"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH] staging: iio/meter: add name to function definition arguments
Date: Fri, 16 Feb 2018 12:56:36 +0000	[thread overview]
Message-ID: <1518785796.9517.25.camel@nxp.com> (raw)
In-Reply-To: <20180216125041.qfvg7xtpulc54tk6@smtp.gmail.com>

SGkgUm9kcmlnbywNCg0KSSB0aGluayB0aGlzIGlzIGEgbmljZSBmaW5kaW5nLiBPbmUgY29tbWVu
dCBpbmxpbmU6DQoNCk9uIFZpLCAyMDE4LTAyLTE2IGF0IDEwOjUwIC0wMjAwLCByb2RyaWdvc2lx
dWVpcmEgd3JvdGU6DQo+IFRoaXMgcGF0Y2ggZml4ZXMgdGhlIGNoZWNrcGF0Y2gucGwgd2Fybmlu
ZzoNCj4gDQo+IGRyaXZlcnMvc3RhZ2luZy9paW8vbWV0ZXIvYWRlNzg1NC5oOjE1NzogV0FSTklO
RzogZnVuY3Rpb24gZGVmaW5pdGlvbg0KPiBhcmd1bWVudCAnc3RydWN0IGRldmljZSAqJyBzaG91
bGQgYWxzbyBoYXZlIGFuIGlkZW50aWZpZXIgbmFtZS4uLg0KPsKgDQo+ICsJaW50ICgqcmVhZF9y
ZWdfMzIpKHN0cnVjdCBkZXZpY2UgKmRldiwgdTE2IHJlZ19hZGRyZXNzLCB1MzIgKnZhbCk7DQo+
ICsJaW50ICgqd3JpdGVfcmVnXzgpKHN0cnVjdCBkZXZpY2UgKmRldiwgdTE2IHJlZ19hZGRyZXNz
LCB1OCB2YWx1ZSk7DQoNCg0KQW55IHBhcnRpY3VsYXIgcmVhc29uIGZvciB1c2luZyB2YWwgdnMg
dmFsdWU/IEkgZ2V0IHRoYXQgb25lIGlzIGEgcG9pbnRlcg0KYW5kIGFub3RoZXIgYSBwbGFpbiB0
eXBlLCBidXQgSSB0aGluayB0aGUgbmFtZSBzaG91bGQgYmUgdGhlIHNhbWUuDQoNCnRoYW5rcywN
CkRhbmllbC4NCg0K

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Baluta <daniel.baluta@nxp.com>
To: "lars@metafoo.de" <lars@metafoo.de>,
	"knaack.h@gmx.de" <knaack.h@gmx.de>,
	"rodrigosiqueiramelo@gmail.com" <rodrigosiqueiramelo@gmail.com>,
	"Michael.Hennerich@analog.com" <Michael.Hennerich@analog.com>,
	"jic23@kernel.org" <jic23@kernel.org>,
	"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH] staging: iio/meter: add name to function definition arguments
Date: Fri, 16 Feb 2018 12:56:36 +0000	[thread overview]
Message-ID: <1518785796.9517.25.camel@nxp.com> (raw)
In-Reply-To: <20180216125041.qfvg7xtpulc54tk6@smtp.gmail.com>

Hi Rodrigo,

I think this is a nice finding. One comment inline:

On Vi, 2018-02-16 at 10:50 -0200, rodrigosiqueira wrote:
> This patch fixes the checkpatch.pl warning:
> 
> drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition
> argument 'struct device *' should also have an identifier name...
> 
> +	int (*read_reg_32)(struct device *dev, u16 reg_address, u32 *val);
> +	int (*write_reg_8)(struct device *dev, u16 reg_address, u8 value);


Any particular reason for using val vs value? I get that one is a pointer
and another a plain type, but I think the name should be the same.

thanks,
Daniel.


  reply	other threads:[~2018-02-16 12:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-16 12:50 [PATCH] staging: iio/meter: add name to function definition arguments rodrigosiqueira
2018-02-16 12:50 ` rodrigosiqueira
2018-02-16 12:56 ` Daniel Baluta [this message]
2018-02-16 12:56   ` Daniel Baluta
2018-02-16 13:16   ` Rodrigo Siqueira
2018-02-17 14:09     ` Jonathan Cameron
2018-02-19 11:52       ` Rodrigo Siqueira
2018-02-19 11:52         ` Rodrigo Siqueira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518785796.9517.25.camel@nxp.com \
    --to=daniel.baluta@nxp.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=rodrigosiqueiramelo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.