* [PATCH] multipathd: add lock protection for cli_list_status
@ 2018-02-23 9:58 Chongyun Wu
2018-02-26 13:52 ` Martin Wilck
0 siblings, 1 reply; 2+ messages in thread
From: Chongyun Wu @ 2018-02-23 9:58 UTC (permalink / raw)
To: dm-devel@redhat.com; +Cc: Guozhonghua, Changwei Ge, Changlimin
cli_list_status will access vecs->pathvec which should have lock
protection, otherwise might get inconsistent data or other
problem.
Signed-off-by: Chongyun Wu <wu.chongyun@h3c.com>
---
multipathd/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/multipathd/main.c b/multipathd/main.c
index e74a448..b4e15eb 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -1204,7 +1204,7 @@ uxlsnrloop (void * ap)
set_handler_callback(LIST+PATHS+RAW+FMT, cli_list_paths_raw);
set_handler_callback(LIST+PATH, cli_list_path);
set_handler_callback(LIST+MAPS, cli_list_maps);
- set_unlocked_handler_callback(LIST+STATUS, cli_list_status);
+ set_handler_callback(LIST+STATUS, cli_list_status);
set_unlocked_handler_callback(LIST+DAEMON, cli_list_daemon);
set_handler_callback(LIST+MAPS+STATUS, cli_list_maps_status);
set_handler_callback(LIST+MAPS+STATS, cli_list_maps_stats);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] multipathd: add lock protection for cli_list_status
2018-02-23 9:58 [PATCH] multipathd: add lock protection for cli_list_status Chongyun Wu
@ 2018-02-26 13:52 ` Martin Wilck
0 siblings, 0 replies; 2+ messages in thread
From: Martin Wilck @ 2018-02-26 13:52 UTC (permalink / raw)
To: Chongyun Wu, dm-devel@redhat.com; +Cc: Guozhonghua, Changwei Ge, Changlimin
On Fri, 2018-02-23 at 09:58 +0000, Chongyun Wu wrote:
> cli_list_status will access vecs->pathvec which should have lock
> protection, otherwise might get inconsistent data or other
> problem.
>
> Signed-off-by: Chongyun Wu <wu.chongyun@h3c.com>
Reviewed-by: Martin Wilck <mwilck@suse.com>
> ---
> multipathd/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/multipathd/main.c b/multipathd/main.c
> index e74a448..b4e15eb 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -1204,7 +1204,7 @@ uxlsnrloop (void * ap)
> set_handler_callback(LIST+PATHS+RAW+FMT,
> cli_list_paths_raw);
> set_handler_callback(LIST+PATH, cli_list_path);
> set_handler_callback(LIST+MAPS, cli_list_maps);
> - set_unlocked_handler_callback(LIST+STATUS, cli_list_status);
> + set_handler_callback(LIST+STATUS, cli_list_status);
> set_unlocked_handler_callback(LIST+DAEMON,
> cli_list_daemon);
> set_handler_callback(LIST+MAPS+STATUS,
> cli_list_maps_status);
> set_handler_callback(LIST+MAPS+STATS, cli_list_maps_stats);
--
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-26 13:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-23 9:58 [PATCH] multipathd: add lock protection for cli_list_status Chongyun Wu
2018-02-26 13:52 ` Martin Wilck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.