diff for duplicates of <1520265396.3152.27.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index c6f6059..efa4ef7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,23 +1,35 @@ -T24gTW9uLCAyMDE4LTAyLTI2IGF0IDE4OjQyICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6 -DQo+IE9uIE1vbiwgRmViIDI2LCAyMDE4IGF0IDQ6NTYgUE0sIEV1Z2VuaXkgUGFsdHNldg0KPiA8 -RXVnZW5peS5QYWx0c2V2QHN5bm9wc3lzLmNvbT4gd3JvdGU6DQo+IA0KPiA+ICsgICAgICAgY2hp -cC0+Y29yZV9jbGsgPSBkZXZtX2Nsa19nZXQoY2hpcC0+ZGV2LCAiY29yZS1jbGsiKTsNCj4gDQo+ -IERvZXMgdGhlIG5hbWUgY29tZSBmcm9tIGRhdGFzaGVldD8NCj4gDQo+ID4gKyAgICAgICBjaGlw -LT5jZmdyX2NsayA9IGRldm1fY2xrX2dldChjaGlwLT5kZXYsICJjZmdyLWNsayIpOw0KPiANCj4g -RGl0dG8/DQoNClllcywgdGhlc2UgbmFtZXMgY2FtZSBmcm9tIGRhdGFzaGVldC4NCg0KPiA+ICsg -ICAgICAgfQ0KPiA+ICsgICAgICAgLyogRW5hYmxlIGNsayBiZWZvcmUgYWNjZXNzaW5nIHRvIHJl -Z2lzdGVycyAqLw0KPiA+ICsgICAgICAgY2xrX3ByZXBhcmVfZW5hYmxlKGNoaXAtPmNmZ3JfY2xr -KTsNCj4gPiArICAgICAgIGNsa19wcmVwYXJlX2VuYWJsZShjaGlwLT5jb3JlX2Nsayk7DQo+IA0K -PiBFYWNoIG9mIHRoZW0gbWF5IGZhaWwuIElzIGl0IG9rYXk/DQoNCkFzIGl0IGlzIGRyaXZlciBy -ZW1vdmUgY2FsbGJhY2sgSSBndWVzcyBpdCBpcyBva2F5Lg0KDQo+ID4gK3N0YXRpYyBjb25zdCBz -dHJ1Y3QgZGV2X3BtX29wcyBkd19heGlfZG1hX3BtX29wcyA9IHsNCj4gPiArICAgICAgIFNFVF9S -VU5USU1FX1BNX09QUyhheGlfZG1hX3J1bnRpbWVfc3VzcGVuZCwgYXhpX2RtYV9ydW50aW1lX3Jl -c3VtZSwgTlVMTCkNCj4gPiArfTsNCj4gDQo+IE5vIHN5c3RlbSBzdXNwZW5kPw0KDQpBcmUgeW91 -IHRhbGtpbmcgYWJvdXQgU0VUX1NZU1RFTV9TTEVFUF9QTV9PUFM/DQpJIGRvbid0IGltcGxlbWVu -dCB0aGVzZSBPUFMgYXMgd2UgZG9uJ3QgaGF2ZSBhbnkgcGxhdGZvcm0gd2hpY2ggaGFzIERXIEFY -SSBETUFDDQphbmQgc3VwcG9ydHMgc2xlZXBpbmcgLSBzbyBJIGNhbid0IHRlc3QgdGhlbS4NCg0K -LS0gDQogRXVnZW5peSBQYWx0c2V2 ---- -To unsubscribe from this list: send the line "unsubscribe dmaengine" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html +On Mon, 2018-02-26@18:42 +0200, Andy Shevchenko wrote: +> On Mon, Feb 26, 2018 at 4:56 PM, Eugeniy Paltsev +> <Eugeniy.Paltsev@synopsys.com> wrote: +> +> > + chip->core_clk = devm_clk_get(chip->dev, "core-clk"); +> +> Does the name come from datasheet? +> +> > + chip->cfgr_clk = devm_clk_get(chip->dev, "cfgr-clk"); +> +> Ditto? + +Yes, these names came from datasheet. + +> > + } +> > + /* Enable clk before accessing to registers */ +> > + clk_prepare_enable(chip->cfgr_clk); +> > + clk_prepare_enable(chip->core_clk); +> +> Each of them may fail. Is it okay? + +As it is driver remove callback I guess it is okay. + +> > +static const struct dev_pm_ops dw_axi_dma_pm_ops = { +> > + SET_RUNTIME_PM_OPS(axi_dma_runtime_suspend, axi_dma_runtime_resume, NULL) +> > +}; +> +> No system suspend? + +Are you talking about SET_SYSTEM_SLEEP_PM_OPS? +I don't implement these OPS as we don't have any platform which has DW AXI DMAC +and supports sleeping - so I can't test them. + +-- + Eugeniy Paltsev diff --git a/a/content_digest b/N1/content_digest index 04c12b8..cbc7181 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,40 +1,46 @@ - "From\0Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>\0" - "Subject\0[v2,1/2] dmaengine: Introduce DW AXI DMAC driver\0" + "ref\020180226145628.11892-1-Eugeniy.Paltsev@synopsys.com\0" + "ref\020180226145628.11892-2-Eugeniy.Paltsev@synopsys.com\0" + "ref\0CAHp75Vc6KtppecYJBtuXTGCzXySOUZiYqxBfb6w69f1j3J0jDQ@mail.gmail.com\0" + "From\0Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev)\0" + "Subject\0[PATCH v2 1/2] dmaengine: Introduce DW AXI DMAC driver\0" "Date\0Mon, 5 Mar 2018 15:56:37 +0000\0" - "To\0andy.shevchenko@gmail.com <andy.shevchenko@gmail.com>\0" - "Cc\0vinod.koul@intel.com <vinod.koul@intel.com>" - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> - robh+dt@kernel.org <robh+dt@kernel.org> - Alexey.Brodkin@synopsys.com <Alexey.Brodkin@synopsys.com> - devicetree@vger.kernel.org <devicetree@vger.kernel.org> - linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org> - dan.j.williams@intel.com <dan.j.williams@intel.com> - dmaengine@vger.kernel.org <dmaengine@vger.kernel.org> - " wan.ahmad.zainie.wan.mohamad@intel.com <wan.ahmad.zainie.wan.mohamad@intel.com>\0" + "To\0linux-snps-arc@lists.infradead.org\0" "\00:1\0" "b\0" - "T24gTW9uLCAyMDE4LTAyLTI2IGF0IDE4OjQyICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6\n" - "DQo+IE9uIE1vbiwgRmViIDI2LCAyMDE4IGF0IDQ6NTYgUE0sIEV1Z2VuaXkgUGFsdHNldg0KPiA8\n" - "RXVnZW5peS5QYWx0c2V2QHN5bm9wc3lzLmNvbT4gd3JvdGU6DQo+IA0KPiA+ICsgICAgICAgY2hp\n" - "cC0+Y29yZV9jbGsgPSBkZXZtX2Nsa19nZXQoY2hpcC0+ZGV2LCAiY29yZS1jbGsiKTsNCj4gDQo+\n" - "IERvZXMgdGhlIG5hbWUgY29tZSBmcm9tIGRhdGFzaGVldD8NCj4gDQo+ID4gKyAgICAgICBjaGlw\n" - "LT5jZmdyX2NsayA9IGRldm1fY2xrX2dldChjaGlwLT5kZXYsICJjZmdyLWNsayIpOw0KPiANCj4g\n" - "RGl0dG8/DQoNClllcywgdGhlc2UgbmFtZXMgY2FtZSBmcm9tIGRhdGFzaGVldC4NCg0KPiA+ICsg\n" - "ICAgICAgfQ0KPiA+ICsgICAgICAgLyogRW5hYmxlIGNsayBiZWZvcmUgYWNjZXNzaW5nIHRvIHJl\n" - "Z2lzdGVycyAqLw0KPiA+ICsgICAgICAgY2xrX3ByZXBhcmVfZW5hYmxlKGNoaXAtPmNmZ3JfY2xr\n" - "KTsNCj4gPiArICAgICAgIGNsa19wcmVwYXJlX2VuYWJsZShjaGlwLT5jb3JlX2Nsayk7DQo+IA0K\n" - "PiBFYWNoIG9mIHRoZW0gbWF5IGZhaWwuIElzIGl0IG9rYXk/DQoNCkFzIGl0IGlzIGRyaXZlciBy\n" - "ZW1vdmUgY2FsbGJhY2sgSSBndWVzcyBpdCBpcyBva2F5Lg0KDQo+ID4gK3N0YXRpYyBjb25zdCBz\n" - "dHJ1Y3QgZGV2X3BtX29wcyBkd19heGlfZG1hX3BtX29wcyA9IHsNCj4gPiArICAgICAgIFNFVF9S\n" - "VU5USU1FX1BNX09QUyhheGlfZG1hX3J1bnRpbWVfc3VzcGVuZCwgYXhpX2RtYV9ydW50aW1lX3Jl\n" - "c3VtZSwgTlVMTCkNCj4gPiArfTsNCj4gDQo+IE5vIHN5c3RlbSBzdXNwZW5kPw0KDQpBcmUgeW91\n" - "IHRhbGtpbmcgYWJvdXQgU0VUX1NZU1RFTV9TTEVFUF9QTV9PUFM/DQpJIGRvbid0IGltcGxlbWVu\n" - "dCB0aGVzZSBPUFMgYXMgd2UgZG9uJ3QgaGF2ZSBhbnkgcGxhdGZvcm0gd2hpY2ggaGFzIERXIEFY\n" - "SSBETUFDDQphbmQgc3VwcG9ydHMgc2xlZXBpbmcgLSBzbyBJIGNhbid0IHRlc3QgdGhlbS4NCg0K\n" - "LS0gDQogRXVnZW5peSBQYWx0c2V2\n" - "---\n" - "To unsubscribe from this list: send the line \"unsubscribe dmaengine\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + "On Mon, 2018-02-26@18:42 +0200, Andy Shevchenko wrote:\n" + "> On Mon, Feb 26, 2018 at 4:56 PM, Eugeniy Paltsev\n" + "> <Eugeniy.Paltsev@synopsys.com> wrote:\n" + "> \n" + "> > + chip->core_clk = devm_clk_get(chip->dev, \"core-clk\");\n" + "> \n" + "> Does the name come from datasheet?\n" + "> \n" + "> > + chip->cfgr_clk = devm_clk_get(chip->dev, \"cfgr-clk\");\n" + "> \n" + "> Ditto?\n" + "\n" + "Yes, these names came from datasheet.\n" + "\n" + "> > + }\n" + "> > + /* Enable clk before accessing to registers */\n" + "> > + clk_prepare_enable(chip->cfgr_clk);\n" + "> > + clk_prepare_enable(chip->core_clk);\n" + "> \n" + "> Each of them may fail. Is it okay?\n" + "\n" + "As it is driver remove callback I guess it is okay.\n" + "\n" + "> > +static const struct dev_pm_ops dw_axi_dma_pm_ops = {\n" + "> > + SET_RUNTIME_PM_OPS(axi_dma_runtime_suspend, axi_dma_runtime_resume, NULL)\n" + "> > +};\n" + "> \n" + "> No system suspend?\n" + "\n" + "Are you talking about SET_SYSTEM_SLEEP_PM_OPS?\n" + "I don't implement these OPS as we don't have any platform which has DW AXI DMAC\n" + "and supports sleeping - so I can't test them.\n" + "\n" + "-- \n" + Eugeniy Paltsev -0570a77060f47dd51ce2167ab36d564c89e166c2c16f8f5ff6dd7c55307ce667 +87d845e77442315fbc0ece925966090a3a685574965b8cb91c52ee29bcd784fc
diff --git a/a/1.txt b/N2/1.txt index c6f6059..51db44c 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,23 +1,35 @@ -T24gTW9uLCAyMDE4LTAyLTI2IGF0IDE4OjQyICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6 -DQo+IE9uIE1vbiwgRmViIDI2LCAyMDE4IGF0IDQ6NTYgUE0sIEV1Z2VuaXkgUGFsdHNldg0KPiA8 -RXVnZW5peS5QYWx0c2V2QHN5bm9wc3lzLmNvbT4gd3JvdGU6DQo+IA0KPiA+ICsgICAgICAgY2hp -cC0+Y29yZV9jbGsgPSBkZXZtX2Nsa19nZXQoY2hpcC0+ZGV2LCAiY29yZS1jbGsiKTsNCj4gDQo+ -IERvZXMgdGhlIG5hbWUgY29tZSBmcm9tIGRhdGFzaGVldD8NCj4gDQo+ID4gKyAgICAgICBjaGlw -LT5jZmdyX2NsayA9IGRldm1fY2xrX2dldChjaGlwLT5kZXYsICJjZmdyLWNsayIpOw0KPiANCj4g -RGl0dG8/DQoNClllcywgdGhlc2UgbmFtZXMgY2FtZSBmcm9tIGRhdGFzaGVldC4NCg0KPiA+ICsg -ICAgICAgfQ0KPiA+ICsgICAgICAgLyogRW5hYmxlIGNsayBiZWZvcmUgYWNjZXNzaW5nIHRvIHJl -Z2lzdGVycyAqLw0KPiA+ICsgICAgICAgY2xrX3ByZXBhcmVfZW5hYmxlKGNoaXAtPmNmZ3JfY2xr -KTsNCj4gPiArICAgICAgIGNsa19wcmVwYXJlX2VuYWJsZShjaGlwLT5jb3JlX2Nsayk7DQo+IA0K -PiBFYWNoIG9mIHRoZW0gbWF5IGZhaWwuIElzIGl0IG9rYXk/DQoNCkFzIGl0IGlzIGRyaXZlciBy -ZW1vdmUgY2FsbGJhY2sgSSBndWVzcyBpdCBpcyBva2F5Lg0KDQo+ID4gK3N0YXRpYyBjb25zdCBz -dHJ1Y3QgZGV2X3BtX29wcyBkd19heGlfZG1hX3BtX29wcyA9IHsNCj4gPiArICAgICAgIFNFVF9S -VU5USU1FX1BNX09QUyhheGlfZG1hX3J1bnRpbWVfc3VzcGVuZCwgYXhpX2RtYV9ydW50aW1lX3Jl -c3VtZSwgTlVMTCkNCj4gPiArfTsNCj4gDQo+IE5vIHN5c3RlbSBzdXNwZW5kPw0KDQpBcmUgeW91 -IHRhbGtpbmcgYWJvdXQgU0VUX1NZU1RFTV9TTEVFUF9QTV9PUFM/DQpJIGRvbid0IGltcGxlbWVu -dCB0aGVzZSBPUFMgYXMgd2UgZG9uJ3QgaGF2ZSBhbnkgcGxhdGZvcm0gd2hpY2ggaGFzIERXIEFY -SSBETUFDDQphbmQgc3VwcG9ydHMgc2xlZXBpbmcgLSBzbyBJIGNhbid0IHRlc3QgdGhlbS4NCg0K -LS0gDQogRXVnZW5peSBQYWx0c2V2 ---- -To unsubscribe from this list: send the line "unsubscribe dmaengine" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html +On Mon, 2018-02-26 at 18:42 +0200, Andy Shevchenko wrote: +> On Mon, Feb 26, 2018 at 4:56 PM, Eugeniy Paltsev +> <Eugeniy.Paltsev@synopsys.com> wrote: +> +> > + chip->core_clk = devm_clk_get(chip->dev, "core-clk"); +> +> Does the name come from datasheet? +> +> > + chip->cfgr_clk = devm_clk_get(chip->dev, "cfgr-clk"); +> +> Ditto? + +Yes, these names came from datasheet. + +> > + } +> > + /* Enable clk before accessing to registers */ +> > + clk_prepare_enable(chip->cfgr_clk); +> > + clk_prepare_enable(chip->core_clk); +> +> Each of them may fail. Is it okay? + +As it is driver remove callback I guess it is okay. + +> > +static const struct dev_pm_ops dw_axi_dma_pm_ops = { +> > + SET_RUNTIME_PM_OPS(axi_dma_runtime_suspend, axi_dma_runtime_resume, NULL) +> > +}; +> +> No system suspend? + +Are you talking about SET_SYSTEM_SLEEP_PM_OPS? +I don't implement these OPS as we don't have any platform which has DW AXI DMAC +and supports sleeping - so I can't test them. + +-- + Eugeniy Paltsev diff --git a/a/content_digest b/N2/content_digest index 04c12b8..a56ce93 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,5 +1,8 @@ + "ref\020180226145628.11892-1-Eugeniy.Paltsev@synopsys.com\0" + "ref\020180226145628.11892-2-Eugeniy.Paltsev@synopsys.com\0" + "ref\0CAHp75Vc6KtppecYJBtuXTGCzXySOUZiYqxBfb6w69f1j3J0jDQ@mail.gmail.com\0" "From\0Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>\0" - "Subject\0[v2,1/2] dmaengine: Introduce DW AXI DMAC driver\0" + "Subject\0Re: [PATCH v2 1/2] dmaengine: Introduce DW AXI DMAC driver\0" "Date\0Mon, 5 Mar 2018 15:56:37 +0000\0" "To\0andy.shevchenko@gmail.com <andy.shevchenko@gmail.com>\0" "Cc\0vinod.koul@intel.com <vinod.koul@intel.com>" @@ -13,28 +16,40 @@ " wan.ahmad.zainie.wan.mohamad@intel.com <wan.ahmad.zainie.wan.mohamad@intel.com>\0" "\00:1\0" "b\0" - "T24gTW9uLCAyMDE4LTAyLTI2IGF0IDE4OjQyICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6\n" - "DQo+IE9uIE1vbiwgRmViIDI2LCAyMDE4IGF0IDQ6NTYgUE0sIEV1Z2VuaXkgUGFsdHNldg0KPiA8\n" - "RXVnZW5peS5QYWx0c2V2QHN5bm9wc3lzLmNvbT4gd3JvdGU6DQo+IA0KPiA+ICsgICAgICAgY2hp\n" - "cC0+Y29yZV9jbGsgPSBkZXZtX2Nsa19nZXQoY2hpcC0+ZGV2LCAiY29yZS1jbGsiKTsNCj4gDQo+\n" - "IERvZXMgdGhlIG5hbWUgY29tZSBmcm9tIGRhdGFzaGVldD8NCj4gDQo+ID4gKyAgICAgICBjaGlw\n" - "LT5jZmdyX2NsayA9IGRldm1fY2xrX2dldChjaGlwLT5kZXYsICJjZmdyLWNsayIpOw0KPiANCj4g\n" - "RGl0dG8/DQoNClllcywgdGhlc2UgbmFtZXMgY2FtZSBmcm9tIGRhdGFzaGVldC4NCg0KPiA+ICsg\n" - "ICAgICAgfQ0KPiA+ICsgICAgICAgLyogRW5hYmxlIGNsayBiZWZvcmUgYWNjZXNzaW5nIHRvIHJl\n" - "Z2lzdGVycyAqLw0KPiA+ICsgICAgICAgY2xrX3ByZXBhcmVfZW5hYmxlKGNoaXAtPmNmZ3JfY2xr\n" - "KTsNCj4gPiArICAgICAgIGNsa19wcmVwYXJlX2VuYWJsZShjaGlwLT5jb3JlX2Nsayk7DQo+IA0K\n" - "PiBFYWNoIG9mIHRoZW0gbWF5IGZhaWwuIElzIGl0IG9rYXk/DQoNCkFzIGl0IGlzIGRyaXZlciBy\n" - "ZW1vdmUgY2FsbGJhY2sgSSBndWVzcyBpdCBpcyBva2F5Lg0KDQo+ID4gK3N0YXRpYyBjb25zdCBz\n" - "dHJ1Y3QgZGV2X3BtX29wcyBkd19heGlfZG1hX3BtX29wcyA9IHsNCj4gPiArICAgICAgIFNFVF9S\n" - "VU5USU1FX1BNX09QUyhheGlfZG1hX3J1bnRpbWVfc3VzcGVuZCwgYXhpX2RtYV9ydW50aW1lX3Jl\n" - "c3VtZSwgTlVMTCkNCj4gPiArfTsNCj4gDQo+IE5vIHN5c3RlbSBzdXNwZW5kPw0KDQpBcmUgeW91\n" - "IHRhbGtpbmcgYWJvdXQgU0VUX1NZU1RFTV9TTEVFUF9QTV9PUFM/DQpJIGRvbid0IGltcGxlbWVu\n" - "dCB0aGVzZSBPUFMgYXMgd2UgZG9uJ3QgaGF2ZSBhbnkgcGxhdGZvcm0gd2hpY2ggaGFzIERXIEFY\n" - "SSBETUFDDQphbmQgc3VwcG9ydHMgc2xlZXBpbmcgLSBzbyBJIGNhbid0IHRlc3QgdGhlbS4NCg0K\n" - "LS0gDQogRXVnZW5peSBQYWx0c2V2\n" - "---\n" - "To unsubscribe from this list: send the line \"unsubscribe dmaengine\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + "On Mon, 2018-02-26 at 18:42 +0200, Andy Shevchenko wrote:\n" + "> On Mon, Feb 26, 2018 at 4:56 PM, Eugeniy Paltsev\n" + "> <Eugeniy.Paltsev@synopsys.com> wrote:\n" + "> \n" + "> > + chip->core_clk = devm_clk_get(chip->dev, \"core-clk\");\n" + "> \n" + "> Does the name come from datasheet?\n" + "> \n" + "> > + chip->cfgr_clk = devm_clk_get(chip->dev, \"cfgr-clk\");\n" + "> \n" + "> Ditto?\n" + "\n" + "Yes, these names came from datasheet.\n" + "\n" + "> > + }\n" + "> > + /* Enable clk before accessing to registers */\n" + "> > + clk_prepare_enable(chip->cfgr_clk);\n" + "> > + clk_prepare_enable(chip->core_clk);\n" + "> \n" + "> Each of them may fail. Is it okay?\n" + "\n" + "As it is driver remove callback I guess it is okay.\n" + "\n" + "> > +static const struct dev_pm_ops dw_axi_dma_pm_ops = {\n" + "> > + SET_RUNTIME_PM_OPS(axi_dma_runtime_suspend, axi_dma_runtime_resume, NULL)\n" + "> > +};\n" + "> \n" + "> No system suspend?\n" + "\n" + "Are you talking about SET_SYSTEM_SLEEP_PM_OPS?\n" + "I don't implement these OPS as we don't have any platform which has DW AXI DMAC\n" + "and supports sleeping - so I can't test them.\n" + "\n" + "-- \n" + Eugeniy Paltsev -0570a77060f47dd51ce2167ab36d564c89e166c2c16f8f5ff6dd7c55307ce667 +6872884aa52b92752164907881b7a9efd20cfb38450a37642cd1e12bed68b0b1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.