From: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
To: "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>
Cc: "vinod.koul@intel.com" <vinod.koul@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Alexey.Brodkin@synopsys.com" <Alexey.Brodkin@synopsys.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"wan.ahmad.zainie.wan.mohamad@intel.com"
<wan.ahmad.zainie.wan.mohamad@intel.com>
Subject: [v2,1/2] dmaengine: Introduce DW AXI DMAC driver
Date: Mon, 5 Mar 2018 15:56:37 +0000 [thread overview]
Message-ID: <1520265396.3152.27.camel@synopsys.com> (raw)
T24gTW9uLCAyMDE4LTAyLTI2IGF0IDE4OjQyICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6
DQo+IE9uIE1vbiwgRmViIDI2LCAyMDE4IGF0IDQ6NTYgUE0sIEV1Z2VuaXkgUGFsdHNldg0KPiA8
RXVnZW5peS5QYWx0c2V2QHN5bm9wc3lzLmNvbT4gd3JvdGU6DQo+IA0KPiA+ICsgICAgICAgY2hp
cC0+Y29yZV9jbGsgPSBkZXZtX2Nsa19nZXQoY2hpcC0+ZGV2LCAiY29yZS1jbGsiKTsNCj4gDQo+
IERvZXMgdGhlIG5hbWUgY29tZSBmcm9tIGRhdGFzaGVldD8NCj4gDQo+ID4gKyAgICAgICBjaGlw
LT5jZmdyX2NsayA9IGRldm1fY2xrX2dldChjaGlwLT5kZXYsICJjZmdyLWNsayIpOw0KPiANCj4g
RGl0dG8/DQoNClllcywgdGhlc2UgbmFtZXMgY2FtZSBmcm9tIGRhdGFzaGVldC4NCg0KPiA+ICsg
ICAgICAgfQ0KPiA+ICsgICAgICAgLyogRW5hYmxlIGNsayBiZWZvcmUgYWNjZXNzaW5nIHRvIHJl
Z2lzdGVycyAqLw0KPiA+ICsgICAgICAgY2xrX3ByZXBhcmVfZW5hYmxlKGNoaXAtPmNmZ3JfY2xr
KTsNCj4gPiArICAgICAgIGNsa19wcmVwYXJlX2VuYWJsZShjaGlwLT5jb3JlX2Nsayk7DQo+IA0K
PiBFYWNoIG9mIHRoZW0gbWF5IGZhaWwuIElzIGl0IG9rYXk/DQoNCkFzIGl0IGlzIGRyaXZlciBy
ZW1vdmUgY2FsbGJhY2sgSSBndWVzcyBpdCBpcyBva2F5Lg0KDQo+ID4gK3N0YXRpYyBjb25zdCBz
dHJ1Y3QgZGV2X3BtX29wcyBkd19heGlfZG1hX3BtX29wcyA9IHsNCj4gPiArICAgICAgIFNFVF9S
VU5USU1FX1BNX09QUyhheGlfZG1hX3J1bnRpbWVfc3VzcGVuZCwgYXhpX2RtYV9ydW50aW1lX3Jl
c3VtZSwgTlVMTCkNCj4gPiArfTsNCj4gDQo+IE5vIHN5c3RlbSBzdXNwZW5kPw0KDQpBcmUgeW91
IHRhbGtpbmcgYWJvdXQgU0VUX1NZU1RFTV9TTEVFUF9QTV9PUFM/DQpJIGRvbid0IGltcGxlbWVu
dCB0aGVzZSBPUFMgYXMgd2UgZG9uJ3QgaGF2ZSBhbnkgcGxhdGZvcm0gd2hpY2ggaGFzIERXIEFY
SSBETUFDDQphbmQgc3VwcG9ydHMgc2xlZXBpbmcgLSBzbyBJIGNhbid0IHRlc3QgdGhlbS4NCg0K
LS0gDQogRXVnZW5peSBQYWx0c2V2
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v2 1/2] dmaengine: Introduce DW AXI DMAC driver
Date: Mon, 5 Mar 2018 15:56:37 +0000 [thread overview]
Message-ID: <1520265396.3152.27.camel@synopsys.com> (raw)
In-Reply-To: <CAHp75Vc6KtppecYJBtuXTGCzXySOUZiYqxBfb6w69f1j3J0jDQ@mail.gmail.com>
On Mon, 2018-02-26@18:42 +0200, Andy Shevchenko wrote:
> On Mon, Feb 26, 2018 at 4:56 PM, Eugeniy Paltsev
> <Eugeniy.Paltsev@synopsys.com> wrote:
>
> > + chip->core_clk = devm_clk_get(chip->dev, "core-clk");
>
> Does the name come from datasheet?
>
> > + chip->cfgr_clk = devm_clk_get(chip->dev, "cfgr-clk");
>
> Ditto?
Yes, these names came from datasheet.
> > + }
> > + /* Enable clk before accessing to registers */
> > + clk_prepare_enable(chip->cfgr_clk);
> > + clk_prepare_enable(chip->core_clk);
>
> Each of them may fail. Is it okay?
As it is driver remove callback I guess it is okay.
> > +static const struct dev_pm_ops dw_axi_dma_pm_ops = {
> > + SET_RUNTIME_PM_OPS(axi_dma_runtime_suspend, axi_dma_runtime_resume, NULL)
> > +};
>
> No system suspend?
Are you talking about SET_SYSTEM_SLEEP_PM_OPS?
I don't implement these OPS as we don't have any platform which has DW AXI DMAC
and supports sleeping - so I can't test them.
--
Eugeniy Paltsev
WARNING: multiple messages have this Message-ID (diff)
From: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
To: "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>
Cc: "vinod.koul@intel.com" <vinod.koul@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Alexey.Brodkin@synopsys.com" <Alexey.Brodkin@synopsys.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"wan.ahmad.zainie.wan.mohamad@intel.com"
<wan.ahmad.zainie.wan.mohamad@intel.com>
Subject: Re: [PATCH v2 1/2] dmaengine: Introduce DW AXI DMAC driver
Date: Mon, 5 Mar 2018 15:56:37 +0000 [thread overview]
Message-ID: <1520265396.3152.27.camel@synopsys.com> (raw)
In-Reply-To: <CAHp75Vc6KtppecYJBtuXTGCzXySOUZiYqxBfb6w69f1j3J0jDQ@mail.gmail.com>
On Mon, 2018-02-26 at 18:42 +0200, Andy Shevchenko wrote:
> On Mon, Feb 26, 2018 at 4:56 PM, Eugeniy Paltsev
> <Eugeniy.Paltsev@synopsys.com> wrote:
>
> > + chip->core_clk = devm_clk_get(chip->dev, "core-clk");
>
> Does the name come from datasheet?
>
> > + chip->cfgr_clk = devm_clk_get(chip->dev, "cfgr-clk");
>
> Ditto?
Yes, these names came from datasheet.
> > + }
> > + /* Enable clk before accessing to registers */
> > + clk_prepare_enable(chip->cfgr_clk);
> > + clk_prepare_enable(chip->core_clk);
>
> Each of them may fail. Is it okay?
As it is driver remove callback I guess it is okay.
> > +static const struct dev_pm_ops dw_axi_dma_pm_ops = {
> > + SET_RUNTIME_PM_OPS(axi_dma_runtime_suspend, axi_dma_runtime_resume, NULL)
> > +};
>
> No system suspend?
Are you talking about SET_SYSTEM_SLEEP_PM_OPS?
I don't implement these OPS as we don't have any platform which has DW AXI DMAC
and supports sleeping - so I can't test them.
--
Eugeniy Paltsev
next reply other threads:[~2018-03-05 15:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 15:56 Eugeniy Paltsev [this message]
2018-03-05 15:56 ` [PATCH v2 1/2] dmaengine: Introduce DW AXI DMAC driver Eugeniy Paltsev
2018-03-05 15:56 ` Eugeniy Paltsev
-- strict thread matches above, loose matches on Subject: below --
2018-03-05 21:49 [v2,2/2] dt-bindings: Document the Synopsys DW AXI DMA bindings Alexey Brodkin
2018-03-05 21:49 ` [PATCH v2 2/2] " Alexey Brodkin
2018-03-05 21:49 ` Alexey Brodkin
2018-03-05 21:07 [v2,2/2] " Rob Herring
2018-03-05 21:07 ` [PATCH v2 2/2] " Rob Herring
2018-03-05 21:07 ` Rob Herring
2018-03-05 15:26 [v2,1/2] dmaengine: Introduce DW AXI DMAC driver Eugeniy Paltsev
2018-03-05 15:26 ` [PATCH v2 1/2] " Eugeniy Paltsev
2018-03-05 15:26 ` Eugeniy Paltsev
2018-03-05 15:26 ` Eugeniy Paltsev
2018-03-05 5:32 [v2,2/2] dt-bindings: Document the Synopsys DW AXI DMA bindings Vinod Koul
2018-03-05 5:32 ` [PATCH v2 2/2] " Vinod Koul
2018-03-05 5:32 ` Vinod Koul
2018-03-02 8:32 [v2,2/2] " Alexey Brodkin
2018-03-02 8:32 ` [PATCH v2 2/2] " Alexey Brodkin
2018-03-02 8:32 ` Alexey Brodkin
2018-03-02 8:14 [v2,2/2] " Vinod Koul
2018-03-02 8:14 ` [PATCH v2 2/2] " Vinod Koul
2018-03-02 8:14 ` Vinod Koul
2018-03-02 8:13 [v2,1/2] dmaengine: Introduce DW AXI DMAC driver Vinod Koul
2018-03-02 8:13 ` [PATCH v2 1/2] " Vinod Koul
2018-03-02 8:13 ` Vinod Koul
2018-02-26 16:42 [v2,1/2] " Andy Shevchenko
2018-02-26 16:42 ` [PATCH v2 1/2] " Andy Shevchenko
2018-02-26 16:42 ` Andy Shevchenko
2018-02-26 14:56 [v2,2/2] dt-bindings: Document the Synopsys DW AXI DMA bindings Eugeniy Paltsev
2018-02-26 14:56 ` [PATCH v2 2/2] " Eugeniy Paltsev
2018-02-26 14:56 ` Eugeniy Paltsev
2018-02-26 14:56 [v2,1/2] dmaengine: Introduce DW AXI DMAC driver Eugeniy Paltsev
2018-02-26 14:56 ` [PATCH v2 1/2] " Eugeniy Paltsev
2018-02-26 14:56 ` Eugeniy Paltsev
2018-02-26 14:56 ` Eugeniy Paltsev
2018-02-26 14:56 [PATCH v2 0/2] " Eugeniy Paltsev
2018-02-26 14:56 ` Eugeniy Paltsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520265396.3152.27.camel@synopsys.com \
--to=eugeniy.paltsev@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=andy.shevchenko@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vinod.koul@intel.com \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.