From: Paulo Zanoni <paulo.r.zanoni@intel.com>
To: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/icl: do not save DDI A/E sharing bit for ICL
Date: Tue, 06 Mar 2018 11:42:26 -0300 [thread overview]
Message-ID: <1520347346.2532.7.camel@intel.com> (raw)
In-Reply-To: <20180306104155.3526-1-jani.nikula@intel.com>
Em Ter, 2018-03-06 às 12:41 +0200, Jani Nikula escreveu:
> We don't want to preserve the DDI A 4 lane bit on ICL.
>
Why not review https://patchwork.freedesktop.org/patch/206118/ instead?
:)
> Fixes: 3d2011cfa41f ("drm/i915/icl: remove port A/E lane sharing
> limitation.")
> Cc: Mahesh Kumar <mahesh1.kumar@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> b/drivers/gpu/drm/i915/intel_ddi.c
> index bfdaa5d86861..66417dd24bfc 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2932,9 +2932,12 @@ void intel_ddi_init(struct drm_i915_private
> *dev_priv, enum port port)
> intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
> intel_encoder->cloneable = 0;
>
> - intel_dig_port->saved_port_bits =
> I915_READ(DDI_BUF_CTL(port)) &
> - (DDI_BUF_PORT_REVERSAL |
> - DDI_A_4_LANES);
> + if (INTEL_GEN(dev_priv) >= 11)
> + intel_dig_port->saved_port_bits =
> I915_READ(DDI_BUF_CTL(port)) &
> + DDI_BUF_PORT_REVERSAL;
> + else
> + intel_dig_port->saved_port_bits =
> I915_READ(DDI_BUF_CTL(port)) &
> + (DDI_BUF_PORT_REVERSAL | DDI_A_4_LANES);
> intel_dig_port->dp.output_reg = INVALID_MMIO_REG;
> intel_dig_port->max_lanes =
> intel_ddi_max_lanes(intel_dig_port);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-06 14:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 10:41 [PATCH] drm/i915/icl: do not save DDI A/E sharing bit for ICL Jani Nikula
2018-03-06 11:03 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-06 12:08 ` [PATCH] " Ville Syrjälä
2018-03-09 10:31 ` Jani Nikula
2018-03-06 14:42 ` Paulo Zanoni [this message]
2018-03-07 7:50 ` Jani Nikula
2018-03-06 14:47 ` ✗ Fi.CI.IGT: warning for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520347346.2532.7.camel@intel.com \
--to=paulo.r.zanoni@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.