From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915/icl: do not save DDI A/E sharing bit for ICL
Date: Tue, 6 Mar 2018 14:08:28 +0200 [thread overview]
Message-ID: <20180306120828.GE5453@intel.com> (raw)
In-Reply-To: <20180306104155.3526-1-jani.nikula@intel.com>
On Tue, Mar 06, 2018 at 12:41:55PM +0200, Jani Nikula wrote:
> We don't want to preserve the DDI A 4 lane bit on ICL.
>
> Fixes: 3d2011cfa41f ("drm/i915/icl: remove port A/E lane sharing limitation.")
> Cc: Mahesh Kumar <mahesh1.kumar@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index bfdaa5d86861..66417dd24bfc 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2932,9 +2932,12 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
> intel_encoder->cloneable = 0;
>
> - intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
> - (DDI_BUF_PORT_REVERSAL |
> - DDI_A_4_LANES);
> + if (INTEL_GEN(dev_priv) >= 11)
> + intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
> + DDI_BUF_PORT_REVERSAL;
> + else
> + intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
> + (DDI_BUF_PORT_REVERSAL | DDI_A_4_LANES);
> intel_dig_port->dp.output_reg = INVALID_MMIO_REG;
> intel_dig_port->max_lanes = intel_ddi_max_lanes(intel_dig_port);
>
> --
> 2.11.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-06 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 10:41 [PATCH] drm/i915/icl: do not save DDI A/E sharing bit for ICL Jani Nikula
2018-03-06 11:03 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-06 12:08 ` Ville Syrjälä [this message]
2018-03-09 10:31 ` [PATCH] " Jani Nikula
2018-03-06 14:42 ` Paulo Zanoni
2018-03-07 7:50 ` Jani Nikula
2018-03-06 14:47 ` ✗ Fi.CI.IGT: warning for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306120828.GE5453@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.