From: See, Chin Liang <chin.liang.see@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: gen5: Enabling cache and TLB maintenance broadcast
Date: Thu, 8 Mar 2018 14:01:21 +0000 [thread overview]
Message-ID: <1520517675.2582.11.camel@intel.com> (raw)
In-Reply-To: <031aa15c-7c15-0a75-acf9-108d1de3fd5f@denx.de>
On Thu, 2018-03-01 at 17:17 +0100, Marek Vasut wrote:
> On 02/28/2018 06:12 AM, chin.liang.see at intel.com wrote:
> >
> > From: Chin Liang See <chin.liang.see@intel.com>
> >
> > Enabling cache and TLB maintenance broadcast through ACTLR as
> > required
> > by Linux.
> This needs far more clarification. What is the problem you're fixing
> here ? How does it fix the problem ?
Sure. When the 2 processors is enabled with SMP, popen operation would
fail as content are different after the copy. This issue goes away when
we force Linux to run with 1 core only. Checked with ARM, this bit is
required by Linux when running SMP.
Chin Liang
>
> >
> > Signed-off-by: Chin Liang See <chin.liang.see@intel.com>
> > ---
> > arch/arm/mach-socfpga/misc_gen5.c | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-socfpga/misc_gen5.c b/arch/arm/mach-
> > socfpga/misc_gen5.c
> > index a7dcacc..7c7a708 100644
> > --- a/arch/arm/mach-socfpga/misc_gen5.c
> > +++ b/arch/arm/mach-socfpga/misc_gen5.c
> > @@ -239,7 +239,7 @@ static u32 iswgrp_handoff[8];
> >
> > int arch_early_init_r(void)
> > {
> > - int i;
> > + int i, val;
> >
> > /*
> > * Write magic value into magic register to unlock support
> > for
> > @@ -285,6 +285,15 @@ int arch_early_init_r(void)
> > socfpga_per_reset(SOCFPGA_RESET(NAND), 0);
> > #endif
> >
> > + /* Enable cache and TLB maintainance broadcast as required
> > by Linux */
> > + /* Read auxiliary control register */
> > + asm volatile ("mrc p15, 0, %0, c1, c0, 1\n\t" :
> > "=r"(val));
> > + val |= (1 << 0);
> > + /* Write auxiliary control register */
> > + asm volatile ("mcr p15, 0, %0, c1, c0, 1\n\t" : :
> > "r"(val));
> > + CP15DSB;
> > + CP15ISB;
> > +
> > return 0;
> > }
> >
> >
>
next prev parent reply other threads:[~2018-03-08 14:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 5:12 [U-Boot] [PATCH] arm: socfpga: gen5: Enabling cache and TLB maintenance broadcast chin.liang.see at intel.com
2018-03-01 16:17 ` Marek Vasut
2018-03-08 14:01 ` See, Chin Liang [this message]
2018-03-08 21:44 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520517675.2582.11.camel@intel.com \
--to=chin.liang.see@intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.