From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Tycho Andersen <tycho@tycho.ws>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH v2] ima: drop vla in ima_audit_measurement()
Date: Thu, 08 Mar 2018 15:36:14 -0500 [thread overview]
Message-ID: <1520541374.3605.101.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180308202347.31331-1-tycho@tycho.ws>
On Thu, 2018-03-08 at 13:23 -0700, Tycho Andersen wrote:
> /*
> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> index 2cfb0c714967..356faae6f09c 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -288,8 +288,11 @@ static int process_measurement(struct file *file, char *buf, loff_t size,
> xattr_value, xattr_len, opened);
> inode_unlock(inode);
> }
> - if (action & IMA_AUDIT)
> - ima_audit_measurement(iint, pathname);
> + if (action & IMA_AUDIT) {
> + rc = ima_audit_measurement(iint, pathname);
> + if (rc < 0)
> + goto out_locked;
> + }
>
> if ((file->f_flags & O_DIRECT) && (iint->flags & IMA_PERMIT_DIRECTIO))
> rc = 0;
Only when IMA-appraisal is enforcing file data integrity should
process_measurement() ever fail. Other errors can be logged/audited.
Mimi
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Tycho Andersen <tycho@tycho.ws>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH v2] ima: drop vla in ima_audit_measurement()
Date: Thu, 08 Mar 2018 15:36:14 -0500 [thread overview]
Message-ID: <1520541374.3605.101.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180308202347.31331-1-tycho@tycho.ws>
On Thu, 2018-03-08 at 13:23 -0700, Tycho Andersen wrote:
> /*
> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> index 2cfb0c714967..356faae6f09c 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -288,8 +288,11 @@ static int process_measurement(struct file *file, char *buf, loff_t size,
> xattr_value, xattr_len, opened);
> inode_unlock(inode);
> }
> - if (action & IMA_AUDIT)
> - ima_audit_measurement(iint, pathname);
> + if (action & IMA_AUDIT) {
> + rc = ima_audit_measurement(iint, pathname);
> + if (rc < 0)
> + goto out_locked;
> + }
>
> if ((file->f_flags & O_DIRECT) && (iint->flags & IMA_PERMIT_DIRECTIO))
> rc = 0;
Only when IMA-appraisal is enforcing file data integrity should
process_measurement() ever fail. Other errors can be logged/audited.
Mimi
next prev parent reply other threads:[~2018-03-08 20:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 20:23 [PATCH v2] ima: drop vla in ima_audit_measurement() Tycho Andersen
2018-03-08 20:36 ` Mimi Zohar [this message]
2018-03-08 20:36 ` Mimi Zohar
2018-03-08 21:45 ` Tycho Andersen
2018-03-08 21:45 ` Tycho Andersen
2018-03-08 22:05 ` Mimi Zohar
2018-03-08 22:05 ` Mimi Zohar
2018-03-08 22:15 ` Tycho Andersen
2018-03-08 22:15 ` Tycho Andersen
2018-03-08 22:28 ` Mimi Zohar
2018-03-08 22:28 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520541374.3605.101.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tycho@tycho.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.