From: Luca Boccassi <bluca@debian.org>
To: Stephen Hemminger <stephen@networkplumber.org>, green@msu.ru
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"
Date: Mon, 12 Mar 2018 21:37:50 +0000 [thread overview]
Message-ID: <1520890670.31389.1.camel@debian.org> (raw)
In-Reply-To: <20180312210301.12757-1-stephen@networkplumber.org>
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
On Mon, 2018-03-12 at 14:03 -0700, Stephen Hemminger wrote:
> This reverts commit 9135c4d6037ff9f1818507bac0049fc44db8c3d2.
>
> Debian maintainer found that basic command:
> # ip route flush all
> No longer worked as expected which breaks user scripts and
> expectations. It no longer flushed all IPv4 routes.
>
> Reported-by: Luca Boccassi <bluca@debian.org>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> ip/iproute.c | 65 ++++++++++++++++++------------------------------
> ------------
> lib/utils.c | 13 ++++++++++++
> 2 files changed, 32 insertions(+), 46 deletions(-)
Tested-by: Luca Boccassi <bluca@debian.org>
Thanks, solves the problem. I'll backport it to Debian.
Alexander, reproducing the issue is quite simple - before that commit,
ip route ls all showed all routes, but with the change it started
showing only the default table. Same for ip route flush.
--
Kind regards,
Luca Boccassi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-03-12 21:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 21:03 [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" Stephen Hemminger
2018-03-12 21:37 ` Luca Boccassi [this message]
2018-03-13 8:46 ` Alexander Zubkov
2018-03-13 11:05 ` Alexander Zubkov
2018-03-13 12:02 ` Luca Boccassi
2018-03-13 20:12 ` Alexander Zubkov
2018-03-13 20:15 ` Luca Boccassi
2018-03-14 8:59 ` Alexander Zubkov
2018-03-14 20:26 ` Alexander Zubkov
2018-03-18 16:50 ` [PATCH iproute2] treat "default" and "all"/"any" addresses differenty Alexander Zubkov
2018-03-18 17:02 ` Alexander Zubkov
2018-03-27 16:01 ` [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" Stephen Hemminger
2018-03-27 16:29 ` Alexander Zubkov
2018-03-27 17:00 ` Stephen Hemminger
2018-03-27 17:33 ` Alexander Zubkov
2018-03-27 17:58 ` Stephen Hemminger
2018-03-27 23:57 ` [PATCH iproute] arrange prefix parsing code after redundant patches Alexander Zubkov
2018-03-29 15:44 ` Stephen Hemminger
2018-03-13 20:19 ` [PATCH iproute2] treat "default" and "all"/"any" parameters differenty Alexander Zubkov
2018-03-13 21:45 ` Luca Boccassi
2018-03-16 20:37 ` Stephen Hemminger
2018-03-16 20:59 ` Alexander Zubkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520890670.31389.1.camel@debian.org \
--to=bluca@debian.org \
--cc=green@msu.ru \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.