All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Alexander Zubkov <green@msu.ru>
Cc: Luca Boccassi <bluca@debian.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH iproute2] treat "default" and "all"/"any" parameters differenty
Date: Fri, 16 Mar 2018 13:37:33 -0700	[thread overview]
Message-ID: <20180316133733.5be5be82@xeon-e3> (raw)
In-Reply-To: <3ded09a4-54f9-9d82-d952-33527a6a3e58@msu.ru>

On Tue, 13 Mar 2018 21:19:45 +0100
Alexander Zubkov <green@msu.ru> wrote:

> Debian maintainer found that basic command:
> 	# ip route flush all
> No longer worked as expected which breaks user scripts and
> expectations. It no longer flushed all IPv4 routes.
> 
> Recently behaviour of "default" prefix parameter was corrected. But at
> the same time behaviour of "all"/"any" was altered too, because they
> were the same branch of the code. As those parameters mean different,
> they need to be treated differently in code too. This patch reflects
> the difference.
> 
> Reported-by: Luca Boccassi <bluca@debian.org>
> Signed-off-by: Alexander Zubkov <green@msu.ru>
> ---
>   lib/utils.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/utils.c b/lib/utils.c
> index 9fa5220..b289d9c 100644
> --- a/lib/utils.c
> +++ b/lib/utils.c
> @@ -658,7 +658,8 @@ int get_prefix_1(inet_prefix *dst, char *arg, int 
> family)
>   		dst->family = family;
>   		dst->bytelen = 0;
>   		dst->bitlen = 0;
> -		dst->flags |= PREFIXLEN_SPECIFIED;
> +		if (strcmp(arg, "default") == 0)
> +			dst->flags |= PREFIXLEN_SPECIFIED;
>   		return 0;
>   	}
> 
> --
> 1.9.1
> 

Which code is this a patch against? the current master or followup to my revert
of the original patch?

  parent reply	other threads:[~2018-03-16 20:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12 21:03 [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" Stephen Hemminger
2018-03-12 21:37 ` Luca Boccassi
2018-03-13  8:46   ` Alexander Zubkov
2018-03-13 11:05     ` Alexander Zubkov
2018-03-13 12:02       ` Luca Boccassi
2018-03-13 20:12         ` Alexander Zubkov
2018-03-13 20:15           ` Luca Boccassi
2018-03-14  8:59           ` Alexander Zubkov
2018-03-14 20:26             ` Alexander Zubkov
2018-03-18 16:50               ` [PATCH iproute2] treat "default" and "all"/"any" addresses differenty Alexander Zubkov
2018-03-18 17:02                 ` Alexander Zubkov
2018-03-27 16:01               ` [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" Stephen Hemminger
2018-03-27 16:29                 ` Alexander Zubkov
2018-03-27 17:00                   ` Stephen Hemminger
2018-03-27 17:33                     ` Alexander Zubkov
2018-03-27 17:58                       ` Stephen Hemminger
2018-03-27 23:57                         ` [PATCH iproute] arrange prefix parsing code after redundant patches Alexander Zubkov
2018-03-29 15:44                           ` Stephen Hemminger
2018-03-13 20:19         ` [PATCH iproute2] treat "default" and "all"/"any" parameters differenty Alexander Zubkov
2018-03-13 21:45           ` Luca Boccassi
2018-03-16 20:37           ` Stephen Hemminger [this message]
2018-03-16 20:59             ` Alexander Zubkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180316133733.5be5be82@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=bluca@debian.org \
    --cc=green@msu.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.