From: "Souza, Jose" <jose.souza@intel.com>
To: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
Cc: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [RFC] drm/i915/psr: Remove PSR active flag from debugfs
Date: Tue, 13 Mar 2018 17:20:58 +0000 [thread overview]
Message-ID: <1520961484.1640.3.camel@intel.com> (raw)
In-Reply-To: <20180313044211.27105-1-dhinakaran.pandiyan@intel.com>
On Mon, 2018-03-12 at 21:42 -0700, Dhinakaran Pandiyan wrote:
> The flag becomes misleading with flips and cursor moves not modifying
> it's
> state as HW takes care of exiting PSR (when HW tracking is enabled)
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> b/drivers/gpu/drm/i915/i915_debugfs.c
> index c4cc8fef11a0..416dcb703e23 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2565,7 +2565,6 @@ static int i915_edp_psr_status(struct seq_file
> *m, void *data)
>
> mutex_lock(&dev_priv->psr.lock);
> seq_printf(m, "Enabled: %s\n", yesno((bool)dev_priv-
> >psr.enabled));
> - seq_printf(m, "Active: %s\n", yesno(dev_priv->psr.active));
Maybe would be better rename to something else, like "Hardware
activated/enabled".
> seq_printf(m, "Busy frontbuffer bits: 0x%03x\n",
> dev_priv->psr.busy_frontbuffer_bits);
> seq_printf(m, "Re-enable work scheduled: %s\n",
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-13 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 4:42 [RFC] drm/i915/psr: Remove PSR active flag from debugfs Dhinakaran Pandiyan
2018-03-13 5:28 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-13 9:13 ` ✓ Fi.CI.IGT: " Patchwork
2018-03-13 17:20 ` Souza, Jose [this message]
2018-03-13 18:36 ` [RFC] " Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520961484.1640.3.camel@intel.com \
--to=jose.souza@intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.