* [RFC] drm/i915/psr: Remove PSR active flag from debugfs
@ 2018-03-13 4:42 Dhinakaran Pandiyan
2018-03-13 5:28 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Dhinakaran Pandiyan @ 2018-03-13 4:42 UTC (permalink / raw)
To: intel-gfx; +Cc: Dhinakaran Pandiyan, Rodrigo Vivi
The flag becomes misleading with flips and cursor moves not modifying it's
state as HW takes care of exiting PSR (when HW tracking is enabled)
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index c4cc8fef11a0..416dcb703e23 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2565,7 +2565,6 @@ static int i915_edp_psr_status(struct seq_file *m, void *data)
mutex_lock(&dev_priv->psr.lock);
seq_printf(m, "Enabled: %s\n", yesno((bool)dev_priv->psr.enabled));
- seq_printf(m, "Active: %s\n", yesno(dev_priv->psr.active));
seq_printf(m, "Busy frontbuffer bits: 0x%03x\n",
dev_priv->psr.busy_frontbuffer_bits);
seq_printf(m, "Re-enable work scheduled: %s\n",
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/psr: Remove PSR active flag from debugfs
2018-03-13 4:42 [RFC] drm/i915/psr: Remove PSR active flag from debugfs Dhinakaran Pandiyan
@ 2018-03-13 5:28 ` Patchwork
2018-03-13 9:13 ` ✓ Fi.CI.IGT: " Patchwork
2018-03-13 17:20 ` [RFC] " Souza, Jose
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-03-13 5:28 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Remove PSR active flag from debugfs
URL : https://patchwork.freedesktop.org/series/39829/
State : success
== Summary ==
Series 39829v1 drm/i915/psr: Remove PSR active flag from debugfs
https://patchwork.freedesktop.org/api/1.0/series/39829/revisions/1/mbox/
---- Known issues:
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
fail -> PASS (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
incomplete -> PASS (fi-snb-2520m) fdo#103713
Subgroup suspend-read-crc-pipe-c:
pass -> INCOMPLETE (fi-hsw-4770) fdo#104944
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104944 https://bugs.freedesktop.org/show_bug.cgi?id=104944
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:429s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:382s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:533s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:298s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:507s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:506s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:513s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:499s
fi-cfl-8700k total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:408s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:584s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:429s
fi-gdg-551 total:288 pass:180 dwarn:0 dfail:0 fail:0 skip:108 time:314s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:533s
fi-hsw-4770 total:246 pass:222 dwarn:0 dfail:0 fail:0 skip:23
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:425s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:472s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:427s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:473s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:468s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:514s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:650s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:441s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:529s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:540s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:508s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:488s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:427s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:538s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:397s
Blacklisted hosts:
fi-cfl-u total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:516s
fi-cnl-drrs total:288 pass:257 dwarn:3 dfail:0 fail:0 skip:28 time:530s
fi-glk-j5005 failed to collect. IGT log at Patchwork_8322/fi-glk-j5005/run0.log
da600bbe24412edd1c46591fd21ef81518e49c5d drm-tip: 2018y-03m-12d-22h-06m-53s UTC integration manifest
2ac8348a9b54 drm/i915/psr: Remove PSR active flag from debugfs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8322/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915/psr: Remove PSR active flag from debugfs
2018-03-13 4:42 [RFC] drm/i915/psr: Remove PSR active flag from debugfs Dhinakaran Pandiyan
2018-03-13 5:28 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-03-13 9:13 ` Patchwork
2018-03-13 17:20 ` [RFC] " Souza, Jose
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-03-13 9:13 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Remove PSR active flag from debugfs
URL : https://patchwork.freedesktop.org/series/39829/
State : success
== Summary ==
---- Known issues:
Test gem_eio:
Subgroup in-flight-contexts:
incomplete -> PASS (shard-apl) fdo#105341 +1
Test kms_atomic_transition:
Subgroup 1x-modeset-transitions-nonblocking-fencing:
fail -> PASS (shard-apl) fdo#103207
Test kms_cursor_crc:
Subgroup cursor-256x256-suspend:
skip -> PASS (shard-snb) fdo#103375
Test perf:
Subgroup blocking:
pass -> FAIL (shard-hsw) fdo#102252
fdo#105341 https://bugs.freedesktop.org/show_bug.cgi?id=105341
fdo#103207 https://bugs.freedesktop.org/show_bug.cgi?id=103207
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
shard-apl total:3377 pass:1778 dwarn:1 dfail:0 fail:6 skip:1590 time:12597s
shard-hsw total:3473 pass:1776 dwarn:1 dfail:0 fail:3 skip:1692 time:11950s
shard-snb total:3473 pass:1365 dwarn:1 dfail:0 fail:3 skip:2104 time:7257s
Blacklisted hosts:
shard-kbl total:3310 pass:1872 dwarn:1 dfail:0 fail:8 skip:1427 time:9387s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8322/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [RFC] drm/i915/psr: Remove PSR active flag from debugfs
2018-03-13 4:42 [RFC] drm/i915/psr: Remove PSR active flag from debugfs Dhinakaran Pandiyan
2018-03-13 5:28 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-13 9:13 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-03-13 17:20 ` Souza, Jose
2018-03-13 18:36 ` Rodrigo Vivi
2 siblings, 1 reply; 5+ messages in thread
From: Souza, Jose @ 2018-03-13 17:20 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org, Pandiyan, Dhinakaran; +Cc: Vivi, Rodrigo
On Mon, 2018-03-12 at 21:42 -0700, Dhinakaran Pandiyan wrote:
> The flag becomes misleading with flips and cursor moves not modifying
> it's
> state as HW takes care of exiting PSR (when HW tracking is enabled)
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> b/drivers/gpu/drm/i915/i915_debugfs.c
> index c4cc8fef11a0..416dcb703e23 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2565,7 +2565,6 @@ static int i915_edp_psr_status(struct seq_file
> *m, void *data)
>
> mutex_lock(&dev_priv->psr.lock);
> seq_printf(m, "Enabled: %s\n", yesno((bool)dev_priv-
> >psr.enabled));
> - seq_printf(m, "Active: %s\n", yesno(dev_priv->psr.active));
Maybe would be better rename to something else, like "Hardware
activated/enabled".
> seq_printf(m, "Busy frontbuffer bits: 0x%03x\n",
> dev_priv->psr.busy_frontbuffer_bits);
> seq_printf(m, "Re-enable work scheduled: %s\n",
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC] drm/i915/psr: Remove PSR active flag from debugfs
2018-03-13 17:20 ` [RFC] " Souza, Jose
@ 2018-03-13 18:36 ` Rodrigo Vivi
0 siblings, 0 replies; 5+ messages in thread
From: Rodrigo Vivi @ 2018-03-13 18:36 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx@lists.freedesktop.org, Pandiyan, Dhinakaran
On Tue, Mar 13, 2018 at 10:20:58AM -0700, Souza, Jose wrote:
> On Mon, 2018-03-12 at 21:42 -0700, Dhinakaran Pandiyan wrote:
> > The flag becomes misleading with flips and cursor moves not modifying
> > it's
> > state as HW takes care of exiting PSR (when HW tracking is enabled)
> >
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_debugfs.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> > b/drivers/gpu/drm/i915/i915_debugfs.c
> > index c4cc8fef11a0..416dcb703e23 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -2565,7 +2565,6 @@ static int i915_edp_psr_status(struct seq_file
> > *m, void *data)
> >
> > mutex_lock(&dev_priv->psr.lock);
> > seq_printf(m, "Enabled: %s\n", yesno((bool)dev_priv-
> > >psr.enabled));
> > - seq_printf(m, "Active: %s\n", yesno(dev_priv->psr.active));
>
> Maybe would be better rename to something else, like "Hardware
> activated/enabled".
Actually is the other way around. But this just show us how confusing
it is. So,
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> > seq_printf(m, "Busy frontbuffer bits: 0x%03x\n",
> > dev_priv->psr.busy_frontbuffer_bits);
> > seq_printf(m, "Re-enable work scheduled: %s\n",
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-13 18:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-13 4:42 [RFC] drm/i915/psr: Remove PSR active flag from debugfs Dhinakaran Pandiyan
2018-03-13 5:28 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-13 9:13 ` ✓ Fi.CI.IGT: " Patchwork
2018-03-13 17:20 ` [RFC] " Souza, Jose
2018-03-13 18:36 ` Rodrigo Vivi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.