From: Aaron Lindsay <alindsay@codeaurora.org>
To: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Alistair Francis <alistair.francis@xilinx.com>,
Wei Huang <wei@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>
Cc: Aaron Lindsay <alindsay@codeaurora.org>,
Michael Spradling <mspradli@codeaurora.org>,
qemu-devel@nongnu.org, Digant Desai <digantd@codeaurora.org>
Subject: [Qemu-arm] [PATCH v3 18/22] target/arm: Add array for supported PMU events, generate PMCEID[01]
Date: Fri, 16 Mar 2018 16:31:16 -0400 [thread overview]
Message-ID: <1521232280-13089-19-git-send-email-alindsay@codeaurora.org> (raw)
In-Reply-To: <1521232280-13089-1-git-send-email-alindsay@codeaurora.org>
This commit doesn't add any supported events, but provides the framework
for adding them. We store the pm_event structs in a simple array, and
provide the mapping from the event numbers to array indexes in
the supported_event_map array.
Signed-off-by: Aaron Lindsay <alindsay@codeaurora.org>
---
target/arm/cpu.c | 4 ++++
target/arm/cpu.h | 10 ++++++++++
target/arm/helper.c | 37 +++++++++++++++++++++++++++++++++++++
3 files changed, 51 insertions(+)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index e544f1d..69d6a80 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -889,6 +889,10 @@ static void arm_cpu_realizefn(DeviceState *dev, Error **errp)
unset_feature(env, ARM_FEATURE_PMU);
cpu->id_aa64dfr0 &= ~0xf00;
} else {
+ uint64_t pmceid = get_pmceid(&cpu->env);
+ cpu->pmceid0 = pmceid & 0xffffffff;
+ cpu->pmceid1 = (pmceid >> 32) & 0xffffffff;
+
arm_register_pre_el_change_hook(cpu, &pmu_pre_el_change, 0);
arm_register_el_change_hook(cpu, &pmu_post_el_change, 0);
}
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index cc1e2fb..19f005d 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -931,6 +931,16 @@ void pmu_op_finish(CPUARMState *env, uint64_t prev_cycles);
void pmu_pre_el_change(ARMCPU *cpu, void *ignored);
void pmu_post_el_change(ARMCPU *cpu, void *ignored);
+/*
+ * get_pmceid
+ * @env: CPUARMState
+ *
+ * Return the PMCEID[01] register values corresponding to the counters which
+ * are supported given the current configuration (0 is low 32, 1 is high 32
+ * bits)
+ */
+uint64_t get_pmceid(CPUARMState *env);
+
/* SCTLR bit meanings. Several bits have been reused in newer
* versions of the architecture; in that case we define constants
* for both old and new bit meanings. Code which tests against those
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 2073d56..6a4f900 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -925,6 +925,43 @@ static const ARMCPRegInfo v6_cp_reginfo[] = {
/* Bits allowed to be set/cleared for PMCNTEN* and PMINTEN* */
#define PMU_COUNTER_MASK(env) ((1 << 31) | ((1 << PMU_NUM_COUNTERS(env)) - 1))
+typedef struct pm_event {
+ uint16_t number; /* PMEVTYPER.evtCount is 10 bits wide */
+ /* If the event is supported on this CPU (used to generate PMCEID[01]) */
+ bool (*supported)(CPUARMState *);
+ /* Retrieve the current count of the underlying event. The programmed
+ * counters hold a difference from the return value from this function */
+ uint64_t (*get_count)(CPUARMState *);
+} pm_event;
+
+#define SUPPORTED_EVENT_SENTINEL UINT16_MAX
+static const pm_event pm_events[] = {
+ { .number = SUPPORTED_EVENT_SENTINEL }
+};
+static uint16_t supported_event_map[0x3f];
+
+/*
+ * Called upon initialization to build PMCEID0 (low 32 bits) and PMCEID1 (high
+ * 32). We also use it to build a map of ARM event numbers to indices in
+ * our pm_events array.
+ */
+uint64_t get_pmceid(CPUARMState *env)
+{
+ uint64_t pmceid = 0;
+ unsigned int i = 0;
+ while (pm_events[i].number != SUPPORTED_EVENT_SENTINEL) {
+ const pm_event *cnt = &pm_events[i];
+ if (cnt->number < 0x3f && cnt->supported(env)) {
+ pmceid |= (1 << cnt->number);
+ supported_event_map[cnt->number] = i;
+ } else {
+ supported_event_map[cnt->number] = SUPPORTED_EVENT_SENTINEL;
+ }
+ i++;
+ }
+ return pmceid;
+}
+
static CPAccessResult pmreg_access(CPUARMState *env, const ARMCPRegInfo *ri,
bool isread)
{
--
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-03-16 20:43 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 20:30 [Qemu-arm] [PATCH v3 00/22] More fully implement ARM PMUv3 Aaron Lindsay
2018-03-16 20:30 ` [Qemu-arm] [PATCH v3 01/22] target/arm: A53: Initialize PMCEID[01] Aaron Lindsay
2018-03-18 22:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-18 22:57 ` Philippe Mathieu-Daudé
2018-03-19 20:35 ` Aaron Lindsay
2018-03-20 1:03 ` Philippe Mathieu-Daudé
2018-03-21 15:17 ` Aaron Lindsay
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 02/22] target/arm: A15 PMCEID0 initialization style nit Aaron Lindsay
2018-04-12 16:07 ` Peter Maydell
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 03/22] target/arm: Check PMCNTEN for whether PMCCNTR is enabled Aaron Lindsay
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 04/22] target/arm: Treat PMCCNTR as alias of PMCCNTR_EL0 Aaron Lindsay
2018-04-12 16:10 ` Peter Maydell
2018-04-12 16:56 ` Aaron Lindsay
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 05/22] target/arm: Reorganize PMCCNTR read, write, sync Aaron Lindsay
2018-04-12 16:18 ` Peter Maydell
2018-04-13 13:51 ` Aaron Lindsay
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 06/22] target/arm: Mask PMU register writes based on PMCR_EL0.N Aaron Lindsay
2018-04-12 16:24 ` Peter Maydell
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 07/22] target/arm: Fetch GICv3 state directly from CPUARMState Aaron Lindsay
2018-04-12 16:28 ` Peter Maydell
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 08/22] target/arm: Support multiple EL change hooks Aaron Lindsay
2018-03-18 22:41 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-20 20:45 ` Aaron Lindsay
2018-03-20 21:01 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-04-12 16:36 ` [Qemu-devel] " Peter Maydell
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 09/22] target/arm: Add pre-EL " Aaron Lindsay
2018-04-12 16:49 ` Peter Maydell
2018-04-12 17:01 ` Aaron Lindsay
2018-04-12 17:21 ` Peter Maydell
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 10/22] target/arm: Allow EL change hooks to do IO Aaron Lindsay
2018-04-12 16:53 ` Peter Maydell
2018-04-12 17:08 ` Aaron Lindsay
2018-04-12 17:21 ` Peter Maydell
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 11/22] target/arm: Fix bitmask for PMCCFILTR writes Aaron Lindsay
2018-04-12 16:41 ` [Qemu-devel] " Peter Maydell
2018-04-13 18:15 ` [Qemu-arm] " Aaron Lindsay
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 12/22] target/arm: Filter cycle counter based on PMCCFILTR_EL0 Aaron Lindsay
2018-04-12 17:15 ` Peter Maydell
2018-04-12 17:36 ` Aaron Lindsay
2018-04-17 15:21 ` Aaron Lindsay
2018-04-17 15:37 ` Peter Maydell
2018-04-17 20:03 ` Aaron Lindsay
2018-03-16 20:31 ` [Qemu-devel] [PATCH v3 13/22] target/arm: Allow AArch32 access for PMCCFILTR Aaron Lindsay
2018-03-16 20:31 ` [Qemu-devel] [PATCH v3 14/22] target/arm: Make PMOVSCLR 64 bits wide Aaron Lindsay
2018-03-18 23:14 ` Philippe Mathieu-Daudé
2018-03-19 15:24 ` [Qemu-arm] " Aaron Lindsay
2018-03-19 15:31 ` Peter Maydell
2018-03-20 1:01 ` Philippe Mathieu-Daudé
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions Aaron Lindsay
2018-03-18 22:42 ` Philippe Mathieu-Daudé
2018-04-12 17:17 ` Peter Maydell
2018-04-17 14:23 ` Aaron Lindsay
2018-04-17 15:00 ` Peter Maydell
2018-04-24 20:35 ` Aaron Lindsay
2018-05-17 19:31 ` Aaron Lindsay
2018-05-31 14:18 ` Peter Maydell
2018-05-31 20:39 ` Aaron Lindsay
2018-06-01 8:57 ` Peter Maydell
2018-06-01 15:34 ` [Qemu-devel] " Aaron Lindsay
2018-06-01 15:59 ` Peter Maydell
2018-06-01 19:12 ` [Qemu-arm] " Aaron Lindsay
2018-03-16 20:31 ` [Qemu-devel] [PATCH v3 16/22] target/arm: Implement PMOVSSET Aaron Lindsay
2018-04-12 17:28 ` [Qemu-arm] " Peter Maydell
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 17/22] target/arm: Split arm_ccnt_enabled into generic pmu_counter_enabled Aaron Lindsay
2018-04-12 17:29 ` Peter Maydell
2018-03-16 20:31 ` Aaron Lindsay [this message]
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 19/22] target/arm: Finish implementation of PM[X]EVCNTR and PM[X]EVTYPER Aaron Lindsay
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 20/22] target/arm: PMU: Add instruction and cycle events Aaron Lindsay
2018-03-18 22:43 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-18 22:48 ` Philippe Mathieu-Daudé
2018-03-19 17:36 ` Aaron Lindsay
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 21/22] target/arm: PMU: Set PMCR.N to 4 Aaron Lindsay
2018-03-16 20:31 ` [Qemu-arm] [PATCH v3 22/22] target/arm: Implement PMSWINC Aaron Lindsay
2018-03-16 20:58 ` [Qemu-devel] [PATCH v3 00/22] More fully implement ARM PMUv3 no-reply
2018-03-17 0:01 ` [Qemu-arm] " Aaron Lindsay
2018-04-12 17:17 ` [Qemu-arm] [PATCH v3] RFC: target/arm: Send interrupts on PMU counter overflow Aaron Lindsay
2018-04-12 17:32 ` [Qemu-arm] [PATCH v3 00/22] More fully implement ARM PMUv3 Peter Maydell
2018-04-12 19:34 ` Aaron Lindsay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521232280-13089-19-git-send-email-alindsay@codeaurora.org \
--to=alindsay@codeaurora.org \
--cc=alistair.francis@xilinx.com \
--cc=crosthwaite.peter@gmail.com \
--cc=digantd@codeaurora.org \
--cc=mspradli@codeaurora.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.